fix: change task share destination error message by allroundexperts · Pull Request #19879 · Expensify/App

allroundexperts · 2023-05-31T10:20:29Z

Details

This PR fixes the incorrect error message that showed up once we tried to submit a new task.

Fixed Issues

$ #18669
PROPOSAL: #18669 (comment)

Tests

Open the App and login with an account that has the beta permission for tasks.
If you are already logged in, make sure to logout and log in again.
Enter the following url in the browser: http://staging.new.expensify.com/new/task
Click Confirm Task button and verify that an error appears asking for both Title and Share destination.
Click on Title option and enter it. Click on Confirm Task button again and Verify that an error appears asking for Share destination only.
Logout and login again. Again go to the same URL as above. Select a person from Share somewhere option and click the Confirm Task button. Verify that an error appears asking to enter title only.
Repeat the above steps for Spanish translations checking.

Verify that an error appears asking to enter task share destination.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Open the App and login with an account that has the beta permission for tasks.
If you are already logged in, make sure to logout and log in again.
Enter the following url in the browser: http://staging.new.expensify.com/new/task
Click Confirm Task button and verify that an error appears asking for both Title and Share destination.
Click on Title option and enter it. Click on Confirm Task button again and Verify that an error appears asking for Share destination only.
Logout and login again. Again go to the same URL as above. Select a person from Share somewhere option and click the Confirm Task button. Verify that an error appears asking to enter title only.
Repeat the above steps for Spanish translations checking.

Verify that an error appears asking to enter task share destination.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-05-31T10:20:34Z

@madmax330 @aimane-chnaif One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2023-06-01T09:45:23Z

Bump @aimane-chnaif!

aimane-chnaif · 2023-06-01T16:21:42Z

    const [assignee, setAssignee] = React.useState({});
    const [shareDestination, setShareDestination] = React.useState({});
-    const [submitError, setSubmitError] = React.useState(false);
    const [errorMessage, setErrorMessage] = React.useState(props.translate('newTaskPage.confirmError'));


Suggested change

const [errorMessage, setErrorMessage] = React.useState(props.translate('newTaskPage.confirmError'));

const [errorMessage, setErrorMessage] = React.useState('');

Sign in to view

@@ -1264,7 +1264,7 @@ export default {
        markAsDone: 'Mark as done',
        markAsIncomplete: 'Mark as incomplete',
        pleaseEnterTaskAssignee: 'Please select an assignee',


aimane-chnaif · 2023-06-01T16:42:01Z

@allroundexperts 2 bugs on this video:

error message shows briefly and then disappears (this is already happening on main)
title is missing but not showing in error message (we cannot remove title validation when deep link)

bug.mov

allroundexperts · 2023-06-01T19:38:18Z

@aimane-chnaif Do we want to fix the below in this PR?

error message shows briefly and then disappears (this is already happening on main)

allroundexperts · 2023-06-01T19:39:44Z

title is missing but not showing in error message (we cannot remove title validation when deep link)

Handled.

aimane-chnaif · 2023-06-01T19:52:38Z

@allroundexperts lint failing

Updated code looks good, though we should still wait for confirmation on all error copies as I commented on GH.
cc: @madmax330

aimane-chnaif · 2023-06-05T19:08:57Z

@allroundexperts let's just add periods to every sentence and then we are all good

aimane-chnaif · 2023-06-05T19:09:44Z

                </View>
                <FormAlertWithSubmitButton
-                    isAlertVisible={submitError}
+                    isAlertVisible={!!errorMessage}


Suggested change

isAlertVisible={!!errorMessage}

isAlertVisible={!_.isEmpty(errorMessage)}

aimane-chnaif · 2023-06-05T19:39:25Z

@allroundexperts can you share example case on the issue and tag copy writer?

aimane-chnaif · 2023-06-05T19:45:30Z

now conflicts

allroundexperts · 2023-06-05T19:47:00Z

@allroundexperts can you share example case on the issue and tag copy writer?

My bad. Looks like we are using period at a lot of places. I take my comment back!

aimane-chnaif · 2023-06-05T20:48:21Z

@allroundexperts please update Tests step to cover all cases with 3 different errors.

This is sample test case:

msafari.mov

allroundexperts · 2023-06-05T21:12:12Z

@allroundexperts please update Tests step to cover all cases with 3 different errors

Updated @aimane-chnaif!

aimane-chnaif · 2023-06-05T21:18:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

aimane-chnaif

@madmax330 LGTM 🎉

aimane-chnaif · 2023-06-06T02:51:26Z

@allroundexperts please fix conflict again

allroundexperts · 2023-06-06T23:28:47Z

@madmax330 Friendly bump for the review!

OSBotify · 2023-06-07T06:38:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-08T17:03:30Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.26-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-13T00:24:12Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.26-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

allroundexperts added 2 commits May 31, 2023 15:03

fix: change task share destination error message

9f9cd09

fix: removed title check

02d78f8

allroundexperts requested a review from a team as a code owner May 31, 2023 10:20

melvin-bot Bot requested review from aimane-chnaif and removed request for a team May 31, 2023 10:20

melvin-bot Bot requested a review from madmax330 May 31, 2023 10:20

allroundexperts mentioned this pull request May 31, 2023

[HOLD for payment 2023-06-19] [$1000] Assign Task - An incorrect error message is displayed when clicking confirm task #18669

Closed

6 tasks

aimane-chnaif suggested changes Jun 1, 2023

View reviewed changes

fix: update task errors

c82883f

fix prettier error

8148558

aimane-chnaif reviewed Jun 5, 2023

View reviewed changes

This comment was marked as outdated.

Sign in to view

allroundexperts added 2 commits June 6, 2023 00:39

fix: use isEmpty instead of 'clear' operator in NewTaskPage

25e5ede

fix: add period at the end newTaskPage errors copy

1091567

Merge branch 'main' into fix-18669

ad5174a

allroundexperts requested a review from aimane-chnaif June 5, 2023 21:11

aimane-chnaif approved these changes Jun 5, 2023

View reviewed changes

merge with main and resolve conflicts

ec16a54

aimane-chnaif approved these changes Jun 6, 2023

View reviewed changes

madmax330 approved these changes Jun 7, 2023

View reviewed changes

madmax330 merged commit 24e960c into Expensify:main Jun 7, 2023

OSBotify mentioned this pull request Jun 8, 2023

Deploy Checklist: New Expensify 2023-06-08 #20466

Closed

74 tasks

lanitochka17 mentioned this pull request Jun 9, 2023

[$1000] Assign task - Error in console when open staging.new.expensify.com/new/task #20521

Closed

6 tasks

	const [errorMessage, setErrorMessage] = React.useState(props.translate('newTaskPage.confirmError'));
	const [errorMessage, setErrorMessage] = React.useState('');

	isAlertVisible={!!errorMessage}
	isAlertVisible={!_.isEmpty(errorMessage)}

Uh oh!

Conversation

allroundexperts commented May 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 31, 2023

Uh oh!

allroundexperts commented Jun 1, 2023

Uh oh!

aimane-chnaif Jun 1, 2023

Choose a reason for hiding this comment

Uh oh!

allroundexperts Jun 1, 2023

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

aimane-chnaif commented Jun 1, 2023

Uh oh!

allroundexperts commented Jun 1, 2023

Uh oh!

allroundexperts commented Jun 1, 2023

Uh oh!

aimane-chnaif commented Jun 1, 2023

Uh oh!

aimane-chnaif commented Jun 5, 2023

Uh oh!

aimane-chnaif Jun 5, 2023

Choose a reason for hiding this comment

Uh oh!

allroundexperts Jun 5, 2023

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

aimane-chnaif commented Jun 5, 2023

Uh oh!

aimane-chnaif commented Jun 5, 2023

Uh oh!

allroundexperts commented Jun 5, 2023

Uh oh!

aimane-chnaif commented Jun 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allroundexperts commented Jun 5, 2023

Uh oh!

aimane-chnaif commented Jun 5, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif left a comment

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Jun 6, 2023

Uh oh!

allroundexperts commented Jun 6, 2023

Uh oh!

OSBotify commented Jun 7, 2023

Uh oh!

OSBotify commented Jun 8, 2023

Uh oh!

OSBotify commented Jun 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

allroundexperts commented May 31, 2023 •

edited

Loading

aimane-chnaif commented Jun 5, 2023 •

edited

Loading