Skip staging deploy if StagingDeployCash is locked#1959
Merged
Conversation
Jag96
approved these changes
Mar 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
We should not be doing staging deploys when the
StagingDeployCashis locked. See this workflow for an example of what we don't want to happen.This happened because we temporarily re-arranged when we deploy staging to get this process built out quicker, so this PR is a temporary fix so we can start using the QA process w/ Applause.
Fixed Issues
Fixes broken workflow run: https://github.com/Expensify/Expensify.cash/runs/2152639779?check_suite_focus=true
Tests
preDeployworkflow that is triggered when this PR is merged. It should not push tags to deploy staging.