Move ReportActionContextMenu up for grouped ReportActionItems#1948
Merged
Conversation
marcaaron
approved these changes
Mar 19, 2021
marcaaron
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this change @roryabraham! Looks great ❤️
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
@roryabraham @marcaaron This PR seems like it didn't make it to staging. We're unable to see the small menu above the messages in the web or desktop app |
Contributor
Author
|
Hi @isagoico, I just edited the PR description to add proper QA steps. The menu is currently hidden behind a beta. Do you have access to the Betatify tool to add yourself to betas? I can't remember... I think not so there's an alternative option to get the menu to appear. |
|
No, I think we haven't used the Betatify tool before and don't have access to it. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Details
For grouped
ReportActionItem, shift the context menu up and out of the way of any text.Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/157893
Tests
QA Steps
Tested On
Mobile WebiOSAndroidScreenshots
Web
Mobile Web
This component does not display on mobile web.
Desktop
iOS
This component does not display on iOS
Android
This component does not display on Android