Skip to content

Skip mobile staging deploys for production releases #1932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndrewGable merged 3 commits into from
Mar 19, 2021
+10 −8
Merged

Skip mobile staging deploys for production releases #1932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04d4f89
Skip mobile staging deploys for production releases
roryabraham Mar 19, 2021
1130742
Remove TODO and enable check for release event
roryabraham Mar 19, 2021
c865c83
Skip prod deploys always for now
roryabraham Mar 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@ jobs:
if: github.actor == 'OSBotify'
runs-on: ubuntu-latest
env:
# TODO: Uncomment when we'd like to deploy to production
# SHOULD_DEPLOY_PRODUCTION: ${{ github.event_name == 'release' }}
SHOULD_DEPLOY_PRODUCTION: ${{ false }}
SHOULD_DEPLOY_PRODUCTION: ${{ github.event_name == 'release' }}
steps:
- uses: actions/checkout@v2

Expand Down Expand Up @@ -47,10 +45,13 @@ jobs:
LARGE_SECRET_PASSPHRASE: ${{ secrets.LARGE_SECRET_PASSPHRASE }}

- name: Run Fastlane beta
if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'false' }}
run: bundle exec fastlane android beta

# TODO: uncomment when we want to release iOS to production
- name: Run Fastlane production
if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'true' }}
# if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'true' }}
if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'true' && 'false' == 'true' }}
run: bundle exec fastlane android production
env:
VERSION: ${{ env.VERSION }}
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/ios.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@ jobs:
if: github.actor == 'OSBotify'
runs-on: macos-latest
env:
# TODO: Uncomment when we'd like to deploy to production7
# SHOULD_DEPLOY_PRODUCTION: ${{ github.event_name == 'release' }}
SHOULD_DEPLOY_PRODUCTION: ${{ false }}
SHOULD_DEPLOY_PRODUCTION: ${{ github.event_name == 'release' }}
steps:
- uses: actions/checkout@v2

Expand Down Expand Up @@ -63,15 +61,18 @@ jobs:
LARGE_SECRET_PASSPHRASE: ${{ secrets.LARGE_SECRET_PASSPHRASE }}

- name: Run Fastlane
if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'false' }}
run: bundle exec fastlane ios beta
env:
APPLE_CONTACT_EMAIL: ${{ secrets.APPLE_CONTACT_EMAIL }}
APPLE_CONTACT_PHONE: ${{ secrets.APPLE_CONTACT_PHONE }}
APPLE_DEMO_EMAIL: ${{ secrets.APPLE_DEMO_EMAIL }}
APPLE_DEMO_PASSWORD: ${{ secrets.APPLE_DEMO_PASSWORD }}

# TODO: uncomment when we want to release iOS to production
- name: Run Fastlane for App Store release
if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'true' }}
# if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'true' }}
if: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'true' && 'false' == 'true' }}
run: bundle exec fastlane ios production
env:
VERSION: ${{ env.NEW_IOS_VERSION }}
Expand Down