Skip to content

Adjust IOUPreview height based on description availability #18774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 8 commits into from
May 14, 2023
Merged

Adjust IOUPreview height based on description availability #18774

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e57fc34
Adjust iou preview height based on description availability
huzaifa-99 May 11, 2023
e8fb8ad
Updated variable name for better semantics
huzaifa-99 May 11, 2023
0c5ac86
Updated conditional check
huzaifa-99 May 11, 2023
c9d5196
Merge branch 'main' into 18770-fix-iou-preview-height-inconsistency
huzaifa-99 May 12, 2023
c5ce199
Merge branch 'Expensify:main' into 18770-fix-iou-preview-height-incon…
huzaifa-99 May 12, 2023
0f9dd43
Merge branch 'main' into 18770-fix-iou-preview-height-inconsistency
huzaifa-99 May 14, 2023
ada98d1
Added end of file line break
huzaifa-99 May 14, 2023
076bfdb
Merge branch 'Expensify:main' into 18770-fix-iou-preview-height-incon…
huzaifa-99 May 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/ReportActionItem/IOUPreview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ const IOUPreview = (props) => {
const sessionEmail = lodashGet(props.session, 'email', null);
const managerEmail = props.iouReport.managerEmail || '';
const ownerEmail = props.iouReport.ownerEmail || '';
const comment = Str.htmlDecode(lodashGet(props.action, 'originalMessage.comment', '')).trim();

// When displaying within a IOUDetailsModal we cannot guarantee that participants are included in the originalMessage data
// Because an IOUPreview of type split can never be rendered within the IOUDetailsModal, manually building the email array is only needed for non-billSplit ious
Expand Down Expand Up @@ -231,7 +232,7 @@ const IOUPreview = (props) => {
{!isCurrentUserManager && props.shouldShowPendingConversionMessage && (
<Text style={[styles.textLabel, styles.colorMuted]}>{props.translate('iou.pendingConversionMessage')}</Text>
)}
<Text style={[styles.colorMuted]}>{Str.htmlDecode(lodashGet(props.action, 'originalMessage.comment', ''))}</Text>
{!_.isEmpty(comment) && <Text style={[styles.colorMuted]}>{comment}</Text>}
</View>
{props.isBillSplit && !_.isEmpty(participantEmails) && (
<Text style={[styles.textLabel, styles.colorMuted, styles.ml1]}>
Expand Down