Disable iOS code block bounces by hellohublot · Pull Request #18487 · Expensify/App

hellohublot · 2023-05-05T16:45:49Z

Details

We disable BasePreRenderer.ScrollView.bounces on the iOS native platform, keep it consistent with Android platform, so that the left swipe navigation gesture will not be interrupted

Fixed Issues

$ #18111
$ #18111 (comment)

Tests

Send a message

```hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh```

Send a message

```hhhhhhhh
hhhhhhhh```

Verify that both messages have no spring effect on the iOS native platform

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as others

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

_web.mov

Mobile Web - Chrome

_mobile_chrome.mp4

Mobile Web - Safari

_mobile_safari.mp4

Desktop

_desktop.mov

iOS

_ios.mp4

Android

_android.mp4

melvin-bot · 2023-05-05T16:45:54Z

@Julesssss @0xmiroslav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

0xmiroslav · 2023-05-08T11:27:06Z

@hellohublot still bounces on mSafari

hellohublot · 2023-05-08T11:39:56Z

@0xmiroslav Yes, I noticed that too, but react-native-web doesn't support the property bounces. https://github.com/necolas/react-native-web/blob/master/packages/react-native-web/src/exports/ScrollView/ScrollViewBase.js

~~From https://stackoverflow.com/questions/7768269/ipad-safari-disable-scrolling-and-bounce-effect so it don't have a perfect solution~~

0xmiroslav · 2023-05-08T11:59:25Z

yes, it seems no non-hacky solution to disable bounce on mSafari.
@Julesssss what do you think? Should we fix iOS only or do nothing?

hellohublot · 2023-05-08T12:11:11Z

@0xmiroslav Thanks, I found a way overflowScrollBehaviorNone to support it, only works on iOS 16+, I have tested on Mac Safari, Android, and Mac Chrome, and it works well.

0xmiroslav · 2023-05-08T12:27:50Z

@hellohublot can you test again all platforms after adding overscroll-behavior: 'none'?

hellohublot · 2023-05-08T12:41:38Z

@0xmiroslav Thanks, I tested again and it work fine, and we're already using it in the body element,

App/web/index.html

Lines 32 to 35 in ab9171f

    
           body { 
        
              overflow: hidden; 
        
              overscroll-behavior: none; 
        
              touch-action: none;

Julesssss

Looking good so far.

0xmiroslav · 2023-05-09T10:18:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

0xmiroslav

Tests well 🎉
@Julesssss all yours

Julesssss

Nice, thanks both!

OSBotify · 2023-05-09T10:29:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-11T02:44:03Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.13-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-05-15T08:25:18Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.13-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aimane-chnaif · 2023-09-06T11:54:18Z

    },

+    overscrollBehaviorNone: {
+        overscrollBehavior: 'none',


Coming from #24197:
This change prevented vertical scrolling as well.
To avoid this, we should have used overscrollBehaviorX property.

Disable iOS code block bounces

c5f3fb0

hellohublot requested a review from a team as a code owner May 5, 2023 16:45

melvin-bot Bot requested review from 0xmiroslav and Julesssss and removed request for a team May 5, 2023 16:45

Add overflow overscrollBehavior support

d57b73c

hellohublot added 2 commits May 8, 2023 20:16

Fix Lint

5015f1f

Rename overflowScrollBehaviorNone to overscrollBehaviorNone

11c2abf

Julesssss assigned hellohublot May 9, 2023

Julesssss reviewed May 9, 2023

View reviewed changes

0xmiroslav approved these changes May 9, 2023

View reviewed changes

Julesssss approved these changes May 9, 2023

View reviewed changes

Julesssss merged commit ae4d11d into Expensify:main May 9, 2023

OSBotify mentioned this pull request May 11, 2023

Deploy Checklist: New Expensify 2023-05-11 #18764

Closed

51 tasks

melvin-bot Bot mentioned this pull request May 15, 2023

[HOLD for payment 2023-05-22] [$1000] IOS - Chat- Block code moves in the conversation. #18111

Closed

6 tasks

bernhardoj mentioned this pull request Aug 7, 2023

[HOLD for payment 2023-09-06] [$1000] Android/MWeb - Inconsistency bug: Android chrome does not allow vertical scroll on multiline horizontal scrollable code block #24197

Closed

6 tasks

aimane-chnaif reviewed Sep 6, 2023

View reviewed changes

Uh oh!

Conversation

hellohublot commented May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 5, 2023

Uh oh!

0xmiroslav commented May 8, 2023

Uh oh!

hellohublot commented May 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xmiroslav commented May 8, 2023

Uh oh!

hellohublot commented May 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xmiroslav commented May 8, 2023

Uh oh!

hellohublot commented May 8, 2023

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

0xmiroslav commented May 9, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

0xmiroslav left a comment

Choose a reason for hiding this comment

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 9, 2023

Uh oh!

OSBotify commented May 11, 2023

Uh oh!

OSBotify commented May 15, 2023

Uh oh!

aimane-chnaif Sep 6, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hellohublot commented May 5, 2023 •

edited

Loading

hellohublot commented May 8, 2023 •

edited

Loading

hellohublot commented May 8, 2023 •

edited

Loading