Skip to content

Improve the many writes error message #18439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iwiznia merged 2 commits into from
May 4, 2023
Merged

Improve the many writes error message #18439

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bd0501
Improve the many writes error message
iwiznia May 4, 2023
bf28e4e
Improve log
iwiznia May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/libs/HttpUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,9 @@ function processHTTPRequest(url, method = 'get', body = null, canCancel = true,
});
}
if (response.jsonCode === CONST.JSON_CODE.MANY_WRITES_ERROR) {
const {phpCommandName, authWriteCommandsCount} = response.data;
const message = `The API call (${phpCommandName}) did ${authWriteCommandsCount - 1} more Auth write requests than allowed. Check the APIWriteCommands class in Web-Expensify`;
const {phpCommandName, authWriteCommands} = response.data;
// eslint-disable-next-line max-len
const message = `The API call (${phpCommandName}) did more Auth write requests than allowed. Count ${authWriteCommands.length}, commands: ${authWriteCommands.join(', ')}. Check the APIWriteCommands class in Web-Expensify`;
alert('Too many auth writes', message);
}
return response;
Expand Down