Deprecate the default rooms beta for #admins and #announce rooms by jasperhuangg · Pull Request #18393 · Expensify/App

jasperhuangg · 2023-05-04T03:18:59Z

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/280874

Tests

Before performing any local tests

Delete || canUseAllBetas(betas) from the condition in canUseDefaultRooms.
Create an account in OldDot. Go to Settings > Domains and create a new domain.
Sign into that same account in NewDot. Create a workspace, or use an existing one. Be sure to have the #announce and #admins rooms ready.
Make sure you're using the Web Proxy

LHN Options

Verify that the #admins room for your workspace appears in the LHN
Verify that the #announce room for your workspace appears in the LHN.
Verify that the #domain.com room does not appear in the LHN
Add back the || canUseAllBetas(betas) to the condition in canUseDefaultRooms.
Verify that the #domain.com room appears in the LHN.

Last viewed report

If you added || canUseAllBetas(betas) to the condition in canUseDefaultRooms, delete it again.

Navigate to the #admins room.
Sign out and back into your account.
Verify you are taken to the #admins room after signing in.
Navigate to the #admins room.
Sign out and back into your account.
Verify you are taken to the #announce room after signing in.

Offline tests

N/A

QA Steps

ping @jasperhuangg to QA

LHN Options

1 Verify that the #admins room for your workspace appears in the LHN
2. Verify that the #announce room for your workspace appears in the LHN.
3. Verify that the #domain.com room does not appear in the LHN

Last viewed report

Navigate to the #admins room.
Sign out and back into your account.
Verify you are taken to the #admins room after signing in.
Navigate to the #admins room.
Sign out and back into your account.
Verify you are taken to the #announce room after signing in.

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-05-04.at.12.37.37.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-05-04.at.12.48.16.PM.mov

Mobile Web - Safari

Screen.Recording.2023-05-04.at.12.52.10.PM.mov

Desktop

iOS

Android

jasperhuangg · 2023-05-04T04:27:08Z

Asked about test domains here (see QA steps for context)

jasperhuangg · 2023-05-04T04:27:33Z

    return getOptions([], personalDetails, {
        betas,
        searchInputValue: searchValue.trim(),
-        excludeDefaultRooms: true,


Just removed this because I found that this param wasn't being used anywhere in getOptions

jasperhuangg · 2023-05-04T18:01:50Z

Adding CP Staging label as there's some urgency around this

github-actions · 2023-05-04T18:01:58Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

…DefaultRoomsBetaExceptForDomainRooms

yuwenmemon

LGTM! But why CP to staging? Can this not just follow the normal deploy process?

jasperhuangg · 2023-05-04T18:55:05Z

@yuwenmemon Yeah it can, just thought there was some urgency around this. If you don't agree feel free to remove the label.

MelvinBot · 2023-05-04T18:55:48Z

@0xmiroslav @PauloGasparSv One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

yuwenmemon · 2023-05-04T19:05:19Z

@jasperhuangg yeah better to err on the side of caution IMO. If someone wants it right now we can always CP it later too.

0xmiroslav · 2023-05-04T19:05:23Z

@jasperhuangg how can I Generate a domain? Is this necessary for me testing?

jasperhuangg · 2023-05-04T19:10:01Z

Ah @0xmiroslav you need to be an internal employee to do that on your dev environment. You can just test the changes to admins and announce rooms for now. Ignore anything that has anything to do with domain rooms.

PauloGasparSv · 2023-05-04T21:03:47Z

Hey @jasperhuangg I think the steps under "Last viewed report" repeat, is that's intentional?

jasperhuangg · 2023-05-04T21:53:50Z

Hey @jasperhuangg I think the steps under "Last viewed report" repeat, is that's intentional?

@PauloGasparSv fixed them, was a typo, thanks for pointing that out!

jasperhuangg · 2023-05-04T23:24:12Z

@0xmiroslav will you be able to compete your review today?

0xmiroslav · 2023-05-05T02:57:18Z

-    // Include any public announce rooms, since they could include people who should have access but we don't know to add to the beta
-    if (report.visibility === CONST.REPORT.VISIBILITY.PUBLIC_ANNOUNCE) {
+    // Include any admins and announce rooms, since only non partner-managed domain rooms are on the beta now.
+    if (isAdminRoom(report) || isAnnounceRoom(report)) {


All #admins, #announce rooms are free policy so not able to reach this condition as early returned here:

App/src/libs/ReportUtils.js

Lines 1495 to 1497 in 5f649d5

if (getPolicyType(report, policies) === CONST.POLICY.TYPE.FREE) {

return true;

}

I had to remove this manually to test this PR properly.

0xmiroslav · 2023-05-05T02:57:37Z

        // Check where ReportUtils.findLastAccessedReport is called in MainDrawerNavigator.js for more context.
-        sortedReports = _.filter(sortedReports, report => !isDefaultRoom(report) || isPublicAnnounceRoom(report)
+        // Domain rooms are now the only type of default room that are on the defaultRooms beta.
+        sortedReports = _.filter(sortedReports, report => !isDomainRoom(report)
            || getPolicyType(report, policies) === CONST.POLICY.TYPE.FREE


0xmiroslav · 2023-05-05T03:21:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

0xmiroslav

LGTM 🎉
#admins and #announce rooms work well. not able to test domain rooms.

melvin-bot · 2023-05-05T03:23:43Z

🎯 @0xmiroslav, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #18463.

OSBotify · 2023-05-05T03:56:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-05T20:02:26Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.3.11-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-05-09T04:05:01Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Deprecate the default rooms beta for admins and announce rooms

75d8eff

jasperhuangg self-assigned this May 4, 2023

jasperhuangg changed the title ~~Deprecate the default rooms beta for admins and announce rooms~~ Deprecate the default rooms beta for #admins and #announce rooms May 4, 2023

jasperhuangg requested a review from yuwenmemon May 4, 2023 03:37

fix tests

36f7106

jasperhuangg commented May 4, 2023

View reviewed changes

jasperhuangg added the CP Staging label May 4, 2023

jasperhuangg added InternalQA This pull request required internal QA and removed InternalQA This pull request required internal QA labels May 4, 2023

Merge branch 'main' of github.com:Expensify/App into jasper-deprecate…

cd1c664

…DefaultRoomsBetaExceptForDomainRooms

yuwenmemon approved these changes May 4, 2023

View reviewed changes

jasperhuangg marked this pull request as ready for review May 4, 2023 18:55

jasperhuangg requested a review from a team as a code owner May 4, 2023 18:55

melvin-bot Bot requested review from 0xmiroslav and PauloGasparSv and removed request for a team May 4, 2023 18:55

yuwenmemon added InternalQA This pull request required internal QA and removed CP Staging labels May 4, 2023

jasperhuangg removed the InternalQA This pull request required internal QA label May 4, 2023

0xmiroslav reviewed May 5, 2023

View reviewed changes

0xmiroslav approved these changes May 5, 2023

View reviewed changes

melvin-bot Bot mentioned this pull request May 5, 2023

[HOLD for payment 5/16] Payment issue for E/App PR#18393 #18463

Closed

jasperhuangg merged commit bdb2369 into main May 5, 2023

jasperhuangg deleted the jasper-deprecateDefaultRoomsBetaExceptForDomainRooms branch May 5, 2023 03:51

OSBotify mentioned this pull request May 5, 2023

Deploy Checklist: New Expensify 2023-05-05 #18498

Closed

31 tasks

	if (getPolicyType(report, policies) === CONST.POLICY.TYPE.FREE) {
	return true;
	}

Uh oh!

Conversation

jasperhuangg commented May 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Before performing any local tests

LHN Options

Last viewed report

Offline tests

QA Steps

LHN Options

Last viewed report

PR Author Checklist

Screenshots/Videos

Uh oh!

jasperhuangg commented May 4, 2023

Uh oh!

jasperhuangg May 4, 2023

Choose a reason for hiding this comment

Uh oh!

jasperhuangg commented May 4, 2023

Uh oh!

github-actions Bot commented May 4, 2023

Uh oh!

yuwenmemon left a comment

Choose a reason for hiding this comment

Uh oh!

jasperhuangg commented May 4, 2023

Uh oh!

MelvinBot commented May 4, 2023

Uh oh!

yuwenmemon commented May 4, 2023

Uh oh!

0xmiroslav commented May 4, 2023

Uh oh!

jasperhuangg commented May 4, 2023

Uh oh!

PauloGasparSv commented May 4, 2023

Uh oh!

jasperhuangg commented May 4, 2023

Uh oh!

jasperhuangg commented May 4, 2023

Uh oh!

0xmiroslav May 5, 2023

Choose a reason for hiding this comment

Uh oh!

0xmiroslav May 5, 2023

Choose a reason for hiding this comment

Uh oh!

0xmiroslav commented May 5, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

0xmiroslav left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 5, 2023

Uh oh!

OSBotify commented May 5, 2023

Uh oh!

OSBotify commented May 5, 2023

Uh oh!

OSBotify commented May 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jasperhuangg commented May 4, 2023 •

edited

Loading