Skip to content

refresh data on personal details page when online #17944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deetergp merged 1 commit into from
Apr 25, 2023
Merged

refresh data on personal details page when online #17944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/pages/settings/Profile/PersonalDetails/PersonalDetailsInitialPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import React, {useEffect} from 'react';
import PropTypes from 'prop-types';
import {ScrollView, View} from 'react-native';
import {withOnyx} from 'react-native-onyx';
Expand All @@ -13,6 +13,7 @@ import compose from '../../../../libs/compose';
import MenuItemWithTopDescription from '../../../../components/MenuItemWithTopDescription';
import * as PersonalDetails from '../../../../libs/actions/PersonalDetails';
import ONYXKEYS from '../../../../ONYXKEYS';
import {withNetwork} from '../../../../components/OnyxProvider';

const propTypes = {
/* Onyx Props */
Expand Down Expand Up @@ -53,7 +54,12 @@ const defaultProps = {
};

const PersonalDetailsInitialPage = (props) => {
PersonalDetails.openPersonalDetailsPage();
useEffect(() => {
if (props.network.isOffline) {
return;
}
PersonalDetails.openPersonalDetailsPage();
}, [props.network.isOffline]);

const privateDetails = props.privatePersonalDetails || {};
const address = privateDetails.address || {};
Expand Down Expand Up @@ -135,4 +141,5 @@ export default compose(
key: ONYXKEYS.PRIVATE_PERSONAL_DETAILS,
},
}),
withNetwork(),
)(PersonalDetailsInitialPage);