Migrate AddPayPalMe to function component

[NikkiWines]

cc: @marcaaron

Details

Converts the existing AddPayPalMe component to a function component w/ hooks.

Fixed Issues

$ #16285
PROPOSAL: N/A

Tests

1. Log into an account on New Expensify
2. Navigate to Settings > Payments > Add Payment Method > PayPal.me
3. Confimr you cannot submit the form without entering a value
4. Enter a value but exit the form before submitting
5. Navigate back to the form and confirm the value is not saved
6. Enter a value and press Add PayPal account
7. Confirm you are redirected back to the Payments method page and a success pop-up displays confirming your PayPal account has been added.

• Verify that no errors appear in the JS console

Offline tests

QA Steps

1. Log into an account on New Expensify
2. Navigate to Settings > Payments > Add Payment Method > PayPal.me
3. Confimr you cannot submit the form without entering a value
4. Enter a value but exit the form before submitting
5. Navigate back to the form and confirm the value is not saved
6. Enter a value and press Add PayPal account
7. Confirm you are redirected back to the Payments method page and a success pop-up displays confirming your PayPal account has been added.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

paypalme-web.mov

Mobile Web - Chrome

paypalme-chrome-mweb.mov

Mobile Web - Safari

paypalme-safari-mweb.mp4

Desktop

paypalme-desktop.mov

iOS

Simulator.Screen.Recording.-.iPhone.14.-.2023-04-14.at.18.25.16.mp4

Android

[MelvinBot]

@fedirjh @Gonals One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[NikkiWines]

Been fighting with my Android emulator so I don't have an Android app screen recording yet - will hopefully have one on Monday but this is otherwise good to go!

[fedirjh]

Code LGTM , left a few comment.

[MelvinBot]

@sobitneupane @jasperhuangg One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[Gonals]

Rerunning pullerBear, as I'm leaving on parental leave!

[NikkiWines]

Thanks for the review @fedirjh, updated with your suggestions

[marcaaron]

I can take over for @jasperhuangg here - looks like he's OOO until tomorrow

[marcaaron]

Nice job here. LGTM just had a couple of small style notes.

[NikkiWines]

Thanks @marcaaron, updated with the changes!

[marcaaron]

NAB, this kind of made me wonder about whether translations should be memoized. I feel like they aren't now (though we will re-render any components that use withLocalize() if the language changes) but maybe it would be better to have a useTranslate('addPayPalMePage.growlMessageOnSave') that just return the same result unless the language changes. Anyways, not something we should do, but seems like a good use case for hooks.

[NikkiWines]

Yeah, I was thinking about that when making this change - memoizing translations sounds like a good idea but maybe something to tackle in a larger separate issue?

[marcaaron]

1000% 👍

[fedirjh]

LGTM and tests well , However, there is a minor bug: on native, the text input isn't automatically focused when the component is mounted. I believe this is related to the ref not being properly forwarded on TextInput/index.native.js

Native	Web
native.mov	Screen.Recording.2023-04-18.at.1.16.52.AM.mov

[fedirjh]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-04-17.at.8.47.28.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-04-18.at.1.17.45.AM.mov

Mobile Web - Safari

Screen.Recording.2023-04-17.at.9.38.07.PM.mov

Desktop

Screen.Recording.2023-04-17.at.10.00.00.PM.mov

iOS

Screen.Recording.2023-04-18.at.1.06.11.AM.mov

Screen.Recording.2023-04-18.at.2.22.04.AM.mov

Android

Screen.Recording.2023-04-18.at.1.24.55.AM.mov

Screen.Recording.2023-04-18.at.2.18.10.AM.mov

[NikkiWines]

However, there is a minor bug: on native, the text input isn't automatically focused when the component is mounted. I believe this is related to the ref not being properly forwarded on TextInput/index.native.js

Nice catch @fedirjh, I'll check to see if this issue existed before this migration and if so we can make a new bug report for it. If not, I'll look into it further 👍

[marcaaron]

Can we maybe do something like

App/src/components/TextInput/BaseTextInput.js

Lines 279 to 280 in 0276f42

	ref={(ref) => {
	if (typeof this.props.innerRef === 'function') { this.props.innerRef(ref); }

    if (typeof this.props.innerRef === 'function') { 
        this.props.innerRef(ref);
    } else if (this.props.innerRef && this.props.innerRef.hasOwnProperty('current')) {
        this.props.innerRef.current = ref;
    }

?

[fedirjh]

@marcaaron That should work perfectly 👌

Edit : Tests well on both android and IOS.

[NikkiWines]

Updated! Sorry for the delay

[fedirjh]

LGTM and tests well 🚀

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.3-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.3-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅