-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Fix: Inconsistent capitalization in product #17327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thienlnam
merged 9 commits into
Expensify:main
from
dukenv0307:fix/17239-inconsistent-capitalization-in-product
Apr 21, 2023
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
67bea0e
fix: inconsistent capitalization in product
dukenv0307 bf78b79
fix more inconsistent capitalization in product
dukenv0307 056540c
fix inconsistent capitalization of acceptTerms text in Spanish language
dukenv0307 a007c2c
resolve conflict
dukenv0307 43b6d83
fix inconsistent capitalization in error of add bank account form
dukenv0307 59ec56a
Merge branch 'main' into fix/17239-inconsistent-capitalization-in-pro…
dukenv0307 e99b3f5
fix: merge main
dukenv0307 c1369d9
fix inconsistent capitalization in incorporationTypes
dukenv0307 1534e19
Merge branch 'fix/17239-inconsistent-capitalization-in-product' of ht…
dukenv0307 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thienlnam should we localize this for Spanish? I think this place is fine for now because we'll be deprecating uploading message.
https://expensify.slack.com/archives/C01GTK53T8Q/p1664819628960309
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, yeah I'm not sure why this copy was not ever localized. Agree we can just leave it since we're going to be removing it soon