Revert "Open a test tools modal with 5 taps on dev"

[neil-marcellini]

Details

Reverts #13900

Fixed Issues

$ #15414

Tests

1. Go to settings

2. Verify that you can select the user's email

3. Go to any chat

4. triple click the last message

5. Copy text with command + c

6. Paste into the composer

7. Verify that only the selected text from the last message is pasted

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

I only tested on one platform since this is a revert PR.

Web

Screen.Recording.2023-02-23.at.9.39.25.AM.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[MelvinBot]

@puneetlath @eVoloshchak One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[neil-marcellini]

Since this is a revert we don't need a C+ reviewer.

[puneetlath]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries

Name	Duration
App start TTI	678.565 ms → 696.338 ms (+17.773 ms, +2.6%)
App start runJsBundle	180.323 ms → 183.097 ms (+2.774 ms, +1.5%)
App start regularAppStart	0.013 ms → 0.013 ms (+0.000 ms, ±0.0%)
App start nativeLaunch	21.323 ms → 20.800 ms (-0.523 ms, -2.5%)
Open Search Page TTI	632.767 ms → 621.393 ms (-11.374 ms, -1.8%)

Show details

Name	Duration
App start TTI	Baseline Mean: 678.565 ms Stdev: 27.747 ms (4.1%) Runs: 620.4744049999863 635.9687999999151 638.8708669999614 640.6388570000418 644.2704420001246 654.6478880001232 654.7335490002297 658.1968430001289 661.3015029998496 661.6568979998119 662.5533770001493 670.2717699999921 670.3775559999049 671.1453399998136 674.0699599999934 675.1336159999482 675.8757969997823 676.53525000019 681.3872110000812 687.6268989997916 687.6442979997955 692.3746389998123 694.0094710001722 699.2757089999504 700.2720010001212 704.1253519998863 713.8618999999017 717.5301879998296 718.9328800002113 719.6521479999647 722.3646590001881 728.2974399998784 Current Mean: 696.338 ms Stdev: 33.936 ms (4.9%) Runs: 644.8505060002208 645.5395809998736 648.9972290000878 651.3761539999396 658.0010910001583 662.4531870000064 668.654841999989 668.7769280001521 675.2768080001697 678.8626370001584 679.4220580002293 679.6614819997922 681.2173660001718 686.1960020000115 686.414474000223 687.1620939997956 688.9837340000086 692.6957959998399 696.5685609998181 710.0149770001881 712.2148000001907 715.3001199997962 715.6302220001817 715.6392769999802 716.7508140001446 721.7494569998235 727.4875570000149 734.1126219998114 735.6456889999099 753.3968110000715 764.7057810002007 779.0586219998077
App start runJsBundle	Baseline Mean: 180.323 ms Stdev: 15.751 ms (8.7%) Runs: 153 154 157 159 161 165 166 169 172 173 174 176 178 179 179 180 181 182 182 183 185 186 186 190 193 194 198 206 206 210 213 Current Mean: 183.097 ms Stdev: 16.668 ms (9.1%) Runs: 160 162 163 166 166 166 168 168 168 175 175 176 177 180 181 182 182 183 184 184 188 188 188 188 188 196 207 213 214 219 221
App start regularAppStart	Baseline Mean: 0.013 ms Stdev: 0.001 ms (4.0%) Runs: 0.012003000359982252 0.012044999748468399 0.012165999971330166 0.012206999585032463 0.012329000048339367 0.012368999887257814 0.012370000127702951 0.012655000202357769 0.012735999654978514 0.012735999654978514 0.012777000200003386 0.012858000118285418 0.012858000118285418 0.012899000197649002 0.012899000197649002 0.0129399998113513 0.012940000277012587 0.012980000115931034 0.013020999729633331 0.013021000195294619 0.013021000195294619 0.013183999806642532 0.01318400027230382 0.013224000111222267 0.013346000108867884 0.013346999883651733 0.013346999883651733 0.0138349998742342 0.0138349998742342 0.013875000178813934 0.0139979999512434 Current Mean: 0.013 ms Stdev: 0.001 ms (5.2%) Runs: 0.011799999978393316 0.011882000137120485 0.011921999976038933 0.012165999971330166 0.012248000130057335 0.012369999662041664 0.012369999662041664 0.012451000045984983 0.012492000125348568 0.012492000125348568 0.0125730000436306 0.0125730000436306 0.012614000122994184 0.012614000122994184 0.012775999959558249 0.01293900003656745 0.012980000115931034 0.013021000195294619 0.013062000274658203 0.013062000274658203 0.013183000031858683 0.013265000190585852 0.013346000108867884 0.013387999963015318 0.013428000267595053 0.013712999876588583 0.01371300034224987 0.013793999794870615 0.01383400009945035 0.013956999871879816 0.014241000171750784 0.01436399994418025
App start nativeLaunch	Baseline Mean: 21.323 ms Stdev: 2.085 ms (9.8%) Runs: 18 19 19 19 19 20 20 20 20 20 20 20 20 20 21 21 21 21 21 22 22 22 22 23 23 23 23 25 25 25 27 Current Mean: 20.800 ms Stdev: 1.869 ms (9.0%) Runs: 18 18 18 18 19 19 19 19 20 20 20 20 21 21 21 21 21 21 21 21 21 22 22 22 22 23 23 23 24 26
Open Search Page TTI	Baseline Mean: 632.767 ms Stdev: 25.284 ms (4.0%) Runs: 589.8105069999583 594.3105470002629 601.0111899999902 602.1549479998648 603.7779950001277 604.8863530000672 607.5080160000362 612.150675999932 613.5578619996086 615.9491790002212 617.2202150002122 619.4912109998986 627.4798589996062 627.6400969997048 628.0809740000404 629.0712890001014 631.4233809998259 631.9685069997795 634.4193929997273 635.9169120001607 639.6021320000291 640.7980959997512 644.6028650002554 645.2034920002334 648.1387120001018 648.4263100000098 650.612385999877 659.3138020001352 660.912800999824 662.4668379998766 675.2409669999033 678.1212559998967 700.0327150002122 Current Mean: 621.393 ms Stdev: 23.789 ms (3.8%) Runs: 575.1040039998479 581.1335450001061 582.6097420002334 586.2213950003497 594.1739509999752 602.3422039998695 603.4812420001253 609.8391929999925 612.978353000246 613.3297940003686 614.5245779999532 616.3071290003136 617.6397710000165 617.9458420001902 619.9945880002342 621.861938000191 624.9074709997512 626.0186769999564 626.2312429999001 628.4533700002357 630.1606040000916 631.812336999923 633.6770829996094 636.4186609997414 640.0211600000039 640.3298349999823 655.5893549998291 658.5611569997855 667.2530120001175 672.8672690000385

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/chiragsalian in version: 1.2.76-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

[OSBotify]

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅