fix wrong height calculation in android modal with statusBarTranslucent#14704
Merged
arosiclair merged 2 commits intoFeb 2, 2023
Merged
Conversation
melvin-bot
Bot
requested review from
arosiclair and
mollfpr
and removed request for
a team
|
@arosiclair @mollfpr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
arosiclair
reviewed
Feb 1, 2023
| coverScreen={this.props.fullscreen} | ||
| style={modalStyle} | ||
| deviceHeight={this.props.windowHeight} | ||
| deviceHeight={this.props.windowHeight + ((this.props.statusBarTranslucent && StatusBar.currentHeight) || 0)} |
Contributor
There was a problem hiding this comment.
Can you just add a small comment on how this fixes android?
Contributor
Author
There was a problem hiding this comment.
// When `statusBarTranslucent` is true on Android, the modal fully covers the status bar.
// Since `windowHeight` doesn't include status bar height, it should be added in the `deviceHeight` calculation.
How about this?
Contributor
There was a problem hiding this comment.
Added some small edits to your snippet. Should be good now 👍
arosiclair
approved these changes
Feb 1, 2023
arosiclair
left a comment
arosiclair
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Checklist is all yours @mollfpr
Contributor
|
@arosiclair Thanks for taking the review quickly! Yup, I'm on it the checklist now! |
Contributor
Reviewer Checklist
Screenshots/VideosWeb14704.Web.movMobile Web - Chrome14704.mWeb.Chrome.MP4Mobile Web - Safari14704.mWeb.Safari.mp4Desktop14704.Desktop.moviOS14704.iOS.mp4Android14704.Android.MP4 |
mollfpr
approved these changes
Feb 1, 2023
mollfpr
left a comment
mollfpr
left a comment
Contributor
There was a problem hiding this comment.
Ready to merge @arosiclair
Contributor
Performance Comparison Report 📊Significant Changes To DurationThere are no entries Meaningless Changes To DurationShow entries
Show details
|
Contributor
|
🚀 Deployed to staging by https://github.com/arosiclair in version: 1.2.64-2 🚀
|
30 tasks
1 task
Contributor
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.64-7 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.64-7 🚀
|
1 similar comment
Contributor
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.64-7 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Include status bar height in
deviceHeightcalculation whenstatusBarTranslucentprop set totrueinModalFixed Issues
$ #14563
PROPOSAL: #14563 (comment)
Tests
Offline tests
Cannot test in offline mode because "Add Payment method" is disabled
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.Screenshots/Videos
Web
web.mov
Mobile Web - Chrome
mchrome.mp4
Mobile Web - Safari
msafari.mp4
Desktop
desktop.mov
iOS
ios.mp4
Android
android.mp4