Afonseca fix caps android room name

[sketchydroide]

Details

The room name i supposed to be lower case only, but if you make it all caps on Android it starts copying the already inserted text and duplicating.

Fixed Issues

$ #13463

Tests

This only needs to be tested on iOS and Android

1. Login to an account that can create rooms
2. Press the Green + button and selecte New Room
3. On the name field double tap on the shift ⬆️ so the all caps is enabled
4. Tap in diferent keys on the actual device keyboard (if you are running on an emulator it can't be the computer keyboard)
5. Verify that nothing weird happens

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

• Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • iOS / native
  • Android / native
  • iOS / Safari
  • Android / Chrome
  • MacOS / Chrome
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[melvin-bot]

@thesahindia @aldo-expensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[thesahindia]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • iOS / native
  • Android / native
  • iOS / Safari
  • Android / Chrome
  • MacOS / Chrome
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2022-12-15.at.10.39.49.PM.mov

Mobile Web - Chrome

Screen.Recording.2022-12-15.at.11.04.39.PM.mov

Mobile Web - Safari

Screen.Recording.2022-12-15.at.10.35.26.PM.mov

Desktop

Screen.Recording.2022-12-15.at.10.33.24.PM.mov

iOS

Screen.Recording.2022-12-15.at.10.34.19.PM.mov

Android

Screen.Recording.2022-12-15.at.10.22.53.PM.mov

[thesahindia]

Just a reminder that screenshots are pending. (I have attached them in the comment above you can just download and add them)
Other than that it looks good to me!

C+ reviewed 🎀👀🎀

[aldo-expensify]

@sketchydroide 👋 you are missing the screenshots (or videos) for Android and IOS

[aldo-expensify]

The workaround tested well for me. I didn't find a better way of doing this.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries

Name	Duration
TTI	792.834 ms → 812.465 ms (+19.631 ms, +2.5%)
runJsBundle	185.313 ms → 189.719 ms (+4.406 ms, +2.4%)
regularAppStart	0.014 ms → 0.015 ms (+0.001 ms, +5.5%)
nativeLaunch	9.750 ms → 9.724 ms (-0.026 ms, ±0.0%)

Show details

Name	Duration
TTI	Baseline Mean: 792.834 ms Stdev: 36.499 ms (4.6%) Runs: 727.4493450000882 743.0890239998698 744.4675839999691 749.501523999963 753.94174200017 757.5896220002323 759.4112470000982 761.3298320001923 769.0638259998523 770.871468000114 771.5891240001656 771.9625920001417 780.3407040000893 781.8830719999969 782.3206230001524 791.1615100000054 795.6564009999856 799.2260509999469 801.1275470000692 803.1520139998756 813.2087969998829 814.7734460001811 816.2659120000899 818.239207000006 827.0374819999561 827.6063020001166 828.337096999865 835.4617229998112 843.047914000228 845.520756999962 893.2071940000169 Current Mean: 812.465 ms Stdev: 39.607 ms (4.9%) Runs: 746.4240770000033 766.849624000024 771.517525000032 775.4223719998263 777.013580000028 780.600047999993 784.3967369999737 787.1544769997708 787.3171219998039 789.3781050001271 791.7236950001679 792.0700130001642 793.6210469999351 796.0537899998017 799.1507210000418 801.6492469999939 804.3117490001023 805.6976919998415 806.9610660001636 815.5443139998242 817.3434759997763 821.495002000127 826.3148190001957 829.3279729997739 838.2395839998499 848.1526440000162 848.7979060001671 884.877092000097 887.4282610001974 894.9511099997908 916.6246360000223
runJsBundle	Baseline Mean: 185.313 ms Stdev: 16.836 ms (9.1%) Runs: 154 161 162 168 169 170 171 171 172 175 175 175 179 180 180 181 181 184 186 186 188 190 198 201 203 205 207 208 209 211 213 217 Current Mean: 189.719 ms Stdev: 17.871 ms (9.4%) Runs: 160 167 168 168 172 173 174 174 176 180 181 181 182 182 183 187 188 189 190 191 191 196 198 198 199 206 208 216 220 220 220 233
regularAppStart	Baseline Mean: 0.014 ms Stdev: 0.001 ms (5.4%) Runs: 0.012247999664396048 0.012614000122994184 0.012653999961912632 0.012775999959558249 0.013184000039473176 0.013224999886006117 0.0133050000295043 0.013386999722570181 0.013427999801933765 0.013469000346958637 0.013469000346958637 0.013509000185877085 0.013549000024795532 0.013630999717861414 0.013631000183522701 0.013712999876588583 0.013753999955952168 0.013753999955952168 0.01383400009945035 0.014077999629080296 0.014119999948889017 0.014160000020638108 0.014160000253468752 0.014200999867171049 0.014281999785453081 0.014323000330477953 0.014851999934762716 0.01509599993005395 0.015177999623119831 0.015461999922990799 Current Mean: 0.015 ms Stdev: 0.001 ms (6.1%) Runs: 0.01293900003656745 0.013019999954849482 0.013264999724924564 0.013508999720215797 0.013711999636143446 0.013793999794870615 0.013794000260531902 0.0138349998742342 0.013835000339895487 0.013875000178813934 0.01411899970844388 0.014119999948889017 0.014200999867171049 0.014241999946534634 0.014241999946534634 0.01436399994418025 0.014485999941825867 0.014525999780744314 0.014525999780744314 0.014567000325769186 0.014649000018835068 0.014812000095844269 0.014973999932408333 0.01525900000706315 0.015381000004708767 0.015461999922990799 0.015583999920636415 0.015665000304579735 0.015705999918282032 0.015951000154018402 0.01599099999293685 0.016358000226318836
nativeLaunch	Baseline Mean: 9.750 ms Stdev: 1.581 ms (16.2%) Runs: 8 8 8 8 8 8 8 8 9 9 9 9 9 9 9 9 9 10 10 10 10 10 10 11 11 11 11 12 12 12 13 14 Current Mean: 9.724 ms Stdev: 1.412 ms (14.5%) Runs: 7 8 8 8 8 9 9 9 9 9 9 9 9 10 10 10 10 10 10 10 10 10 10 11 11 11 12 12 14

[OSBotify]

🚀 Deployed to staging by @aldo-expensify in version: 1.2.41-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by @aldo-expensify in version: 1.2.41-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @yuwenmemon in version: 1.2.41-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅