Skip to content

fix "Upload photo" popup menu not hiding #13448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcaaron merged 2 commits into from
Dec 9, 2022
Merged

fix "Upload photo" popup menu not hiding #13448

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b059f08
fix "Upload photo" popup menu not hiding
Dec 8, 2022
fee05c8
update comment for stopPropagation in file input
Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/components/AttachmentPicker/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ class AttachmentPicker extends React.Component {
// Cleanup after selecting a file to start from a fresh state
this.fileInput.value = null;
}}

// We are stopping the event propagation because triggering the `click()` on the hidden input
// causes the event to unexpectedly bubble up to anything wrapping this component e.g. Pressable
onClick={e => e.stopPropagation()}
accept={getAcceptableFileTypes(this.props.type)}
/>
{this.props.children({
Expand Down