Skip to content

Fix janky Android splash screen #12642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 11 commits into from
Nov 28, 2022
Merged

Fix janky Android splash screen #12642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cfb429e
fix janky Android splash screen
Julesssss Nov 10, 2022
61f8aa3
Merge branch 'main' into jules-fixAndroidSplashIcon
Julesssss Nov 18, 2022
2eafe92
revert the sidebar to the same theme as every other page
Julesssss Nov 18, 2022
c43eb99
remove the sidebar background colour change
Julesssss Nov 24, 2022
4bd04a5
Merge branch 'main' into jules-fixAndroidSplashIcon
Julesssss Nov 24, 2022
bc139dc
remove hardcoded status bar colour
Julesssss Nov 24, 2022
7a4b244
use theme colour for status bar, to prepare for dark theme
Julesssss Nov 24, 2022
b4d8a6a
hardcode white status until we merge dark theme
Julesssss Nov 24, 2022
8d7068c
Merge branch 'main' into jules-fixAndroidSplashIcon
Julesssss Nov 28, 2022
f5e8d12
hardcode the android status bar
Julesssss Nov 28, 2022
f87c948
fix invalid RN import order
Julesssss Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions android/app/src/main/res/values/styles.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,16 @@
<style name="BaseAppTheme" parent="Theme.AppCompat.Light.NoActionBar">
<item name="android:textColor">@color/dark</item>
<item name="android:colorEdgeEffect">@color/gray4</item>
<item name="android:statusBarColor">#061B09</item>
<item name="colorAccent">@color/accent</item>
<item name="android:statusBarColor">@color/white</item>
<item name="android:windowLightStatusBar" tools:ignore="NewApi">true</item>
<item name="android:editTextBackground">@drawable/rn_edit_text_material</item>
</style>

<!-- Themes unique to the boot splash page -->
<style name="BootTheme" parent="AppTheme">
<item name="android:background">@drawable/bootsplash</item>
<item name="android:windowTranslucentStatus">false</item>
<item name="android:fitsSystemWindows">true</item>
</style>

</resources>
4 changes: 2 additions & 2 deletions src/components/CustomStatusBar/index.android.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React from 'react';
import {StatusBar} from 'react-native';
import themeColors from '../../styles/themes/default';

/**
* Only the Android platform supports "setBackgroundColor"
Expand All @@ -8,8 +9,7 @@ import {StatusBar} from 'react-native';
export default class CustomStatusBar extends React.Component {
componentDidMount() {
StatusBar.setBarStyle('light-content');
StatusBar.setBackgroundColor('transparent');
StatusBar.setTranslucent(true);
StatusBar.setBackgroundColor(themeColors.appBG);
}

render() {
Expand Down