Skip to content

Add a rotating slate of placeholder text for Concierge chat #10899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
puneetlath merged 11 commits into from
Sep 26, 2022
Merged

Add a rotating slate of placeholder text for Concierge chat #10899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
181f737
Add various placeholder text options for Concierge chat in english
puneetlath Sep 8, 2022
3e0b66b
move inputPlaceholder to state and shuffle the options if concierge chat
puneetlath Sep 8, 2022
ee40111
add spanish translation for concierge placeholder messages
puneetlath Sep 8, 2022
8acbf7b
update spanish translation for corporate card
puneetlath Sep 9, 2022
cb05425
update input placeholder for 0 or 1 report actions
puneetlath Sep 9, 2022
2c7e343
add comment explaining random placeholder selection
puneetlath Sep 9, 2022
a0892f4
Move inputPlaceholder calculation back to render method
puneetlath Sep 18, 2022
2a560c6
choose the random Concierge placeholder on mount and set in state
puneetlath Sep 18, 2022
0e070d4
do placeholder index in state instead of placeholder text
puneetlath Sep 18, 2022
1cbf42d
use underscore random instead of Math.random
puneetlath Sep 18, 2022
5f8e69d
Merge branch 'main' into concierge-write-something
puneetlath Sep 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/languages/en.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,16 @@ export default {
addAttachment: 'Add attachment',
writeSomething: 'Write something...',
sayHello: 'Say hello!',
conciergePlaceholderOptions: [
'Ask for help!',
'Ask me anything!',
'Ask me to book travel!',
'Ask me what I can do!',
'Ask me how to pay people!',
'Ask me how to send an invoice!',
'Ask me how to scan a receipt!',
'Ask me how to get a free corporate card!',
],
blockedFromConcierge: 'Communication is barred',
fileUploadFailed: 'Upload failed. File is not supported.',
localTime: ({user, time}) => `It's ${time} for ${user}`,
Expand Down
10 changes: 10 additions & 0 deletions src/languages/es.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,16 @@ export default {
addAttachment: 'Agregar archivo adjunto',
writeSomething: 'Escribe algo...',
sayHello: 'Di hola!',
conciergePlaceholderOptions: [
'¡Pide ayuda!',
'¡Pregúntame lo que sea!',
'¡Pídeme que te reserve un viaje!',
'¡Pregúntame qué puedo hacer!',
'¡Pregúntame cómo pagar a la gente!',
'¡Pregúntame cómo enviar una factura!',
'¡Pregúntame cómo escanear un recibo!',
'¡Pregúntame cómo obtener una tarjeta de crédito corporativa gratis!',
],
blockedFromConcierge: 'Comunicación no permitida',
fileUploadFailed: 'Subida fallida. El archivo no es compatible.',
localTime: ({user, time}) => `Son las ${time} para ${user}`,
Expand Down
9 changes: 7 additions & 2 deletions src/pages/home/report/ReportActionCompose.js
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ class ReportActionCompose extends React.Component {
},
maxLines: props.isSmallScreenWidth ? CONST.COMPOSER.MAX_LINES_SMALL_SCREEN : CONST.COMPOSER.MAX_LINES,
value: props.comment,
conciergePlaceholderRandomIndex: _.random(this.props.translate('reportActionCompose.conciergePlaceholderOptions').length - 1),
};
}

Expand Down Expand Up @@ -244,8 +245,12 @@ class ReportActionCompose extends React.Component {
* @return {String}
*/
getInputPlaceholder() {
if (ReportUtils.chatIncludesConcierge(this.props.report) && User.isBlockedFromConcierge(this.props.blockedFromConcierge)) {
return this.props.translate('reportActionCompose.blockedFromConcierge');
if (ReportUtils.chatIncludesConcierge(this.props.report)) {
if (User.isBlockedFromConcierge(this.props.blockedFromConcierge)) {
return this.props.translate('reportActionCompose.blockedFromConcierge');
}

return this.props.translate('reportActionCompose.conciergePlaceholderOptions')[this.state.conciergePlaceholderRandomIndex];
}

if (_.size(this.props.reportActions) === 1) {
Expand Down