Skip to content

Fix overflow issue on login screen#10425

Merged
techievivek merged 1 commit into
mainfrom
yuwen-alwaysNarrow
Aug 17, 2022
Merged

Fix overflow issue on login screen#10425
techievivek merged 1 commit into
mainfrom
yuwen-alwaysNarrow

Conversation

@yuwenmemon

@yuwenmemon yuwenmemon commented Aug 17, 2022

Copy link
Copy Markdown
Contributor

@techievivek Please review
cc @aimane-chnaif

Details

I don't believe we need this conditional here as the SignIn page content will always be narrow.

Fixed Issues

$ #10419

Tests

  1. Go to the sign in page of new Expensify
  2. Enter your login details but not your password (use long login name)
  3. Press Forgot? on the password page

Screen Shot 2022-08-17 at 12 16 41 PM

@yuwenmemon yuwenmemon self-assigned this Aug 17, 2022
@yuwenmemon yuwenmemon requested a review from a team as a code owner August 17, 2022 04:17
@melvin-bot melvin-bot Bot requested review from marcochavezf and removed request for a team August 17, 2022 04:17
@yuwenmemon yuwenmemon requested a review from techievivek August 17, 2022 05:44
@aimane-chnaif

Copy link
Copy Markdown
Contributor

@yuwenmemon Your solution LGTM! https://github.com/Expensify/App/pull/10425/files#diff-dd48053a4b4ca8a948af29c248e8fee97c8d962017338228d8bec523842df230R52

Another solution:
The issue was similar to this: https://stackoverflow.com/questions/35491851/alignitems-center-prevents-flex-row-text-wrapping-in-react-native
So we can also fix this by updating this line:


To:

            props.isSmallScreenWidth && styles.alignItemsCenter,

This fixes both issues: #9817, #10419

I think either solution is fine

@techievivek techievivek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the changes.

Screenshot 2022-08-17 at 11 27 43 AM

@techievivek techievivek merged commit ff5eda6 into main Aug 17, 2022
@techievivek techievivek deleted the yuwen-alwaysNarrow branch August 17, 2022 05:58
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @techievivek in version: 1.1.89-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants