Use GithubUtils to access octokit#10415
Merged
Merged
Conversation
francoisl
commented
Aug 17, 2022
| function getTagsOrReleases(fetchReleases) { | ||
| if (fetchReleases) { | ||
| return octokit.repos.listReleases({ | ||
| return GithubUtils.octokit.repos.listReleases({ |
Contributor
Author
There was a problem hiding this comment.
I think an alternative would be to do octokit.rest.repos.listReleases() (ref), but this was the only place we don't use GithubUtils, so I went with that for consistency.
roryabraham
approved these changes
Aug 18, 2022
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
48 tasks
Contributor
|
🚀 Deployed to staging by @roryabraham in version: 1.1.89-0 🚀
|
|
Seems pass. https://github.com/Expensify/App/actions/runs/2913733257 Checking off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc'ing @roryabraham for context/familiarity
Details
Attempt to solve https://github.com/Expensify/App/runs/7866938557?check_suite_focus=true:
Tests
Is this testable locally in advance?
QA