Refactor part of Wallet_Activate into VerifyIdentity by MariaHCD · Pull Request #10053 · Expensify/App

MariaHCD · 2022-07-22T14:55:24Z

Hold on: https://github.com/Expensify/Web-Expensify/pull/34343

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/218501

Tests

Pre-requisites:

Have an account with a pending wallet (all new accounts have a pending wallet created automatically)
Get access to LexisNexis as this service is required on the AdditionalDetails Step which you'll need to complete before moving forward to the OnfidoStep:

Run the following commands:

nslookup webapi.libertydata.net
nslookup wsonline.seisint.com

Each one will return one or more address fields. For each of those, run:

sudo route add -net ADDRESS/32 172.16.106.1

For the three addresses I got back, this means the actual commands I run are:

sudo route add -net 209.243.48.97/32 172.16.106.1
sudo route add -net 50.79.80.169/32 172.16.106.1
sudo route add -net 65.144.58.53/32 172.16.106.1

Now, you'll need to mockup a successful response from Idology.
Note: To retest with the same wallet bank account, run the following to reset the KYC flow:

UPDATE bankAccounts SET additionalData = JSON_SET(COALESCE(NULLIF(additionalData, ''), '{}'), '$.verifications', JSON('{}')) WHERE bankAccountID = 40;

UPDATE bankAccounts SET additionalData = JSON_SET(COALESCE(NULLIF(additionalData, ''), '{}'), '$.currentStep', 'AdditionalDetailsStep') WHERE bankAccountID = 40;

Tests:

Navigate to /enable-payments, fill out the additional details form
You'll now see the Onfido Privacy page and will be taken through the Onfido flow as shown below. (Note: proceed through the flow without using any of your own ID if you can avoid it - Onfido recommends to not use real info)

Verify you can complete the process successfully:

If the check passes or wasn't able to complete synchronously, you'll be directed to the Terms page.

If the check didn't pass and you had some fixable errors, those errors will be displayed and you can retry the flow again. You can mock some fixable errors by setting $didPass to false and $onfidoFixableErrors to:

$onfidoFixableErrors = [Onfido_API::ERROR_IMAGE_QUALITY, Onfido_API::ERROR_SELFIE];

To mock fixable errors in Onyx:

let data = {
    errors: { 1660306327299659: "Sorry we're unable to verify your identity. Please fix the errors before continuing." },
    fixableErrors: [
        "There's an issue with your selfie/video. Please upload a new selfie/video in real time."
    ]
};
Onyx.merge('walletOnfido', data);

If the check failed, you'll be directed to the failed KYC page. You can mock this failure by throwing:

throw new IdentityVerificationError('3D9B8AC1-C2C0-49CC-B817-7660A0E72EE7', IdentityVerificationError::VERIFICATION_ERROR]);

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

None. We'll test the entire KYC process internally once all the steps have been refactored.

Screenshots

Web

Added in test steps

Mobile Web

…-identity

melvin-bot · 2022-07-26T15:27:48Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

…-identity

…-identity # Conflicts: # src/libs/actions/Wallet.js

MariaHCD · 2022-08-16T11:27:47Z

Conflicts fixed. On hold till the Web PR goes out to prod but this is ready for reviews @marcochavezf @marcaaron @francoisl!

MariaHCD · 2022-08-17T06:22:53Z

Off hold!

marcochavezf · 2022-08-18T00:37:25Z

The code LGTM but I can't test it locally because for some reason I'm not getting the Verify Identity page yet.

For the three addresses I got back, this means the actual commands I run are:
sudo route add -net 209.243.48.97/32 172.16.106.1
sudo route add -net 50.79.80.169/32 172.16.106.1
sudo route add -net 65.144.58.53/32 172.16.106.1

Not sure it's related to the problem, but I got only two addresses in the pre-requisite steps.

Also I found an issue that I think is not related to the PR: When I try to fill out the Additional details (which is the first page that appears when I navigate to /enable-payments) the server error is not displayed in the front-end:

francoisl · 2022-08-18T02:25:24Z

Not sure it's related to the problem, but I got only two addresses in the pre-requisite steps.

I only had two addresses as well, and it worked. Is it possible you didn't mock the response from IDology here, and it failed at that step? Alternatively, you might be able to skip directly to the Onfido step by running this query (replace the bankAccountID with your wallet's ID):

UPDATE bankAccounts SET additionalData = JSON_SET(COALESCE(NULLIF(additionalData, ''), '{}'), '$.currentStep', 'OnfidoStep') WHERE bankAccountID = XXX;

MariaHCD

Not sure it's related to the problem, but I got only two addresses in the pre-requisite steps.

Nope, should be all good. I got two addresses as well :)

I can't test it locally because for some reason I'm not getting the Verify Identity page yet.

As @francoisl said, you'll need to mock the response from IDology here and you should be good to go.

Also I found an issue that I think is not related to the PR: When I try to fill out the Additional details (which is the first page that appears when I navigate to /enable-payments) the server error is not displayed in the front-end:

Thanks for catching that! Its probably related to the other refactor PR: https://github.com/Expensify/Web-Expensify/pull/34326. Working on a separate PR to fix that.

marcaaron · 2022-08-18T16:10:14Z

-                <View style={[styles.flexRow, styles.ml2, styles.flexWrap, styles.flex1]}>
-                    {!_.isEmpty(props.message) && props.isMessageHtml && <RenderHTML html={`<muted-text>${props.message}</muted-text>`} />}
+class FormAlertWrapper extends React.Component {
+    renderMessage() {


This is missing a JSDoc with the @returns, but would recommend reverting most of these changes. They are unrelated to the current changes (I'm having trouble telling exactly what changed about this file otherwise) and I think we normally recommend to keep as much JSX inline as possible (though I'm not sure if this is established somewhere in the style guide or just clash of personal preference).

marcochavezf · 2022-08-19T00:15:27Z

Alternatively, you might be able to skip directly to the Onfido step by running this query (replace the bankAccountID with your wallet's ID):
UPDATE bankAccounts SET additionalData = JSON_SET(COALESCE(NULLIF(additionalData, ''), '{}'), '$.currentStep', 'OnfidoStep') WHERE bankAccountID = XXX;

Thanks this helped! Also, I found in this SO that I had to enter 3333 in the SSN field to continue 😄

This reverts commit a10d2d9.

…-identity

marcaaron

Looks great!

OSBotify · 2022-08-19T18:53:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-08-23T19:11:41Z

🚀 Deployed to staging by @francoisl in version: 1.1.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

MariaHCD added 2 commits July 22, 2022 18:04

Add call to refactored VerifyIdentity command

801c2cc

Call verifyIndentity in OnfidoStep

3df89d3

MariaHCD self-assigned this Jul 22, 2022

MariaHCD added 8 commits July 25, 2022 17:59

Optimistically set shouldShowFailedKYC as false

40ac178

Handle Onfido fixable errors

554b31a

Merge remote-tracking branch 'origin/main' into maria-refactor-verify…

34a25b1

…-identity

Use arrayOf

208b730

Merge remote-tracking branch 'origin/main' into maria-refactor-verify…

74adbf7

…-identity

Display fixable errors

11901b6

Improve display of fixable errors

3890bf1

Omit value for boolean attribute

f727d33

MariaHCD added 2 commits August 9, 2022 13:12

Merge remote-tracking branch 'origin/main' into maria-refactor-verify…

5d23285

…-identity

Update error object format

c498ade

MariaHCD marked this pull request as ready for review August 10, 2022 07:29

MariaHCD requested a review from a team as a code owner August 10, 2022 07:29

MariaHCD requested review from marcaaron and marcochavezf August 10, 2022 07:29

melvin-bot Bot requested review from francoisl and removed request for a team August 10, 2022 07:29

MariaHCD changed the base branch from main to jack-paymentMethodPatternB August 10, 2022 12:13

MariaHCD changed the base branch from jack-paymentMethodPatternB to main August 10, 2022 12:14

marcochavezf reviewed Aug 11, 2022

View reviewed changes

Comment thread src/pages/EnablePayments/OnfidoPrivacy.js Outdated

marcochavezf reviewed Aug 11, 2022

View reviewed changes

Comment thread src/components/FormAlertWrapper.js

MariaHCD added 6 commits August 12, 2022 15:19

Merge remote-tracking branch 'origin/main' into maria-refactor-verify…

c9b8ef2

…-identity

Make FormAlertWrapper more readable

a10d2d9

Use newline instead of break tag

c94097e

Use constants and update comment

60b96ad

Fix display of fixable error

e585326

Merge remote-tracking branch 'origin/main' into maria-refactor-verify…

d9cfe24

…-identity # Conflicts: # src/libs/actions/Wallet.js

MariaHCD changed the title ~~[HOLD Web #34343] Refactor part of Wallet_Activate into VerifyIdentity~~ Refactor part of Wallet_Activate into VerifyIdentity Aug 17, 2022

francoisl previously approved these changes Aug 17, 2022

View reviewed changes

MariaHCD commented Aug 18, 2022

View reviewed changes

marcaaron requested changes Aug 18, 2022

View reviewed changes

marcaaron requested a review from marcochavezf August 18, 2022 16:23

MariaHCD added 2 commits August 19, 2022 11:45

Revert "Make FormAlertWrapper more readable"

824933e

This reverts commit a10d2d9.

Set errors and fixableErrors to null

10ad0b8

MariaHCD dismissed francoisl’s stale review via 10ad0b8 August 19, 2022 07:50

Merge remote-tracking branch 'origin/main' into maria-refactor-verify…

51665ca

…-identity

MariaHCD requested a review from marcaaron August 19, 2022 08:38

Set errorFields to null

e9d29b1

marcaaron approved these changes Aug 19, 2022

View reviewed changes

marcochavezf approved these changes Aug 19, 2022

View reviewed changes

francoisl approved these changes Aug 19, 2022

View reviewed changes

francoisl merged commit 3e03f08 into main Aug 19, 2022

francoisl deleted the maria-refactor-verify-identity branch August 19, 2022 18:43

OSBotify mentioned this pull request Aug 23, 2022

Deploy Checklist: New Expensify 2022-08-23 #10498

Closed

48 tasks

Uh oh!

Conversation

MariaHCD commented Jul 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web

Uh oh!

melvin-bot Bot commented Jul 26, 2022

Uh oh!

Uh oh!

Uh oh!

MariaHCD commented Aug 16, 2022

Uh oh!

MariaHCD commented Aug 17, 2022

Uh oh!

marcochavezf commented Aug 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

francoisl commented Aug 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MariaHCD left a comment

Choose a reason for hiding this comment

Uh oh!

marcaaron Aug 18, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

marcochavezf commented Aug 19, 2022

Uh oh!

marcaaron left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 19, 2022

Uh oh!

OSBotify commented Aug 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MariaHCD commented Jul 22, 2022 •

edited

Loading

marcochavezf commented Aug 18, 2022 •

edited

Loading

francoisl commented Aug 18, 2022 •

edited

Loading