Rules - "None" remains on category list and is selectable after selecting a category.

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.4.27-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #94696
Email or phone of affected tester (no customers): applausetester+ib0024@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome
App Component: Workspace Settings

Action Performed:

Prerequisite: Use an expensifail account.
Prerequisite 2: User is owner of a "Control" workspace with "Rules" enabled.

1. Open the staging.new.expensify.com website.
2. Navigate to "Workspaces" > Workspace > "Rules"
3. Click on "Require Fields" > "Create Require rule" > "Category"
4. Note that "None" is already selected.
5. Select a different category and reopen "Category" field.
6. Note that below the selected category, "None" is still visible and selectable.

Expected Result:

"None" shouldn´t be displayed on category list while creating a rule after selecting another category.

Actual Result:

After selecting a category while creating a "Require" rule, "None" is still displayed on category list and is selectable as a different category.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7198983_1783116119488.None.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7198983

Issue Owner

Current Issue Owner: @Krishna2323

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/61c2edb2da38befaf93b2b38a88f1576cc63f4b9740c3b558233a6184ce49c51

[melvin-bot]

@luacmartins recently merged #94696, but they are OOO right now, so I'll auto-assign someone else.

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

What is the root cause of that problem?

The category picker for creating a Require fields rule renders a permanent, always-selectable "None" option. It is shown before you pick anything (that's why "None" appears pre-selected in step 4) and it stays in the list after you select a real category (step 6).

This happens because RuleSelectionBase.tsx:72 hard-codes allowNoneOption on the underlying picker. In SearchSingleSelectionPicker.tsx:56-65, when allowNoneOption is true the "None" item is added to the first section unconditionally — it never depends on whether a real item is already selected, so it can never disappear.

For a Require fields rule the category is a required condition (the rule applies to "Category is X"), so "None" is never a valid choice here. The same shared component backs the Flag for review and Merchant type category pickers, which have the identical problem.

Evidence / call chain

• RequireFieldsRuleCategoryPageBase.tsx → renders RuleSelectionBase.
• RuleSelectionBase → SearchSingleSelectionPicker with allowNoneOption always set.
• noneItem is spread into the first section regardless of selection state, so it always shows and remains selectable.
• Introduced with the Rules Revamp R2 work ([Due for payment 2026-07-13] [Rules Revamp] Release 2: Move category-based creation into Rules; add Require fields and Flag for review #92741 / PR [Rules Revamp] Release 2: Move category-based creation into Rules; add Require fields and Flag for review #94696), which added the require-fields/flag-for-review category condition pickers on top of the shared RuleSelectionBase.

What changes do you think we should make in order to solve the problem?

Make allowNoneOption a prop on RuleSelectionBase instead of hard-coding it, then set allowNoneOption={false} for the category condition pickers where a category is required:

• RequireFieldsRules/RequireFieldsRuleCategoryPageBase.tsx
• FlagForReviewRules/FlagForReviewRuleCategoryPageBase.tsx
• MerchantTypeRules/MerchantTypeRuleCategoryPage.tsx

Keep the default true inside RuleSelectionBase so the existing expense-default pickers (Fields/AddCategoryPage, AddTagPage, AddTaxRatePage, MerchantRules/AddCategoryPage, etc.), where clearing to "None" is legitimate, are unaffected.

What alternative solutions did you explore? (Optional)

Hide the "None" item in SearchSingleSelectionPicker once a real item is selected. Rejected — it would still leave "None" pre-selected/selectable before a choice is made, and it changes shared picker behavior globally rather than scoping the fix to the pickers that actually require a category.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/95358) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.