[Due for payment 2026-07-13] [$250] Home - Review 1 expense opens expense report instead of expense with violation

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.4.26-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #94299
Email or phone of affected tester (no customers): odinjsdojosdijiossojo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create two expenses without category.
4. Go to Home.
5. Click Review 2 expenses.
6. Click Category and select any category.
7. Close the report view.
8. Click Review 1 expense.

Expected Result:

Expense RHP with missing category will open.

Actual Result:

Expense report RHP opens, showing both expenses with and without violation.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7196900_1782936931783.3.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7196900

Issue Owner

Current Issue Owner: @ZhenjaHorbach

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022072670128996661860
• Upwork Job ID: 2072670128996661860
• Last Price Increase: 2026-07-02

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/f0b0f2ea920b38ef2c85c890fc7e254e4fd3c1bee6127384d648da63b4f9ee9a

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #94299

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a single OPEN expense report contains multiple transactions but only one is flagged with a violation, pressing Review 1 expense on Home opens the whole expense report (showing every expense) instead of the RHP for the single flagged expense.

What is the root cause of that problem?

In useReviewFlaggedExpenses.ts:170, the handler decides between "open the report" and "open the single transaction thread" with:

if (flaggedExpenses.length === 1 && isMoneyRequestReport(firstFlaggedReport)) {
    // navigate to the full EXPENSE_REPORT_RHP / REPORT_WITH_ID
}

The code comment says the shortcut is meant for a one-transaction report ("the transaction thread is a redundant duplicate of the report itself"), but the condition never checks how many transactions the report has:

• flaggedExpenses.length === 1 means "one flagged expense across the user", not "the report has one expense".
• isMoneyRequestReport only checks the report type (isIOUReport || isExpenseReport) — it is always true for an expense report.

So in the repro, both expenses live in the same OPEN expense report. After fixing one category, exactly one expense is still flagged → flaggedExpenses.length === 1 is true and isMoneyRequestReport is true → it navigates to the full report (which still lists both expenses). The correct helper for the intended check already exists: isOneTransactionReport (report?.transactionCount === 1).

What changes do you think we should make in order to solve the problem?

Swap the type check for the transaction-count check in useReviewFlaggedExpenses.ts:170:

if (flaggedExpenses.length === 1 && isOneTransactionReport(firstFlaggedReport)) {

With this, a report holding 2 transactions (count !== 1) falls through to navigateToTransactionThread, which opens the RHP for the single flagged transaction — matching the Expected Result. The "open the report directly" shortcut is then correctly reserved for reports that genuinely hold only one expense. Add a unit test covering "1 flagged expense inside a multi-transaction report" to tests/unit/hooks/useReviewFlaggedExpenses.test.ts.

Why it doesn't repro in production / relationship to PR #94299

The buggy condition is not newly introduced by PR #94299 (the assigned PR) — that PR was a refactor that moved the logic out of the flaggedExpenses derived value, and the pre-refactor code used the equivalent count === 1 && isMoneyRequestReport(...). So reverting #94299 would not fix this; the fix should be applied directly. The "Review X expenses" row is new to this release, which is why it's not reproducible in production.

Also worth confirming during implementation: transactionCount must be populated on OPEN expense reports for isOneTransactionReport to be reliable here.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/95089) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

[cristipaval]

@MelvinBot implement this