Problem
In the money request report preview, there are two animated shared values: checkMarkScale and thumbsUpScale.
They are set in effects when an expense is paid (isPaidAnimationRunning) and when a report is approved (isApprovedAnimationRunning). But nothing reads them. There is no .get() on them, no animated style built from them, and no icon that uses them. So the animations run but nothing shows on screen.
This is old code, not something new. Today it lives in MoneyRequestReportPreviewContent. After PR #94675 it moves into the new usePreviewMessageAnimation hook, and the hook docstring even says it plays "checkmark / thumbs-up spring animations on settle / approval" — but they don't render.
See the discussion: #94675 (comment)
Question to answer first
The names suggest these were meant to show a checkmark when an expense is paid and a thumbs-up when it is approved. So this could be a real missing animation, not just dead code. We need to decide which case it is.
Goal
- If these animations are not needed, remove both shared values and their effects, and fix the docstring so it only mentions the opacity animation.
- If they are supposed to show, wire the scales to the checkmark / thumbs-up icons so the animations actually render.
Related
Issue Owner
Current Issue Owner: @Krishna2323
Problem
In the money request report preview, there are two animated shared values:
checkMarkScaleandthumbsUpScale.They are set in effects when an expense is paid (
isPaidAnimationRunning) and when a report is approved (isApprovedAnimationRunning). But nothing reads them. There is no.get()on them, no animated style built from them, and no icon that uses them. So the animations run but nothing shows on screen.This is old code, not something new. Today it lives in
MoneyRequestReportPreviewContent. After PR #94675 it moves into the newusePreviewMessageAnimationhook, and the hook docstring even says it plays "checkmark / thumbs-up spring animations on settle / approval" — but they don't render.See the discussion: #94675 (comment)
Question to answer first
The names suggest these were meant to show a checkmark when an expense is paid and a thumbs-up when it is approved. So this could be a real missing animation, not just dead code. We need to decide which case it is.
Goal
Related
Issue Owner
Current Issue Owner: @Krishna2323