[Due for payment 2026-07-17] [$250] Clean-up some tax related bugs.

[trjExpensify]

Spawned from here.

---

• BUG: Tax showing in the report table on a Per Diem expense

1. Create a workspace
2. Enable Taxes
3. Enable Per Diem > Add the per diem rates
4. Create a normal expense with tax
5. Create a per diem expense
6. Go to the Spend > Expenses table. Enable the Tax rate and Tax column
7. Observe the Tax column has a calculated value
8. Open the report
9. Observe the Tax rate column has a value
10. Observe the Tax column has a value of $0.00

Expected results:
Per Diem expenses do not have tax applied on them, so there shouldn't be tax related values anywhere on this expense type in the table.

2026-06-19_01-52-21.mp4

Classic reference, no tax customUnits on this expense:

---

• BUG: The tax Name, Value and Tax Code fields of a default tax rate on a workspace can’t be edited.

1. Create a workspace
2. Enable Taxes
3. Click on the default rate
4. Observe the tax fields aren’t editable
5. Close the RHP
6. Click on the Settings button
7. Change the workspace defaults to the other rate
8. Close the RHP
9. Click on the same tax rate from step 3 again
10. Observe the fields are now editable

Expected results:
The Name, Value and Tax Code fields of the default rate should be editable.

2026-06-19_00-50-53.mp4

---

• BUG: Tax code, Tax amount and Tax fields are showing in the report detailed view by default.

1. Create a new account
2. Create a workspace
3. Enable taxes
4. Create two expenses with tax
5. Go to Spend > Expenses
6. Observe no tax columns are in the table
7. Open the expense report
8. Observe the three tax columns are in the table.

Expected Result:

• These columns shouldn’t appear automatically when the report has expenses with tax, they should just be available custom columns to add if the user wants to set those columns as their preferred default for the report view.

2026-06-19_02-43-52.mp4

---

• BUG: Tax code platform default IDs are appearing in various places

1. Create a workspace
2. Enable Taxes
3. Open up the tax rates in the table
4. Observe the Tax Code field
5. Create a couple of expenses with tax
6. Go to Spend > Expenses
7. Enable the Tax code column
8. Observe the Tax code column doesn't appear in the table
9. Go to the report
10. Enable the Tax code column
11. Observe the default tax code ID is displayed on the expense in the table.

Expected results:

Like Classic, we don't show these platform defaultIDs, only the user set Tax Code. (CC: @twisterdotcom as this was added as a column fairly recently).

Classic reference:

Issue Owner

Current Issue Owner: @truph01

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022067789366868051266
• Upwork Job ID: 2067789366868051266
• Last Price Increase: 2026-06-19

[trjExpensify]

@MelvinBot do not add the External label to this issue.

[MelvinBot]

Issue Analysis

All four bugs are confirmed in code at facfcc1. Three of them (#1, #3, #4) live in the tax-column rendering/visibility path (SearchUIUtils.ts + TransactionItemRowWide.tsx); #2 is independent (tax-rate edit page). Confidence: High on all four — each root cause was verified against the actual source.

---

Bug 1 — Per Diem expenses show a Tax rate + $0.00 Tax column

Root cause: The table cell renderer suppresses tax for time requests but never for per diem. In TransactionItemRowWide.tsx:489 (Tax rate), :498 (Tax code) and :516 (Tax amount), the guard is isTimeRequest(...) only. For a per diem row, getTaxName falls back to the policy's default tax rate (TransactionUtils/index.ts:2199-2214), so the Tax rate shows a calculated value and Tax shows $0.00. (The RHP MoneyRequestView already handles per diem correctly via isTaxTrackingEnabled.)

Recommended fix: Add || isPerDiemRequest(transactionItem) alongside the existing isTimeRequest guard in those three cases (isPerDiemRequest is already exported from TransactionUtils). Optionally also exclude per-diem taxCode/taxAmount/taxValue from the column-visibility check at SearchUIUtils.ts:5826 so the column doesn't appear when all rows are per diem.

---

Bug 2 — Name / Value / Tax Code of the default tax rate aren't editable

Root cause: WorkspaceEditTaxPage.tsx:45 gates the Name/Value/Code edit menu items on canEditTaxRate, but PolicyUtils.canEditTaxRate is documented as "whether the tax rate can be deleted and disabled" and returns false for the default/foreign-default rate. Reusing that one flag makes the three edit fields non-interactive for the default rate. Switching the workspace default flips defaultExternalID, which is exactly why the repro fields become editable after changing the default.

Recommended fix: Decouple the two concerns. Keep canEditTaxRate for the enable Switch (:117/119) and Delete item (:47), but gate the Name/Value/Code MenuItemWithTopDescription items (:131/137, :147/153, :163/181) on a new canEditTaxFields = !!canWriteTaxes && !!policy flag that does not include the default-rate check. Do not change the shared helper — WorkspaceTaxesPage.tsx correctly relies on it to block disabling/bulk-deleting the default rate.

---

Bug 3 — Tax columns appear automatically in the single-report table view

Root cause: Both the Spend > Expenses table and the report view call getColumnsToShow, but the data-presence block that auto-enables tax columns runs if (customResult || isExpenseReportView) (SearchUIUtils.ts:5814). The Expenses table passes neither, so it's skipped (correct). The report view passes isExpenseReportView: true, so the block always runs, and the bare per-transaction checks !!transaction.taxCode || !!transaction.taxAmount || !!transaction.taxValue (:5826-5833) force the three tax columns on. Tax columns are otherwise defined as optional custom columns, absent from the default sets.

Recommended fix: Gate the per-transaction tax detection behind customResult so the default report view falls back to the seeded false for tax columns — i.e. only auto-show when the user has explicitly added them as custom columns. Verify the column picker at ReportDetailsColumnsPage.tsx still pre-checks correctly after the change.

---

Bug 4 — Platform default tax-code IDs shown in the Tax code column

Root cause: TransactionItemRowWide.tsx:498 renders transactionItem.taxCode raw. That field stores the platform-generated external ID (the id_{TAX_RATE_NAME} map key), not the user-set code attribute (Policy.ts:225-255). Classic shows only the user-set code (blank when unset). Note the Tax rate column right above resolves correctly via getTaxName; only Tax code uses the raw value.

Recommended fix: Resolve through the policy tax map and show the user code, falling back to empty — e.g. a getTaxCodeForDisplay(policy, transaction) helper next to getTaxName returning transformedTaxRates(policy, transaction)[transaction.taxCode]?.code ?? ''. Also check the TAX_CODE sort path in SearchUIUtils.ts so it sorts on the resolved code.

The sub-symptom "Tax code column doesn't appear in Spend > Expenses when toggled" is a separate gating issue at SearchUIUtils.ts:5831-5832 (column only auto-shows when customResult && isPolicyTaxEnabled or transaction.taxCode is set in that context) and should be confirmed separately.

---

Scope note & verification

• Each root cause above was confirmed by reading the cited lines at commit facfcc1c9e4fff22ace8b603be0f05a2d5fc76c6.
• Bugs 1, 3, 4 share the tax-column subsystem (TransactionItemRowWide.tsx + getColumnsToShow in SearchUIUtils.ts), so a single PR could reasonably address all three; bug 2 is isolated to the tax-rate edit page.
• Open product questions to confirm before merging: (a) per-diem tax should be fully blank everywhere (matches Classic); (b) Name/Value/Code editable on the default rate (matches Classic); (c) tax columns should be opt-in custom columns in the report view, not auto-shown.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/94003) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

[ahmdshrif]

🚨 Edited by proposal-police: This proposal was edited at 2026-06-19 02:01:08 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Four tax clean-up bugs: (1) Per Diem rows show tax rate/amount; (2) the current default tax rate's Name/Value/Tax Code can't be edited; (3) opening a report auto-shows the 3 tax columns; (4) platform default tax-code IDs (id_TAX_*) appear as if user-set.

What is the root cause of that problem?

These are four independent causes (1 & 3 share one file):

1 — Per Diem tax. The report-table tax cells suppress tax only for the sibling tax-exempt type isTimeRequest, never for isPerDiemRequest. Per Diem carries no tax, so the cell falls through to the policy default → renders a tax name + $0.00: TAX_RATE/CODE/AMOUNT cells. The same gap lets per-diem trip the column auto-show: hasTaxInfo.

2 — Default rate read-only. canEditTaxRate is a delete/disable gate (JSDoc "can be deleted and disabled"; returns false for the default rate): PolicyUtils. The edit page overloads it as the interactive flag on the Name/Value/Code rows, so the current default's fields go read-only; switching the default flips it: WorkspaceEditTaxPage L45,137,153,181.

3 — Report auto-shows tax columns. The data-presence auto-enable runs whenever isExpenseReportView, forcing the 3 tax columns on for any taxed expense; Spend>Expenses passes customResult=false and so doesn't — hence the two views differ: SearchUIUtils L5814.

4 — Platform id_ codes. Platform-seeded rates use id_TAX_* keys as their code (CONST.DEFAULT_TAX). These are rendered verbatim — report Tax Code column transactionItem.taxCode and edit page taxCodeToShow = ... taxID. Classic hides platform defaults.

What changes do you think we should make in order to solve the problem?

1. Treat Per Diem like time requests in all three tax cells (isTimeRequest(t) || isPerDiemRequest(t)) and exclude per-diem from hasTaxInfo.
2. Gate the Name/Value/Code rows on write access only (canWriteTaxes); keep canEditTaxRate solely on the delete item.
3. Gate the tax-column auto-enable on customResult, not isExpenseReportView, so the columns stay optional in report view.
4. Add a isDefaultTaxCode helper (code starts with the id_ prefix / matches a DEFAULT_TAX key) and show '' for it in the report column and edit page.

Each change is scoped to the tax-exempt / default-rate / platform-default path; non-tax columns, normal rates, and other expense types are untouched.

What alternative solutions did you explore? (Optional)

• Bug 1: guard only TaxCell/getTaxAmount — misses the TAX_RATE and TAX_CODE columns, which still show a value.
• Bug 2: hide only the delete item for the default — doesn't restore the field editability the issue asks for.
• Bug 3: remove tax columns from the default set — they're re-added by the data-presence loop, so the gate is the real fix.

[melvin-bot]

Current assignees @truph01 and @dmkt9 are eligible for the External assigner, not assigning anyone new.

[wildan-m]

Proposal

Please re-state the problem that we are trying to solve in this issue.

This issue collects four tax-related clean-up bugs in NewDot:

1. Tax rate and Tax amount values are shown in the expenses/report table for Per Diem expenses, even though Per Diem expenses never have tax applied (the Tax column shows $0.00 and the Tax rate column shows a value).
2. The Name, Value and Tax Code fields of a workspace's default tax rate cannot be edited; they only become editable after that rate stops being the default.
3. The Tax code, Tax amount and Tax columns appear automatically in a report's detailed table view whenever the report contains taxed expenses, instead of being optional columns the user opts into.
4. Platform-generated internal tax IDs (e.g. id_TAX_EXEMPT, id_TAX_RATE_1) are displayed in the Tax code column instead of only the user-set Tax Code, unlike Classic.

What is the root cause of that problem?

Bug 1 — Tax shown on Per Diem expenses.
The table cell renderers blank the tax columns only for time (per-hour) requests via isTimeRequest, but never for Per Diem requests. A Per Diem transaction still carries a taxValue/taxAmount (often 0), so its Tax rate and Tax amount cells render values:

App/src/components/TransactionItemRow/TransactionItemRowWide.tsx

Lines 483 to 523 in 13b6443

	case CONST.SEARCH.TABLE_COLUMNS.TAX_RATE:
	return (
	<View
	key={column}
	style={[StyleUtils.getReportTableColumnStyles(CONST.SEARCH.TABLE_COLUMNS.TAX_RATE)]}
	>
	<TextCell text={isTimeRequest(transactionItem) ? '' : (getTaxName(policy, transactionItem) ?? transactionItem.taxValue ?? '')} />
	</View>
	);
	case CONST.SEARCH.TABLE_COLUMNS.TAX_CODE:
	return (
	<View
	key={column}
	style={[StyleUtils.getReportTableColumnStyles(CONST.SEARCH.TABLE_COLUMNS.TAX_CODE)]}
	>
	<TextCell text={isTimeRequest(transactionItem) ? '' : (transactionItem.taxCode ?? '')} />
	</View>
	);
	case CONST.SEARCH.TABLE_COLUMNS.MCC:
	return (
	<View
	key={column}
	style={[StyleUtils.getReportTableColumnStyles(CONST.SEARCH.TABLE_COLUMNS.MCC)]}
	>
	<TextCell text={getMCCForDisplay(transactionItem.mcc)} />
	</View>
	);
	case CONST.SEARCH.TABLE_COLUMNS.TAX_AMOUNT:
	return (
	<View
	key={column}
	style={[StyleUtils.getReportTableColumnStyles(CONST.SEARCH.TABLE_COLUMNS.TAX_AMOUNT, {isTaxAmountColumnWide})]}
	>
	{isTimeRequest(transactionItem) ? null : (
	<TaxCell
	transactionItem={transactionItem}
	shouldShowTooltip={shouldShowTooltip}
	/>
	)}
	</View>
	);

Bug 2 — Default tax rate fields not editable.
WorkspaceEditTaxPage derives one canEditTaxRate flag from canEditTaxRate(policy, taxID), which returns false for the workspace default / foreign default rate:

App/src/libs/PolicyUtils.ts

Lines 1402 to 1407 in 13b6443

	/**
	* Whether the tax rate can be deleted and disabled
	*/
	function canEditTaxRate(policy: Policy, taxID: string): boolean {
	return policy.taxRates?.defaultExternalID !== taxID && policy.taxRates?.foreignTaxDefault !== taxID;
	}

That helper is documented as "whether the tax rate can be deleted and disabled" and correctly guards the enable/disable toggle and the Delete action. But the same flag is reused for the interactive/shouldShowRightIcon props of the Name, Value and Tax Code menu items, which locks editing of those fields whenever the rate is the current default:

App/src/pages/workspace/taxes/WorkspaceEditTaxPage.tsx

Lines 130 to 182 in 13b6443

	<MenuItemWithTopDescription
	shouldShowRightIcon={canEditTaxRate}
	title={currentTaxRate?.name}
	description={translate('common.name')}
	style={[styles.moneyRequestMenuItem]}
	titleStyle={styles.flex1}
	onPress={() => Navigation.navigate(ROUTES.WORKSPACE_TAX_NAME.getRoute(`${policyID}`, taxID))}
	interactive={canEditTaxRate}
	/>
	</OfflineWithFeedback>
	<OfflineWithFeedback
	errors={getLatestErrorField(currentTaxRate, 'value')}
	pendingAction={currentTaxRate?.pendingFields?.value}
	errorRowStyles={styles.mh5}
	onClose={() => clearTaxRateFieldError(policyID, taxID, 'value')}
	>
	<MenuItemWithTopDescription
	shouldShowRightIcon={canEditTaxRate}
	title={currentTaxRate?.value}
	description={translate('workspace.taxes.value')}
	style={[styles.moneyRequestMenuItem]}
	titleStyle={styles.flex1}
	onPress={() => Navigation.navigate(ROUTES.WORKSPACE_TAX_VALUE.getRoute(`${policyID}`, taxID))}
	interactive={canEditTaxRate}
	/>
	</OfflineWithFeedback>
	<OfflineWithFeedback
	errors={getLatestErrorField(currentTaxRate, 'code')}
	pendingAction={currentTaxRate?.pendingFields?.code}
	errorRowStyles={styles.mh5}
	onClose={() => clearTaxRateFieldError(policyID, taxID, 'code')}
	>
	<MenuItemWithTopDescription
	shouldShowRightIcon={canEditTaxRate}
	title={taxCodeToShow}
	description={translate('workspace.taxes.taxCode')}
	style={[styles.moneyRequestMenuItem]}
	titleStyle={styles.flex1}
	onPress={() => {
	if (!isControlPolicy(policy)) {
	Navigation.navigate(
	ROUTES.WORKSPACE_UPGRADE.getRoute(
	policyID,
	CONST.UPGRADE_FEATURE_INTRO_MAPPING.taxCodes.alias,
	ROUTES.WORKSPACE_TAX_CODE.getRoute(`${policyID}`, taxID),
	),
	);
	return;
	}
	Navigation.navigate(ROUTES.WORKSPACE_TAX_CODE.getRoute(`${policyID}`, taxID));
	}}
	interactive={canEditTaxRate}
	/>

When the user changes the workspace default to another rate, the previously-default rate passes the guard again and its fields become editable — exactly the behavior described in the issue.

Bug 3 — Tax columns auto-appear in the report detail view.
getColumnsToShow has a data-presence block guarded by if (customResult || isExpenseReportView). In the per-report detail table isExpenseReportView is always true, so the block runs even when the user has not customized columns. Inside it, hasTaxInfo flips the Tax rate / Tax amount (and Tax code) columns on as soon as any transaction has a tax signal:

App/src/libs/SearchUIUtils.ts

Lines 5811 to 5833 in 13b6443

	// Data-presence checks for columns that are hidden when empty.
	// Only update when we have custom columns to filter (customResult) or in expense report view,
	// so that the default search page path doesn't show extra columns.
	if (customResult || isExpenseReportView) {
	if (transaction.cardName && transaction.cardName !== CONST.EXPENSE.TYPE.CASH_CARD_NAME) {
	columns[CONST.SEARCH.TABLE_COLUMNS.CARD] = true;
	}
	// Show both TAX_RATE and TAX_AMOUNT when the transaction has a meaningful tax signal.
	// Use truthy checks so default/no-tax values (0, null, '', undefined) don't trigger
	// false positives — buildOptimisticTransaction seeds taxAmount: 0 on every new draft,
	// which would otherwise flash tax columns on for offline-pending transactions.
	// When the user explicitly selected the tax columns (customResult) and the workspace
	// has taxes enabled, keep them regardless of per-transaction values — older expenses
	// created before taxes were turned on still have null taxCode/taxAmount/taxValue.
	const hasTaxInfo = (!!customResult && isPolicyTaxEnabled) || !!transaction.taxCode || !!transaction.taxAmount || !!transaction.taxValue;
	if (hasTaxInfo) {
	columns[CONST.SEARCH.TABLE_COLUMNS.TAX_RATE] = true;
	columns[CONST.SEARCH.TABLE_COLUMNS.TAX_AMOUNT] = true;
	}
	if ((!!customResult && isPolicyTaxEnabled) || !!transaction.taxCode) {
	columns[CONST.SEARCH.TABLE_COLUMNS.TAX_CODE] = true;
	}

On the top-level Spend > Expenses search table isExpenseReportView is false and customResult is undefined by default, so this block never runs there — which is why the columns correctly stay hidden on the search table but leak into the report view.

Bug 4 — Platform default IDs shown as Tax code.
A tax rate's key in policy.taxRates.taxes is its external ID, and a transaction stores that key in transaction.taxCode. For a rate the user has not given an explicit Tax Code, the key is the platform-generated ID produced by covertTaxNameToID, which always prefixes id_:

App/src/libs/actions/TaxRate.ts

Lines 35 to 37 in 13b6443

	function covertTaxNameToID(name: string) {
	return `id_${name.toUpperCase().replaceAll(' ', '_')}`;
	}

These seeded defaults (id_TAX_EXEMPT, id_TAX_RATE_1) come from CONST.DEFAULT_TAX:

App/src/CONST/index.ts

Lines 6488 to 6503 in 13b6443

	DEFAULT_TAX: {
	defaultExternalID: 'id_TAX_EXEMPT',
	defaultValue: '0%',
	foreignTaxDefault: 'id_TAX_EXEMPT',
	name: 'Tax',
	taxes: {
	id_TAX_EXEMPT: {
	name: 'Tax exempt',
	value: '0%',
	},
	id_TAX_RATE_1: {
	name: 'Tax Rate 1',
	value: '5%',
	},
	},
	},

The Tax code cell prints transaction.taxCode verbatim, so these internal id_… IDs leak into the column:

App/src/components/TransactionItemRow/TransactionItemRowWide.tsx

Lines 492 to 500 in 13b6443

	case CONST.SEARCH.TABLE_COLUMNS.TAX_CODE:
	return (
	<View
	key={column}
	style={[StyleUtils.getReportTableColumnStyles(CONST.SEARCH.TABLE_COLUMNS.TAX_CODE)]}
	>
	<TextCell text={isTimeRequest(transactionItem) ? '' : (transactionItem.taxCode ?? '')} />
	</View>
	);

What changes do you think we should make in order to solve the problem?

Bug 1. In the Tax rate, Tax code and Tax amount cell renderers of TransactionItemRowWide, treat Per Diem requests the way time requests are already treated — render an empty cell when isPerDiemRequest(transactionItem) is true, combined with the existing isTimeRequest check. isPerDiemRequest is already exported from TransactionUtils.

Bug 2. In WorkspaceEditTaxPage, separate "can edit fields" from "can delete/disable". Keep canEditTaxRate (the default-rate guard) for the enable/disable Switch and the Delete menu item, but gate the Name, Value and Tax Code menu items' interactive/shouldShowRightIcon on plain write access (the canWriteTaxes permission plus a present policy) instead. The default rate's identifying fields then stay editable while the rate itself still cannot be disabled or deleted.

Bug 3. In getColumnsToShow, stop auto-enabling the tax columns purely because we are in a report detail view. Move the Tax rate / Tax amount / Tax code assignments so they only run when the user has an explicit custom-column selection (customResult), not when the block is entered solely via isExpenseReportView. The other data-presence columns (Card, MCC, Exchange rate, Total) keep their current behavior. Tax columns then remain available as opt-in columns the user can add from the report's column settings.

Bug 4. In the Tax code cell of TransactionItemRowWide, display the tax code only when it is a genuine user-set code: render an empty cell when the value is a platform-generated ID (i.e. it starts with the id_ prefix used by covertTaxNameToID), matching Classic which shows only user-defined codes. Introducing a small CONST.DEFAULT_TAX_ID_PREFIX ('id_') keeps this signal in one place.

Compare branch: https://github.com/Expensify/App/compare/main...wildan-m:App:wildan/94003-tax-cleanup?expand=1

What alternative solutions did you explore? (Optional)

• For Bug 1, the per-diem exclusion could instead be centralized in getTaxAmount/getTaxName in TransactionUtils, but those helpers are reused in contexts (e.g. the expense detail view) where current behavior is relied on, so guarding at the table cell — consistent with how isTimeRequest is already handled there — is the safer, more localized change.
• For Bug 4, instead of a prefix check the displayed value could be resolved through the policy's tax rates and shown only when a distinct user code exists; this is equivalent in outcome but requires the policy in the cell and extra lookups, whereas the id_ prefix is the same signal the rest of the tax code pipeline already uses.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022067789366868051266