[Due for payment 2026-04-23] [Due for payment 2026-04-20] Rules can be enabled without creating workspace to Control plan by clicking Set up spend rules

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.58-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #86663
Email or phone of affected tester (no customers): jsdjosidjiojisojio3@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Workspace Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with new Gmail account.
3. Complete onboarding with Manage my team's expenses and select QBO (Collect workspace will be created).
4. Go to Home.
5. Click Set up spend rules.

Expected Result:

Rules cannot be enabled without creating workspace to Control plan.

Actual Result:

Rules can be enabled without creating workspace to Control plan by clicking Set up spend rules.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7126637_1775817768575.7.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @ZhenjaHorbach

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #86663

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

What is the root cause of that problem?

The "Set up spend rules" item in the GettingStartedSection calls enablePolicyRules(policy, true, false) directly without checking whether the workspace is on the Control plan (useGettingStartedItems.ts:112, GettingStartedRow.tsx:30). The enablePolicyRules action itself has no plan-type guard — all gating is expected at the caller level. The proper gate exists in WorkspaceMoreFeaturesPage.tsx:328-331, which checks isControlPolicy(policy) and redirects to the upgrade page for non-Control workspaces, but the GettingStartedSection code path bypasses this entirely.

What changes do you think we should make in order to solve the problem?

Add an isControlPolicy check to the rules item's enableFeature callback in useGettingStartedItems.ts. If the policy is not Control (CORPORATE), navigate to ROUTES.WORKSPACE_UPGRADE (with the rules alias) instead of calling enablePolicyRules — mirroring the existing pattern in WorkspaceMoreFeaturesPage.tsx:328-331.

What alternative solutions did you explore? (Optional)

The check could also be placed in GettingStartedRow.tsx's navigateToItem, but putting it in the hook keeps the gating logic co-located with the item definition and avoids adding plan-awareness to a generic row component.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[OSBotify]

Investigation Summary: Frontend bug. Causing PR: #86663 by @adamgrzybowski (High confidence). Recommendation: REVERT. The new Getting Started section in PR #86663 enables workspace rules for Collect-plan workspaces without the Control-plan guard check that exists in WorkspaceMoreFeaturesPage.tsx. Root cause: GettingStartedRow.tsx calls enablePolicyRules() unconditionally when item.isFeatureEnabled is false, bypassing the isControlPolicy check that redirects to ROUTES.WORKSPACE_UPGRADE. Assigned: @adamgrzybowski @ZhenjaHorbach @JmillsExpensify @mountiny. Labels: DeployBlockerCash correctly kept (frontend App PR caused this).