[Due for payment 2026-05-22] [$250] [Unreported] Distance - After editing distance, Distance rate changes to personal rate

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.53-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #84136
Email or phone of affected tester (no customers): sjoinjojsodidsjodjso@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to self DM.
3. Create a manual distance expense.
4. Open the expense.
5. Click Distance.
6. Edit distance and save it.

Expected Result:

After editing distance, Distance rate will not change to personal default rate.

Actual Result:

After editing distance, Distance rate changes to personal default rate.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7123251_1775526119275.7.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022052420629411040865
• Upwork Job ID: 2052420629411040865
• Last Price Increase: 2026-05-07
• Automatic offers:
• FitseTLT | Reviewer | 111354935

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #84136

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #84136 "Feat - Add distance rate to the distance expenses tracked in selfDM" by @FitseTLT (High confidence)

Recommendation: REVERT

PR #84136 introduced the bug. When track tax is enabled and the user edits the distance on a track expense, the distance rate resets to the personal default rate instead of preserving the previously-selected rate.

Labels: DeployBlockerCash is kept (App PR caused this). DeployBlocker is being removed as this is a frontend bug requiring a fix in Expensify/App, not the backend.

Evidence:

• The melvin-bot identified PR Feat - [Unreported] Add distance rate to the distance expenses tracked in selfDM #84136 as the causing PR
• PR Feat - [Unreported] Add distance rate to the distance expenses tracked in selfDM #84136 is in the StagingDeployCash checklist for version 9.3.53-0, matching the bug report version
• The bug is staging-only (new feature, not in prod), confirming it was introduced in the current staging deploy
• The bug is specifically triggered when Track tax is enabled in Distance settings, a code path heavily modified by PR Feat - [Unreported] Add distance rate to the distance expenses tracked in selfDM #84136

Verification - Key files modified by PR #84136 related to the bug:

1. src/libs/DistanceRequestUtils.ts - The getCustomUnitRateID function was changed so that when isTrackDistanceExpense is true, it skips the lastSelectedDistanceRates lookup entirely and always returns the policy default rate. When the user edits the distance amount, this overrides the previously-selected rate (e.g., the one with 5% tax) with the policy default.

2. src/pages/iou/request/step/IOURequestStepDistanceManual.tsx - The PR removed customUnitRateID from the args passed to handleMoneyRequestStepDistanceNavigation, so the user-selected rate is no longer forwarded when navigating after editing the manual distance.

Root Cause:

In DistanceRequestUtils.getCustomUnitRateID, for isTrackDistanceExpense: true, the condition that preserves lastSelectedDistanceRate was gated out (!isTrackDistanceExpense &&). When the user edits the distance amount on a track expense that has a custom rate with 5% tax selected, handleMoneyRequestStepDistanceNavigation calls getCustomUnitRateID with isTrackDistanceExpense: true, bypassing the previously-selected rate and returning the policy default rate. This rate reset then also discards the tax association, causing the behavior seen in the video.