Expense - Radio button is present but is never checkmarked

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.50-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #83799
Email or phone of affected tester (no customers): snodijosdnjoijiosnj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Open FAB > Create expense > Manual.
3. Enter amount > Next.
4. Select a participant.
5. On confirm page, click To field.

Expected Result:

The list will show the participant as selected.

Actual Result:

The list does not show the participant as selected.
The radio button is there but never checkmarked.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7114897_1774615638583.5.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @zfurtak

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #83799

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #83799 - "Enhance icons UI consistency" by @zfurtak (High confidence)
Related Issues: None

Recommendation: REVERT

PR #83799 should be reverted. The PR introduced a design change to add radio buttons and checkboxes across selection lists, but inadvertently broke the participant selector on the IOU confirmation page.

Labels: No label changes needed - keeping DeployBlockerCash since this is a Frontend bug from an App PR that is reproducible only on staging.

📋 Detailed Analysis

Evidence

PR #83799 made widespread changes to selection list UI components to add radio buttons and checkboxes. However, when refactoring MoneyRequestConfirmationList.tsx, the PR:

1. Replaced UserListItem with NewChatListItem (line 80 and 1394 in the diff)
2. NewChatListItem is a newly created component that does NOT render radio buttons or checkboxes
3. UserListItem was modified to support shouldShowRadioButton prop for displaying selection state
4. The replacement broke the selection indicator on the "To" field participant selector

When users click the "To" field on the IOU confirmation page to view/change the recipient, they should see a radio button checkmark next to the selected participant. However, NewChatListItem only renders:

• Avatar
• Text labels
• Optional arrow icon (if item.shouldShowRightCaret is true)

It has no code to render selection state indicators.

Verification

Affected file: /home/runner/_work/App/App/src/components/MoneyRequestConfirmationList.tsx

The component uses NewChatListItem at line 1401:

<SelectionListWithSections<MoneyRequestConfirmationListItem>
    sections={sections}
    ListItem={NewChatListItem}  // ❌ This component does not render radio buttons
    onSelectRow={navigateToParticipantPage}
    ...
/>

Before PR #83799: Used UserListItem which rendered selection indicators
After PR #83799: Uses NewChatListItem which does not render selection indicators

Root Cause

The PR created NewChatListItem as a simplified list item for the new chat flow, but mistakenly used it in MoneyRequestConfirmationList where selection state display is required. The component lacks the radio button rendering logic that exists in the modified UserListItem and InviteMemberListItem components.

Specifically in /home/runner/_work/App/App/src/components/Search/NewChatListItem.tsx (lines 120-128), the component only shows:

• item.rightElement (custom right element)
• Arrow icon if item.shouldShowRightCaret is true

But never shows a radio button or checkbox for selection state.