[$250] Onboarding modal not show when the invited member who not complete onboarding login

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.32-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-7800/folder/13176677/41237677/1233303116
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Win 11/Chrome
App Component: Other

Action Performed:

1. Go to OldDot staging.expensify.com > Choose the "Manage expenses for 1-9 employees" option and sign up with a new account
2. Once on NewDot - don't complete the onboarding modal, exit the browser
3. Another account invite the created account to a Collect workspace via OldDot as a member
4. As the invited member again, open staging.new.expensify.com and login

Expected Result:

Verify the onboarding modal shows

Actual Result:

The onboarding modal isn't shown

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7095822_1772819324292.Recording__1879.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @nkdengineer

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022029984185090756051
• Upwork Job ID: 2029984185090756051
• Last Price Increase: 2026-03-24
• Automatic offers:
• aimane-chnaif | Reviewer | 110965806

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user signs up via OldDot, lands on NewDot but exits the browser before completing the onboarding modal, then gets invited to a Collect workspace via OldDot, and logs back into NewDot — the onboarding modal is not shown. It should still appear since the user never completed onboarding.

What is the root cause of that problem?

The OnboardingGuard at App/src/libs/Navigation/guards/OnboardingGuard.ts:165 computes:

const isInvitedOrGroupMember = (!CONFIG.IS_HYBRID_APP && (hasNonPersonalPolicy || wasInvitedToNewDot)) ?? false;

This flag is included in the shouldSkipOnboarding OR-chain at line 174-175:

const shouldSkipOnboarding =
    CONFIG.SKIP_ONBOARDING || context.isLoading || isTransitioning || isOnboardingCompleted || isMigratedUser || isSingleEntry || needsExplanationModal || isInvitedOrGroupMember;

When the user is invited to a Collect workspace via OldDot, the backend sets hasNonPersonalPolicy = true (because the user now belongs to a non-personal policy). This is returned via OpenApp/ReconnectApp and stored in Onyx. On the next NewDot login, isInvitedOrGroupMember evaluates to true, causing shouldSkipOnboarding to be true — even though hasCompletedGuidedSetupFlow is explicitly false (the user started but never completed onboarding).

The isInvitedOrGroupMember condition was designed to skip the onboarding modal for users who were invited to NewDot (they get an alternative invite-specific onboarding via guided setup messages). However, it doesn't distinguish between "invited user who never started onboarding" and "organic user who started onboarding but was later added to a workspace."

What changes do you think we should make in order to solve the problem?

Modify the isInvitedOrGroupMember condition in OnboardingGuard.ts:165 to not skip onboarding when the user has explicitly started but not completed it. Specifically, add a check that hasCompletedGuidedSetupFlow is not explicitly false:

Change:

isInvitedOrGroupMember = (!CONFIG.IS_HYBRID_APP && (hasNonPersonalPolicy || wasInvitedToNewDot)) ?? false

To:

isInvitedOrGroupMember = (!CONFIG.IS_HYBRID_APP && (hasNonPersonalPolicy || wasInvitedToNewDot) && onboarding?.hasCompletedGuidedSetupFlow !== false) ?? false

This ensures:

• If hasCompletedGuidedSetupFlow is false (user started onboarding but didn't finish) → onboarding is still shown regardless of workspace membership
• If hasCompletedGuidedSetupFlow is true → the existing isOnboardingCompleted check handles it
• If hasCompletedGuidedSetupFlow is undefined or NVP_ONBOARDING is empty → hasCompletedGuidedSetupFlowSelector already returns true, so isOnboardingCompleted handles it
• Invited users who never started onboarding still skip the modal (intended behavior)

What alternative solutions did you explore? (Optional)

1. Removing hasNonPersonalPolicy from the isInvitedOrGroupMember check entirely — this would be too aggressive, as it would force onboarding on legitimate invited workspace members who should skip it.
2. Adding a separate isOnboardingExplicitlyStarted flag — functionally equivalent but more verbose. Directly checking onboarding?.hasCompletedGuidedSetupFlow !== false in the existing condition is cleaner.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022029984185090756051

[abbasifaizan70]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Go to OldDot (staging.expensify.com) → choose "Manage expenses for 1-9 employees" and sign up with a new account. Once on NewDot, do not complete the onboarding modal; exit the browser. Another account invites the created account to a Collect workspace via OldDot as a member. As the invited member, open staging.new.expensify.com and log in. The onboarding modal is not shown.

What is the root cause of that problem?

OnboardingGuard skips the onboarding flow for any user who has hasNonPersonalPolicy === true or wasInvitedToNewDot === true. After the user is invited to a workspace, hasNonPersonalPolicy becomes true, so the guard skips onboarding even when the user never completed the guided setup.

App/src/libs/Navigation/guards/OnboardingGuard.ts

Lines 164 to 165 in e26dc41

	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	const isInvitedOrGroupMember = (!CONFIG.IS_HYBRID_APP && (hasNonPersonalPolicy || wasInvitedToNewDot)) ?? false;

// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
const isInvitedOrGroupMember = (!CONFIG.IS_HYBRID_APP && (hasNonPersonalPolicy || wasInvitedToNewDot)) ?? false;

What changes do you think we should make in order to solve the problem?

Only skip onboarding for users with a non-personal policy when they have already completed the guided setup. Users who signed up, left without completing onboarding, and were later invited to a workspace should still see the onboarding modal when they return. Users who joined via an invite link (wasInvitedToNewDot) continue to skip the full flow.

App/src/libs/Navigation/guards/OnboardingGuard.ts

Lines 163 to 165 in e26dc41

	const needsExplanationModal = (CONFIG.IS_HYBRID_APP && tryNewDot?.isHybridAppOnboardingCompleted !== true) ?? false;
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	const isInvitedOrGroupMember = (!CONFIG.IS_HYBRID_APP && (hasNonPersonalPolicy || wasInvitedToNewDot)) ?? false;

        const needsExplanationModal = (CONFIG.IS_HYBRID_APP && tryNewDot?.isHybridAppOnboardingCompleted !== true) ?? false;
        // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
        const isInvitedOrGroupMember = (!CONFIG.IS_HYBRID_APP && (hasNonPersonalPolicy || wasInvitedToNewDot)) ?? false;

        const needsExplanationModal = (CONFIG.IS_HYBRID_APP && tryNewDot?.isHybridAppOnboardingCompleted !== true) ?? false;
        // Skip onboarding for users with a workspace only when they have completed onboarding (so users who signed up,
        // left without completing, then were invited to a workspace still see the onboarding modal when they return).
        // Users who joined via invite link (wasInvitedToNewDot) always skip the full flow.
        // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
        const isInvitedOrGroupMember = (!CONFIG.IS_HYBRID_APP && ((hasNonPersonalPolicy && isOnboardingCompleted) || wasInvitedToNewDot)) ?? false;

[MugheesMb]

🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.

[github-actions]

⚠️ @MugheesMb Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.