[Due for payment 2026-03-18] [$250] Expense - Modal remains open when select Duplicate expense

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.31-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #82005
Email or phone of affected tester (no customers): gocemate+b21549011@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 10/Chrome
App Component: Other

Action Performed:

1. Navigate to https://staging.new.expensify.com/ and log in
2. Create expense to any user
3. Open the expense> More> Duplicate expense

Expected Result:

Modal should close after selection

Actual Result:

Modal remains open

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mallenexpensify

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022029421081061909391
• Upwork Job ID: 2029421081061909391
• Last Price Increase: 2026-03-05

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MobileMage]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user opens an expense, taps "More", and selects "Duplicate expense", the dropdown menu stays open instead of closing after the action fires.

What is the root cause of that problem?

In MoneyRequestHeader.tsx, the shouldCloseModalOnSelect value for the DUPLICATE secondary action is set to true only when one of the blocking error conditions is active (distance expense unsupported, per diem on non-default workspace, or custom unit violation). In the normal flow where none of those conditions apply, the expression evaluates to false.

ButtonWithDropdownMenu passes each menu item's shouldCloseModalOnSelect directly to the PopoverMenu. In ButtonWithDropdownMenu's onItemSelected callback the modal is only hidden when selectedSubitem.shouldCloseModalOnSelect !== false. Since the normal duplicate case produces shouldCloseModalOnSelect: false, the setIsMenuVisible(false) call is skipped and the menu stays open.

App/src/components/MoneyRequestHeader.tsx

Line 537 in 058eee1

shouldCloseModalOnSelect: isDistanceExpenseUnsupportedForDuplicating || hasCustomUnitOutOfPolicyViolation || isPerDiemRequestOnNonDefaultWorkspace,

What changes do you think we should make in order to solve the problem?

The fix is to change shouldCloseModalOnSelect on the DUPLICATE action to true unconditionally. The error-condition branches already return early before reaching the duplicateTransaction call, so there is no need to suppress modal close in the normal path. The same logic applies to MoneyReportHeader.tsx which has an identical pattern.

App/src/components/MoneyReportHeader.tsx

Lines 1540 to 1543 in 058eee1

	shouldCloseModalOnSelect:
	isDistanceExpenseUnsupportedForDuplicating ||
	isPerDiemRequestOnNonDefaultWorkspace ||
	hasCustomUnitOutOfPolicyViolation ||

// src/components/MoneyRequestHeader.tsx
-            shouldCloseModalOnSelect: isDistanceExpenseUnsupportedForDuplicating || hasCustomUnitOutOfPolicyViolation || isPerDiemRequestOnNonDefaultWorkspace,
+            shouldCloseModalOnSelect: true,

// src/components/MoneyReportHeader.tsx
-            shouldCloseModalOnSelect:
-                isDistanceExpenseUnsupportedForDuplicating ||
-                isPerDiemRequestOnNonDefaultWorkspace ||
-                hasCustomUnitOutOfPolicyViolation ||
+            shouldCloseModalOnSelect: true,

The error-condition paths (showConfirmModal calls) return early without calling duplicateTransaction, so closing the dropdown in all paths is correct. The confirm modal that pops up for error states will still open normally after the dropdown closes.

What alternative solutions did you explore? (Optional)

N/A

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user opens an expense, taps "More" and selects "Duplicate expense", the popover/dropdown menu remains open instead of closing.

What is the root cause of that problem?

The shouldCloseModalOnSelect property on the DUPLICATE action is set to the boolean OR of error-condition flags:

In MoneyRequestHeader.tsx:537:

shouldCloseModalOnSelect: isDistanceExpenseUnsupportedForDuplicating || hasCustomUnitOutOfPolicyViolation || isPerDiemRequestOnNonDefaultWorkspace,

In MoneyReportHeader.tsx:1540-1544:

shouldCloseModalOnSelect:
    isDistanceExpenseUnsupportedForDuplicating ||
    isPerDiemRequestOnNonDefaultWorkspace ||
    hasCustomUnitOutOfPolicyViolation ||
    activePolicyExpenseChat?.iouReportID === moneyRequestReport?.reportID,

For a normal expense (no error conditions), all flags are false, so shouldCloseModalOnSelect evaluates to false. This triggers a strict-equality check in PopoverMenu.selectItem() (PopoverMenu.tsx:324):

} else if (selectedItem.shouldCloseModalOnSelect === false) {
    // Calls onSelected directly WITHOUT closing the modal

Additionally, ButtonWithDropdownMenu (index.tsx:272) also skips closing:

if (selectedSubitem.shouldCloseModalOnSelect !== false) {
    setIsMenuVisible(false);
}

So both closing mechanisms are bypassed when shouldCloseModalOnSelect is exactly false. Every other action in the same menu (Hold, Split, Merge, Delete, etc.) does not set shouldCloseModalOnSelect at all — it defaults to undefined, which does not match === false, so those actions properly close the modal via the shouldCallAfterModalHide branch.

The intent of shouldCloseModalOnSelect was to keep the popover open when an error modal needs to display (e.g., unsupported distance expense). But because it's set to the OR of the error booleans, the normal (no-error) case gets false instead of undefined, and false === false triggers the no-close branch.

What changes do you think we should make in order to solve the problem?

Remove the shouldCloseModalOnSelect property from the DUPLICATE action in both MoneyRequestHeader.tsx and MoneyReportHeader.tsx.

When no error conditions apply, the action should use the default closing behavior (like every other action). When error conditions DO apply, the onSelected handler already returns early after showing the error modal — since shouldCallAfterModalHide: true is injected by ButtonWithDropdownMenu, the onSelected callback runs after the popover closes, so the error modals will still display correctly.

What alternative solutions did you explore? (Optional)

An alternative would be to invert the logic so shouldCloseModalOnSelect is explicitly set to true in the normal case and false only when an error modal should be shown (e.g., shouldCloseModalOnSelect: !(isDistanceExpenseUnsupportedForDuplicating || ...)). However, removing the property entirely is simpler and consistent with how every other action in the menu works.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022029421081061909391

[marufsharifi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user selects Duplicate expense from the expense “More” menu, the dropdown remains open instead of closing.

What is the root cause of that problem?

shouldCloseModalOnSelect for the Duplicate action is set to a boolean OR of “error conditions.” In the normal (no-error) path that expression evaluates to false, which explicitly tells PopoverMenu and ButtonWithDropdownMenu not to close the menu. This differs from other actions where the property is omitted and default close behavior runs.

What changes do you think we should make in order to solve the problem?

Keep the intent of the flag (only keep the menu open when an error modal is shown), but invert the boolean so the default path closes the menu. This preserves the original purpose while fixing the normal flow.

// src/components/MoneyRequestHeader.tsx
-            shouldCloseModalOnSelect: isDistanceExpenseUnsupportedForDuplicating || hasCustomUnitOutOfPolicyViolation || isPerDiemRequestOnNonDefaultWorkspace,
+            shouldCloseModalOnSelect: !(isDistanceExpenseUnsupportedForDuplicating || hasCustomUnitOutOfPolicyViolation || isPerDiemRequestOnNonDefaultWorkspace),

// src/components/MoneyReportHeader.tsx
-            shouldCloseModalOnSelect:
-                isDistanceExpenseUnsupportedForDuplicating ||
-                isPerDiemRequestOnNonDefaultWorkspace ||
-                hasCustomUnitOutOfPolicyViolation ||
-                activePolicyExpenseChat?.iouReportID === moneyRequestReport?.reportID,
+            shouldCloseModalOnSelect: !(
+                isDistanceExpenseUnsupportedForDuplicating ||
+                isPerDiemRequestOnNonDefaultWorkspace ||
+                hasCustomUnitOutOfPolicyViolation ||
+                activePolicyExpenseChat?.iouReportID === moneyRequestReport?.reportID
+            ),

What alternative solutions did you explore? (Optional)

1. Remove shouldCloseModalOnSelect entirely for Duplicate so it falls back to default close behavior (consistent with other actions).
2. Set shouldCloseModalOnSelect: true unconditionally for Duplicate (simplest change, but less aligned with the original intent to keep the menu open for error cases).

[yyyhakuna]

Proposal

Problem Analysis

When duplicating an expense, the modal that opens for selecting the duplicate target remains open after selection, requiring manual closure. This breaks the expected UX flow.

Root Cause: After expense duplication is selected and processed, the modal's onDismiss callback isn't being triggered or the modal state isn't being reset.

Solution

1. Find the duplicate expense modal component handler (likely in ExpenseDetailsModal or related component)
2. After successful duplication action, trigger modal dismiss/close
3. Verify modal state is properly reset in the action flow

Implementation Approach

• Locate the duplicate action handler
• Add modal close trigger after duplication completes
• Ensure state management properly reflects modal closure
• Test on staging to confirm modal closes

Expected Changes

• 1-2 files modified (modal logic + action handler)
• ~20-30 lines of code changes
• No breaking changes to other components

Awaiting assignment. Ready to start once assigned on Upwork.