[Due for payment 2026-03-13] [$250] Invoices - Editing amount in offline mode adds a minus sign before the amount in chat view

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.26-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-6479/folder/13176671/41237472/1213506464
Email or phone of affected tester (no customers): emady.syed1234+400@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Windows 11 / Chrome
App Component: Chat Report View

Action Performed:

Precondition : Invoices enabled in workspace and user has already sent few invoices in room

1. Open https://staging.new.expensify.com/
2. Disable internet connection
3. Go to room from precondition
4. Create an invoice
5. Edit invoice > edit amount > save
6. Observe chat view invoice amount

Expected Result:

Invoice amount should not show " - " sign .

Actual Result:

Invoice amount shows " - " sign .

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @joekaufmanexpensify

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022026955392515113090
• Upwork Job ID: 2026955392515113090
• Last Price Increase: 2026-02-26

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MobileMage]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Editing an invoice amount while offline causes the chat view to display the amount with a minus sign (e.g., "-$200.00" instead of "$200.00").

What is the root cause of that problem?

There is a sign convention mismatch between how getUpdatedTransaction stores the modifiedAmount for invoices and how getTransactionDetails later reads it back for display. Invoice transactions store their amount as negative (same convention as expense reports), but when editing, getUpdateMoneyRequestParams sets isFromExpenseReport = isExpenseReport(iouReport) which is false for invoices. This gets passed to getUpdatedTransaction, which then stores modifiedAmount as a positive number (the non-expense path).

App/src/libs/actions/IOU/index.ts

Line 4531 in 24fd24e

const isFromExpenseReport = isExpenseReport(iouReport);

However, when the TransactionPreviewContent renders the amount, it calls getTransactionDetails which computes isFromExpenseReport as isExpenseReport(report) || isPaidGroupPolicyPolicyUtils(policy). Since invoices require a paid group policy, isPaidGroupPolicyPolicyUtils returns true, so the display code treats the transaction as expense-like and negates modifiedAmount -- turning the positive 20000 into -20000 and producing the minus sign in the formatted output.

What changes do you think we should make in order to solve the problem?

The fix is to include invoice reports in the isFromExpenseReport check within getUpdateMoneyRequestParams, so that getUpdatedTransaction stores modifiedAmount with the same negative sign convention that invoice transactions already use for their amount field. This makes the sign consistent with how the display code in getTransactionDetails reads it back, so negating a negative value yields the correct positive display amount.

- const isFromExpenseReport = isExpenseReport(iouReport);
+ const isFromExpenseReport = isExpenseReport(iouReport) || isInvoiceReportReportUtils(iouReport);

This is safe because calculateDiffAmount uses its own independent isExpenseReport check with Math.abs for non-expense reports, so the diff calculation and report total update are unaffected. The API params are also unaffected because getTransactionDetails at line 4542 is called with policy = undefined, so isPaidGroupPolicyPolicyUtils returns false there and Math.abs is used on the amount.

What alternative solutions did you explore? (Optional)

N/A

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invoice amount shows " - " sign .

What is the root cause of that problem?

In offline, the modifiedAmount is only saved with - sign if the transaction comes from an expense report/unreported. For the invoice, it doesn't match any condition above, then the modifiedAmount is saved without - sign. Then the amount is displayed in the preview with - sign.

App/src/libs/TransactionUtils/index.ts

Line 700 in 24fd24e

updatedTransaction.modifiedAmount = isFromExpenseReport || isUnReportedExpense ? -transactionChanges.amount : transactionChanges.amount;

App/src/libs/actions/IOU/index.ts

Line 4531 in 24fd24e

const isFromExpenseReport = isExpenseReport(iouReport);

What changes do you think we should make in order to solve the problem?

We can pass isFromExpenseReport as true here if the policy is a paid group policy

const isFromExpenseReport = isPaidGroupPolicy(policy);

App/src/libs/actions/IOU/index.ts

Line 4531 in 24fd24e

const isFromExpenseReport = isExpenseReport(iouReport);

Or we can add the invoice report check for isFromExpenseReport condition here

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user edits an invoice amount while offline, the chat view displays the amount with a "-" (minus) sign prefix (e.g., "-$150.00" instead of "$150.00"). This only happens during offline editing of invoices.

What is the root cause of that problem?

There is a sign convention mismatch between the write path (when editing the transaction amount) and the read path (when displaying the transaction amount) for invoice transactions.

Invoice transactions store amounts as negative values (same as expense reports) — see App/src/libs/actions/IOU/SendInvoice.ts:635 where amount: amount * -1.

When editing an invoice amount, the isFromExpenseReport flag is determined differently in two places:

1. Write path (App/src/libs/actions/IOU/index.ts:4531): Uses isExpenseReport(iouReport) which returns false for invoices (since invoice report type is 'invoice', not 'expense'). This means getUpdatedTransaction at App/src/libs/TransactionUtils/index.ts:700 stores modifiedAmount as positive (e.g., 15000 for $150).

2. Read path (App/src/libs/ReportUtils.ts:4583): Uses isExpenseReport(report) || isPaidGroupPolicy(policy) which returns true for invoices from Team/Corporate workspaces. This causes getAmount() at App/src/libs/TransactionUtils/index.ts:965-967 to negate the positive modifiedAmount, returning -15000, which then displays as "-$150.00".

So the write path stores modifiedAmount = +15000 (treating invoices as non-expense), but the read path reads it as -15000 (treating invoices as expense-report-like), producing the minus sign.

What changes do you think we should make in order to solve the problem?

In App/src/libs/actions/IOU/index.ts:4531, the isFromExpenseReport determination should also account for invoice reports, so the modifiedAmount is stored with the correct (negative) sign, consistent with how the original invoice transaction amount is stored:

The line const isFromExpenseReport = isExpenseReport(iouReport); should be updated to also check isInvoiceReport(iouReport), so that invoices get the same sign treatment as expense reports during amount editing. This way getUpdatedTransaction will negate the amount (storing modifiedAmount as negative), which will be correctly handled by the read path.

The same pattern is already used at line 4653 of the same file for the report total calculation: if ((isExpenseReport(iouReport) || isInvoiceReportReportUtils(iouReport)) && ...), showing that invoice reports are intentionally treated like expense reports for total calculations.

What alternative solutions did you explore? (Optional)

An alternative would be to change the read path (getTransactionDetails in ReportUtils.ts:4583) to exclude invoice reports from the isPaidGroupPolicy check. However, this is riskier because getTransactionDetails is used widely across the codebase, and the current read-path behavior correctly handles the sign for non-edited invoice transactions (where amount is already negative). The write path fix is more targeted and aligns with the existing pattern at line 4653.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022026955392515113090

[ryntgh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invoices - Editing amount in offline mode adds a minus sign before the amount in chat view

What is the root cause of that problem?

When the policy is a paid group policy, isFromExpenseReport becomes true even for invoice reports. Invoice reports are then treated like expense reports, so amounts are negated and show a minus sign in the chat view.

App/src/libs/ReportUtils.ts

Line 4583 in a152afa

const isFromExpenseReport = (!isEmptyObject(report) && isExpenseReport(report)) || isPaidGroupPolicyPolicyUtils(policy);

What changes do you think we should make in order to solve the problem?

Exclude invoice reports from the expense-report logic so invoice amounts are never negated.

    const isFromExpenseReport = !isInvoiceReport(report) && ((!isEmptyObject(report) && isExpenseReport(report)) || isPaidGroupPolicyPolicyUtils(policy));

App/src/libs/ReportUtils.ts

Line 4583 in a152afa

const isFromExpenseReport = (!isEmptyObject(report) && isExpenseReport(report)) || isPaidGroupPolicyPolicyUtils(policy);

What alternative solutions did you explore? (Optional)

NA