Skip to content

[BT-131] Migrate Reports - Core (Part 3) #83368

Description

@mjasikowski

Description

Current State:

  • 5 report settings routes use backTo parameter
  • These handle report name, notifications, and visibility settings

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (5):

Route Constant Path
REPORT_SETTINGS_NAME r/:reportID/settings/name
REPORT_SETTINGS_NOTIFICATION_PREFERENCES r/:reportID/settings/notification-preferences
REPORT_SETTINGS_WRITE_CAPABILITY r/:reportID/settings/who-can-post
REPORT_SETTINGS_VISIBILITY r/:reportID/settings/visibility
REPORT_CHANGE_APPROVER r/:reportID/change-approver

Usages

REPORT_SETTINGS_NAME:

  • src/pages/ReportDetailsPage.tsx:792

REPORT_SETTINGS_NOTIFICATION_PREFERENCES:

  • Search for usages in report notification settings

REPORT_SETTINGS_WRITE_CAPABILITY:

  • Search for usages in report write settings

REPORT_SETTINGS_VISIBILITY:

  • src/pages/settings/Report/ReportSettingsPage.tsx:106

REPORT_CHANGE_APPROVER:

  • src/pages/ReportAddApproverPage.tsx:131
  • src/components/MoneyReportHeader.tsx:1344

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • REPORT_SETTINGS_NAME
  • REPORT_SETTINGS_NOTIFICATION_PREFERENCES
  • REPORT_SETTINGS_WRITE_CAPABILITY
  • REPORT_SETTINGS_VISIBILITY
  • REPORT_CHANGE_APPROVER
Issue OwnerCurrent Issue Owner: @mallenexpensify

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions