Description
Current State:
- 5 report settings routes use
backTo parameter
- These handle report name, notifications, and visibility settings
Implementation:
- Replace
getRoute(..., backTo) with createDynamicRoute()
- Add source screens to
entryScreens array
- Remove
backTo parameter from route definitions
- Test forward/back navigation
Scope
Routes (5):
| Route Constant |
Path |
REPORT_SETTINGS_NAME |
r/:reportID/settings/name |
REPORT_SETTINGS_NOTIFICATION_PREFERENCES |
r/:reportID/settings/notification-preferences |
REPORT_SETTINGS_WRITE_CAPABILITY |
r/:reportID/settings/who-can-post |
REPORT_SETTINGS_VISIBILITY |
r/:reportID/settings/visibility |
REPORT_CHANGE_APPROVER |
r/:reportID/change-approver |
Usages
REPORT_SETTINGS_NAME:
src/pages/ReportDetailsPage.tsx:792
REPORT_SETTINGS_NOTIFICATION_PREFERENCES:
- Search for usages in report notification settings
REPORT_SETTINGS_WRITE_CAPABILITY:
- Search for usages in report write settings
REPORT_SETTINGS_VISIBILITY:
src/pages/settings/Report/ReportSettingsPage.tsx:106
REPORT_CHANGE_APPROVER:
src/pages/ReportAddApproverPage.tsx:131
src/components/MoneyReportHeader.tsx:1344
Files to modify:
src/ROUTES.ts - Update route definitions
src/libs/Navigation/types.ts - Remove backTo from params
- Components listed above
Migration Progress
Issue Owner
Current Issue Owner: @mallenexpensify
Description
Current State:
backToparameterImplementation:
getRoute(..., backTo)withcreateDynamicRoute()entryScreensarraybackToparameter from route definitionsScope
Routes (5):
REPORT_SETTINGS_NAMEr/:reportID/settings/nameREPORT_SETTINGS_NOTIFICATION_PREFERENCESr/:reportID/settings/notification-preferencesREPORT_SETTINGS_WRITE_CAPABILITYr/:reportID/settings/who-can-postREPORT_SETTINGS_VISIBILITYr/:reportID/settings/visibilityREPORT_CHANGE_APPROVERr/:reportID/change-approverUsages
REPORT_SETTINGS_NAME:src/pages/ReportDetailsPage.tsx:792REPORT_SETTINGS_NOTIFICATION_PREFERENCES:REPORT_SETTINGS_WRITE_CAPABILITY:REPORT_SETTINGS_VISIBILITY:src/pages/settings/Report/ReportSettingsPage.tsx:106REPORT_CHANGE_APPROVER:src/pages/ReportAddApproverPage.tsx:131src/components/MoneyReportHeader.tsx:1344Files to modify:
src/ROUTES.ts- Update route definitionssrc/libs/Navigation/types.ts- RemovebackTofrom paramsMigration Progress
REPORT_SETTINGS_NAMEREPORT_SETTINGS_NOTIFICATION_PREFERENCESREPORT_SETTINGS_WRITE_CAPABILITYREPORT_SETTINGS_VISIBILITYREPORT_CHANGE_APPROVERIssue Owner
Current Issue Owner: @mallenexpensify