Payments - Generic error message appears when deleting bank card

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to new staging.
2. Open the Payment Page from Settings => Payments.
3. Select Delete option for the bank card added

Expected Result:

User is able to delete any payment method

Actual Result:

Error message "oops...something went wrong and your request could not be completed. Please try again later". is displayed when try to delete CC.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: v1.1.46-0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5506623_new_delete.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[bondydaa]

hmm this is probably internal since it seems something changed with the API and is breaking if it's happening on production too.

[aldo-expensify]

Logs for the error: https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%226f1acb5cbd3b2a21-DEN%22)+AND+timestamp:[2022-03-25T20:38:35.681Z+TO+2022-03-25T22:38:35.681Z]&index=logs_expensify-015986

[MariaHCD]

Thanks for finding the logs, @aldo-expensify!

The error 401 Cannot delete billing cards is expected. I think we'll just need to catch the exception on NewDot and show a better error message to the user here. cc: @stitesExpensify

[stitesExpensify]

Yep makes sense to me. Maybe we should make a PR like this that covers all error cases and not just 401?

[MariaHCD]

Thanks, @stitesExpensify! Of the two errors that markAsDeleted throws, I think 401 Cannot delete billing cards is the only one that we should worry about?

Making this a first pick! We'll need to:

1. Get the error message we will show to the user (use the Waiting for copy label)
2. Get the Spanish translation for the message on Slack via #espanol
3. Catch the exception on NewDot here and show the new error message