Skip to content

Update report_updateLastRead to not set the sequenceNumber backwards unless specifically told to by the user #8267

Description

@johnmlee101

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Stale update requests are causing people's messages to be marked as unread on accident. This change will prevent stale requests from doing that, while still letting markAsUnread work as intended

Changes:

  1. Add a new param setByUser
  2. Add a check that prevents the new lastReadSequenceNumber from being less than the previous lastReadSequenceNumber
  3. If setByUser is passed, then we ignore that check and allow it to be set to whatever the user chose

View all open jobs on GitHub

Metadata

Metadata

Labels

EngineeringImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staffNewFeatureSomething to build that is a new item.WeeklyKSv2

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions