[$250] Expensify Cards with a $0 limit in Expensify Classic do not appear in New Expensify

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.19-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @brianlee-expensify
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

Prerequisites:
Have Expensify Cards enabled at the workspace level (must select the workspace to be the "Preferred Workspace" in Expensify Card settings)

Steps to reproduce:

1. Set certain Expensify Cards with a $0 limit or issue a new card to yourself with $0
2. Switch over to New Expensify
3. Click Workspaces > [workspace] > Expensify Card
4. Check to confirm if the Expensify Cards with a $0 limit appear in New Expensify

Expected Result:

Expensify Cards with a $0 limit should still appear in New Expensify, so that admins have the ability to raise the limit back up to reactivate the card in NewDot

Actual Result:

Expensify Cards with a $0 limit do not appear in New Expensify, so admins currently need to go back to OldDot in order to raise the limit back up to reactivate the card in NewDot

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Recording.2393.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mallenexpensify

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022052411493752195343
• Upwork Job ID: 2052411493752195343
• Last Price Increase: 2026-05-07

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[abbasifaizan70]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Cards with a $0 limit should still appear in New Expensify, so that admins have the ability to raise the limit back up to reactivate the card in NewDot.

What is the root cause of that problem?

When an Expensify Card has its limit set to $0, the backend sets the card’s state to STATE_DEACTIVATED (5). In New Expensify, the workspace Expensify Card list is built from WORKSPACE_CARDS_LIST Onyx data that is passed through a selector. That selector uses filterInactiveCards, which in turn calls filterAllInactiveCards. filterAllInactiveCards excludes any card whose state is in the set {CLOSED, STATE_DEACTIVATED, STATE_SUSPENDED}. So cards with $0 limit (state STATE_DEACTIVATED) are removed from the list and never shown on the Workspace Expensify Card page.

App/src/libs/CardUtils.ts

Lines 853 to 862 in ecf5ec4

	function filterAllInactiveCards(cards: CardList | undefined) {
	if (!cards) {
	return {};
	}
	const closedStates = new Set<number>([CONST.EXPENSIFY_CARD.STATE.CLOSED, CONST.EXPENSIFY_CARD.STATE.STATE_DEACTIVATED, CONST.EXPENSIFY_CARD.STATE.STATE_SUSPENDED]);
	const filteredCards = filterObject(cards, (_key, card) => !closedStates.has(card.state));
	return filteredCards;
	}

The workspace Expensify Card page subscribes to the card list with this filter applied:

App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardPage.tsx

Lines 24 to 26 in ecf5ec4

	const [cardSettings] = useOnyx(`${ONYXKEYS.COLLECTION.PRIVATE_EXPENSIFY_CARD_SETTINGS}${defaultFundID}`, {canBeMissing: true});
	const [cardsList] = useOnyx(`${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}${defaultFundID}_${CONST.EXPENSIFY_CARD.BANK}`, {selector: filterInactiveCards, canBeMissing: true});

So any card in closedStates (including $0-limit cards that are STATE_DEACTIVATED) is omitted from cardsList and therefore never rendered.

What changes do you think we should make in order to solve the problem?

Change filterAllInactiveCards so that Expensify Cards in state STATE_DEACTIVATED with an unapproved expense limit of $0 are not filtered out. Those cards will then appear in the workspace Expensify Card list in New Expensify, and admins can raise the limit to reactivate the card without switching to OldDot.

Solution:

File: App/src/libs/CardUtils.ts

 function filterAllInactiveCards(cards: CardList | undefined) {
     if (!cards) {
         return {};
     }

     const closedStates = new Set<number>([CONST.EXPENSIFY_CARD.STATE.CLOSED, CONST.EXPENSIFY_CARD.STATE.STATE_DEACTIVATED, CONST.EXPENSIFY_CARD.STATE.STATE_SUSPENDED]);
-    const filteredCards = filterObject(cards, (_key, card) => !closedStates.has(card.state));
+    const filteredCards = filterObject(cards, (_key, card) => {
+        if (!closedStates.has(card.state)) {
+            return true;
+        }
+        // Show Expensify Cards with $0 limit (STATE_DEACTIVATED) so admins can raise the limit in NewDot
+        return (
+            card.state === CONST.EXPENSIFY_CARD.STATE.STATE_DEACTIVATED &&
+            card.bank === CONST.EXPENSIFY_CARD.BANK &&
+            (card.nameValuePairs?.unapprovedExpenseLimit ?? 0) === 0
+        );
+    });

     return filteredCards;
 }

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Cards with a $0 limit in Expensify Classic do not appear in New Expensify

What is the root cause of that problem?

filterInactiveCards calls filterAllInactiveCards which filters out cards in states: CLOSED (6), STATE_DEACTIVATED (5), STATE_SUSPENDED (7)

When a card has a $0 limit, its state is STATE_DEACTIVATED (5) --> This causes the card to be filtered out

App/src/libs/CardUtils.ts

Lines 796 to 815 in eda9a19

	function filterAllInactiveCards(cards: CardList | undefined) {
	if (!cards) {
	return {};
	}
	const closedStates = new Set<number>([CONST.EXPENSIFY_CARD.STATE.CLOSED, CONST.EXPENSIFY_CARD.STATE.STATE_DEACTIVATED, CONST.EXPENSIFY_CARD.STATE.STATE_SUSPENDED]);
	const filteredCards = filterObject(cards, (_key, card) => !closedStates.has(card.state));
	return filteredCards;
	}
	function filterInactiveCards(cardsList: WorkspaceCardsList | undefined) {
	const {cardList, ...assignedCards} = cardsList ?? {};
	const filteredAssignedCards = filterAllInactiveCards(assignedCards);
	return {
	...(cardList ? {cardList} : {}),
	...filteredAssignedCards,
	} as WorkspaceCardsList;
	}

What changes do you think we should make in order to solve the problem?

We should remove STATE_DEACTIVATED from the closed states filter.

App/src/libs/CardUtils.ts

Line 801 in eda9a19

const closedStates = new Set<number>([CONST.EXPENSIFY_CARD.STATE.CLOSED, CONST.EXPENSIFY_CARD.STATE.STATE_DEACTIVATED, CONST.EXPENSIFY_CARD.STATE.STATE_SUSPENDED]);

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[HiepPP]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Cards with a $0 limit set in Expensify Classic don't appear in New Expensify's workspace card list. Admins can't raise the limit to reactivate them.

What is the root cause of that problem?

The workspace card management pages (list, details, edit limit, edit name, edit limit type) all use filterInactiveCards as their Onyx selector. This selector calls filterAllInactiveCards, which filters out cards in states CLOSED, STATE_DEACTIVATED, and STATE_SUSPENDED:

App/src/libs/CardUtils.ts

Lines 853 to 872 in c029b13

	function filterAllInactiveCards(cards: CardList | undefined) {
	if (!cards) {
	return {};
	}
	const closedStates = new Set<number>([CONST.EXPENSIFY_CARD.STATE.CLOSED, CONST.EXPENSIFY_CARD.STATE.STATE_DEACTIVATED, CONST.EXPENSIFY_CARD.STATE.STATE_SUSPENDED]);
	const filteredCards = filterObject(cards, (_key, card) => !closedStates.has(card.state));
	return filteredCards;
	}
	function filterInactiveCards(cardsList: WorkspaceCardsList | undefined) {
	const {cardList, ...assignedCards} = cardsList ?? {};
	const filteredAssignedCards = filterAllInactiveCards(assignedCards);
	return {
	...(cardList ? {cardList} : {}),
	...filteredAssignedCards,
	} as WorkspaceCardsList;
	}

When a card's limit is $0, the backend sets its state to STATE_DEACTIVATED (5). The workspace pages use the same filter as non-admin views, so deactivated cards disappear from admin management entirely — including from the card details page (which returns NotFoundPage):

App/src/pages/workspace/expensifyCard/WorkspaceExpensifyCardDetailsPage.tsx

Lines 68 to 101 in c029b13

	const workspaceCards = getAllCardsForWorkspace(defaultFundID, allFeedsCards, cardFeeds, expensifyCardSettings);
	const isWorkspaceCardRhp = route.name === SCREENS.WORKSPACE.EXPENSIFY_CARD_DETAILS;
	const card = workspaceCards?.[cardID];
	const currency = useCurrencyForExpensifyCard({policyID});
	const cardholder = personalDetails?.[card?.accountID ?? CONST.DEFAULT_NUMBER_ID];
	const isVirtual = !!card?.nameValuePairs?.isVirtual;
	const formattedAvailableSpendAmount = convertToDisplayString(card?.availableSpend, currency);
	const formattedLimit = convertToDisplayString(card?.nameValuePairs?.unapprovedExpenseLimit, currency);
	const displayName = getDisplayNameOrDefault(cardholder);
	const translationForLimitType = getTranslationKeyForLimitType(card?.nameValuePairs?.limitType);
	const shouldGoBack = useRef(false);
	const fetchCardDetails = useCallback(() => {
	openCardDetailsPage(Number(cardID));
	}, [cardID]);
	const {isOffline} = useNetwork({onReconnect: fetchCardDetails});
	useEffect(() => fetchCardDetails(), [fetchCardDetails]);
	const deactivateCard = () => {
	setIsDeactivateModalVisible(false);
	shouldGoBack.current = true;
	// eslint-disable-next-line @typescript-eslint/no-deprecated
	InteractionManager.runAfterInteractions(() => {
	deactivateCardAction(defaultFundID, card);
	});
	};
	if (!card && !isLoadingOnyxValue(allFeedsCardsResult)) {
	return <NotFoundPage />;
	}

A secondary issue exists in isCardActive within ReportActionsUtils, which uses the same state grouping. This causes getCardIssuedMessage to render card-issued/replaced messages as plain text instead of clickable links for deactivated cards:

App/src/libs/ReportActionsUtils.ts

Lines 3985 to 4018 in c029b13

	function isCardActive(card?: Card): boolean {
	if (!card) {
	return false;
	}
	const closedStates = new Set<number>([CONST.EXPENSIFY_CARD.STATE.CLOSED, CONST.EXPENSIFY_CARD.STATE.STATE_DEACTIVATED, CONST.EXPENSIFY_CARD.STATE.STATE_SUSPENDED]);
	return !closedStates.has(card.state);
	}
	function getCardIssuedMessage({
	reportAction,
	shouldRenderHTML = false,
	shouldNavigateToCardDetails = false,
	policyID = '-1',
	expensifyCard,
	companyCard,
	translate,
	}: {
	reportAction: OnyxEntry<ReportAction>;
	shouldRenderHTML?: boolean;
	shouldNavigateToCardDetails?: boolean;
	policyID?: string;
	expensifyCard?: Card;
	companyCard?: Card;
	translate: LocaleContextProps['translate'];
	}) {
	const cardIssuedActionOriginalMessage = isCardIssuedAction(reportAction) ? getOriginalMessage(reportAction) : undefined;
	const assigneeAccountID = cardIssuedActionOriginalMessage?.assigneeAccountID ?? CONST.DEFAULT_NUMBER_ID;
	const cardID = cardIssuedActionOriginalMessage?.cardID ?? CONST.DEFAULT_NUMBER_ID;
	const assignee = shouldRenderHTML ? `<mention-user accountID="${assigneeAccountID}"/>` : Parser.htmlToText(`<mention-user accountID="${assigneeAccountID}"/>`);
	const navigateRoute = shouldNavigateToCardDetails ? ROUTES.EXPENSIFY_CARD_DETAILS.getRoute(policyID, String(cardID)) : ROUTES.SETTINGS_DOMAIN_CARD_DETAIL.getRoute(String(cardID));
	const isExpensifyCardActive = isCardActive(expensifyCard);
	const expensifyCardLink = (expensifyCardLinkText: string) =>
	shouldRenderHTML && isExpensifyCardActive ? `<a href='${environmentURL}/${navigateRoute}'>${expensifyCardLinkText}</a>` : expensifyCardLinkText;

What changes do you think we should make in order to solve the problem?

Add an includeDeactivated parameter to filterAllInactiveCards and create a new filterInactiveCardsIncludingDeactivated selector for workspace admin pages. This keeps the default filter behavior unchanged for all other consumers.

src/libs/CardUtils.ts — parameterize filterAllInactiveCards and add admin selector:

function filterAllInactiveCards(
  cards: CardList | undefined,
  includeDeactivated = false,
) {
  if (!cards) {
    return {};
  }
  const closedStates = new Set<number>([
    CONST.EXPENSIFY_CARD.STATE.CLOSED,
    CONST.EXPENSIFY_CARD.STATE.STATE_DEACTIVATED,
    CONST.EXPENSIFY_CARD.STATE.STATE_SUSPENDED,
  ]);
  if (includeDeactivated) {
    closedStates.delete(CONST.EXPENSIFY_CARD.STATE.STATE_DEACTIVATED);
  }
  const filteredCards = filterObject(
    cards,
    (_key, card) => !closedStates.has(card.state),
  );
  return filteredCards;
}

// New selector for workspace admin pages
function filterInactiveCardsIncludingDeactivated(
  cardsList: WorkspaceCardsList | undefined,
) {
  const { cardList, ...assignedCards } = cardsList ?? {};
  const filteredAssignedCards = filterAllInactiveCards(assignedCards, true);
  return {
    ...(cardList ? { cardList } : {}),
    ...filteredAssignedCards,
  } as WorkspaceCardsList;
}

Switch workspace Expensify Card pages to the new selector:

src/pages/workspace/expensifyCard/WorkspaceExpensifyCardPage.tsx

// Replace filterInactiveCards with filterInactiveCardsIncludingDeactivated
const [cardsList] = useOnyx(`...`, {
  selector: filterInactiveCardsIncludingDeactivated,
  canBeMissing: true,
});

Same change in WorkspaceEditCardLimitPage.tsx, WorkspaceEditCardNamePage.tsx, and WorkspaceEditCardLimitTypePage.tsx.

Pass includeDeactivated in the details page:

src/pages/workspace/expensifyCard/WorkspaceExpensifyCardDetailsPage.tsx

const workspaceCards = getAllCardsForWorkspace(
  defaultFundID,
  allFeedsCards,
  cardFeeds,
  expensifyCardSettings,
  true,
);

Fix isCardActive in ReportActionsUtils.ts to not treat deactivated cards as closed:

const closedStates = new Set<number>([
  CONST.EXPENSIFY_CARD.STATE.CLOSED,
  CONST.EXPENSIFY_CARD.STATE.STATE_SUSPENDED,
]);

What alternative solutions did you explore? (Optional)

Considered removing STATE_DEACTIVATED from closedStates globally, but that changes the filter behavior for every consumer — including non-admin views like WorkspaceOverviewPage, WorkspacesListPage, useCardsList, and cardFeedErrors — which may not want to show deactivated cards. The parameterized approach is safer since it only changes behavior for workspace card management pages where admins need to see and manage these cards.

[github-actions]

⚠️ @HiepPP Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.