[$250] [Due for payment 2026-03-02] Workspace settings - Workspace member still appear in Workflow approvals when remove member offline

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.11-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @paulnjs
Slack conversation (hyperlinked to channel name): expensify_open_source

Action Performed:

1. Launch the app

2. Create a new WorkSpace
3. Invite a new member
4. Turn on offline mode
5. Select member just created and remove from workspace
6. Open Workflow > “Add approval workflow” and observe the list approval member

Expected Result:

The member is removed when app offline shouldn’t be appear in the approval list

Actual Result:

The member is removed when app offline still appear in the approval list

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Recording.3590.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @joekaufmanexpensify

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022028545308714016702
• Upwork Job ID: 2028545308714016702
• Last Price Increase: 2026-03-02

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[paulnjs]

🚨 Edited by proposal-police: This proposal was edited at 2026-01-29 08:45:48 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a member is deleted offline, they still appeared in Workflow approvals

What is the root cause of that problem?

the convertPolicyEmployeesToApprovalWorkflows function builds the availableMembers list from policy.employeeList, but it does NOT filter out employees with pendingAction === DELETE.

App/src/libs/WorkflowUtils.ts

Lines 119 to 123 in 87e6d66

	for (const employee of Object.values(employees)) {
	const {email, submitsTo, pendingAction} = employee;
	if (!email || !submitsTo || !employees[submitsTo]) {
	continue;
	}

What changes do you think we should make in order to solve the problem?

Added a check at convertPolicyEmployeesToApprovalWorkflows to skip employees with pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE:

App/src/libs/WorkflowUtils.ts

Line 121 in 87e6d66

if (!email || !submitsTo || !employees[submitsTo]) {

We should do the same with pages that have the same issue.

What alternative solutions did you explore? (Optional)

N/A

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[mobile84developer-ctrl]

🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.

[github-actions]

⚠️ @mobile84developer-ctrl Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.

[mobile84developer-ctrl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a workspace member is removed while the app is offline, that member still appears in the approval member list when creating or editing an approval workflow.

What is the root cause of that problem?

Offline member removal sets pendingAction: DELETE on the employee in policy.employeeList, but convertPolicyEmployeesToApprovalWorkflows still adds those employees to the members array of workflows.
As a result, members pending deletion are treated as selectable approval members, which is incorrect.

What changes do you think we should make in order to solve the problem?

In App/src/libs/WorkflowUtils.ts

While constructing workflow members, skip employees pending DELETE.

Replace

App/src/libs/WorkflowUtils.ts

Line 153 in 87e6d66

approvalWorkflows[submitsTo].members.push(member);

with

if (employee.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) {
    approvalWorkflows[submitsTo].members.push(member);
}

Resolved.80866.webm

What alternative solutions did you explore? (Optional)

Filtering DELETE employees earlier during workflow construction was considered, but rejected because it could break offline workflow state and existing DELETE handling logic.

[abbasifaizan70]

🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.

[github-actions]

⚠️ @abbasifaizan70 Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.