[Due for payment 2026-03-02] [$250] Domain admins - "Hidden" is shown for member invited to Domain admins page while offline

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.6-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to validate in Prod - Provide reasoning.
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-3235/folder/31025987/72292684/1141127464?sort=-identifier
Email or phone of affected tester (no customers): admin@expplause.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Macbook Pro 2023 / Sequoia 15.2
App Component: Workspace Settings

Action Performed:

Precond: User is signed into admin@expplause.com account

1. Access www.staging.new.expensify.com
2. Go to WS > Verified Domain > Domain Admins
3. Go offline and add any new admin

Expected Result:

User expects to see the email that is invited even while offline

Actual Result:

Hidden is shown instead while offline

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022014682372867206141
• Upwork Job ID: 2014682372867206141
• Last Price Increase: 2026-01-23
• Automatic offers:
• situchan | Contributor | 110219276

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When adding a new domain admin while offline, the admin list shows "Hidden" instead of the email address that was entered. The email should be visible even while offline.

What is the root cause of that problem?

In addAdminToDomain function, only the admin's accountID is added to the domain optimistically, but NO optimistic personal details are added for the new admin:

App/src/libs/actions/Domain.ts

Lines 530 to 563 in c9e36d3

	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.DOMAIN}${domainAccountID}`,
	value: {
	[PERMISSION_KEY]: accountID,
	} as PrefixedRecord<typeof CONST.DOMAIN.EXPENSIFY_ADMIN_ACCESS_PREFIX, number>,
	},
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.DOMAIN_PENDING_ACTIONS}${domainAccountID}`,
	value: {
	admin: {
	[accountID]: {
	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	},
	},
	},
	},
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.DOMAIN_ERRORS}${domainAccountID}`,
	value: {
	adminErrors: {
	[accountID]: {
	errors: null,
	},
	},
	},
	},
	];
	const successData: OnyxUpdate[] = [
	{
	onyxMethod: Onyx.METHOD.MERGE,

When BaseDomainMembersPage renders the admin list, it looks up personal details:

App/src/pages/domain/BaseDomainMembersPage.tsx

Lines 85 to 96 in c9e36d3

	const data: MemberOption[] = accountIDs.map((accountID) => {
	const details = personalDetails?.[accountID];
	const login = details?.login ?? '';
	const customProps = getCustomRowProps?.(accountID);
	const isPendingActionDelete = customProps?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE;
	return {
	keyForList: String(accountID),
	accountID,
	login,
	text: formatPhoneNumber(getDisplayNameOrDefault(details)),
	alternateText: formatPhoneNumber(login),

Since personalDetails?.[accountID] is undefined for the newly added admin, getDisplayNameOrDefault(undefined) returns "Hidden" (the fallback translation).

What changes do you think we should make in order to solve the problem?

Add optimistic personal details in addAdminToDomain function in src/libs/actions/Domain.ts:

function addAdminToDomain(domainAccountID: number, accountID: number, targetEmail: string, domainName: string) {
    const PERMISSION_KEY = `${CONST.DOMAIN.EXPENSIFY_ADMIN_ACCESS_PREFIX}${accountID}`;

    const optimisticData: OnyxUpdate[] = [
        // ... existing domain and pending action updates
        
        // Add optimistic personal details for the new admin
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: ONYXKEYS.PERSONAL_DETAILS_LIST,
            value: {
                [accountID]: {
                    accountID,
                    login: targetEmail,
                    displayName: targetEmail,
                    isOptimisticPersonalDetail: true,
                },
            },
        },
    ];

   // reset in `successData` and `failureData`
}

This follows the same pattern used in Report.ts when adding participants to a chat:

App/src/libs/actions/Report.ts

Lines 1241 to 1257 in c9e36d3

	},
	},
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_METADATA}${reportID}`,
	value: {
	isOptimisticReport: false,
	},
	},
	);
	optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: ONYXKEYS.PERSONAL_DETAILS_LIST,
	value: optimisticPersonalDetails,
	});
	failureData.push({

What alternative solutions did you explore? (Optional)

[annaweber830]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On the Verified Domain → Domain Admins page, when a user goes offline and invites a new domain admin, the new row shows “Hidden” instead of showing the invited email/login.

What is the root cause of that problem?

The Domain Admins list renders each row using data from ONYXKEYS.PERSONAL_DETAILS_LIST.
When inviting a domain admin offline, we optimistically add the invited user’s accountID to the domain admin list, but we don’t create an optimistic personal-details entry for that accountID. With no login/displayName available, getDisplayNameOrDefault() falls back to the localized “Hidden” string.

What changes do you think we should make in order to solve the problem?

• When we optimistically invite a domain admin (offline-capable flow), also optimistically MERGE a minimal personal-details record into ONYXKEYS.PERSONAL_DETAILS_LIST for the invited accountID using the invited email as login/displayName (and a default avatar).
• Clean up that optimistic personal detail entry on both success and failure so it doesn’t persist after the request resolves.
  

  App/src/libs/actions/Domain.ts

  Lines 530 to 624 in e54cfd4

  	function addAdminToDomain(domainAccountID: number, accountID: number, targetEmail: string, domainName: string) {
  	const PERMISSION_KEY = `${CONST.DOMAIN.EXPENSIFY_ADMIN_ACCESS_PREFIX}${accountID}`;
  	const optimisticData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.DOMAIN | typeof ONYXKEYS.COLLECTION.DOMAIN_PENDING_ACTIONS | typeof ONYXKEYS.COLLECTION.DOMAIN_ERRORS>> = [
  	{
  	onyxMethod: Onyx.METHOD.MERGE,
  	key: `${ONYXKEYS.COLLECTION.DOMAIN}${domainAccountID}`,
  	value: {
  	[PERMISSION_KEY]: accountID,
  	} as PrefixedRecord<typeof CONST.DOMAIN.EXPENSIFY_ADMIN_ACCESS_PREFIX, number>,
  	},
  	{
  	onyxMethod: Onyx.METHOD.MERGE,
  	key: `${ONYXKEYS.COLLECTION.DOMAIN_PENDING_ACTIONS}${domainAccountID}`,
  	value: {
  	admin: {
  	[accountID]: {
  	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
  	},
  	},
  	},
  	},
  	{
  	onyxMethod: Onyx.METHOD.MERGE,
  	key: `${ONYXKEYS.COLLECTION.DOMAIN_ERRORS}${domainAccountID}`,
  	value: {
  	adminErrors: {
  	[accountID]: {
  	errors: null,
  	},
  	},
  	},
  	},
  	];
  	const successData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.DOMAIN | typeof ONYXKEYS.COLLECTION.DOMAIN_PENDING_ACTIONS | typeof ONYXKEYS.COLLECTION.DOMAIN_ERRORS>> = [
  	{
  	onyxMethod: Onyx.METHOD.MERGE,
  	key: `${ONYXKEYS.COLLECTION.DOMAIN}${domainAccountID}`,
  	value: {
  	[PERMISSION_KEY]: null,
  	},
  	},
  	{
  	onyxMethod: Onyx.METHOD.MERGE,
  	key: `${ONYXKEYS.COLLECTION.DOMAIN_ERRORS}${domainAccountID}`,
  	value: {
  	adminErrors: {
  	[accountID]: {
  	errors: null,
  	},
  	},
  	},
  	},
  	{
  	onyxMethod: Onyx.METHOD.MERGE,
  	key: `${ONYXKEYS.COLLECTION.DOMAIN_PENDING_ACTIONS}${domainAccountID}`,
  	value: {
  	admin: {
  	[accountID]: null,
  	},
  	},
  	},
  	];
  	const failureData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.DOMAIN_PENDING_ACTIONS | typeof ONYXKEYS.COLLECTION.DOMAIN_ERRORS>> = [
  	{
  	onyxMethod: Onyx.METHOD.MERGE,
  	key: `${ONYXKEYS.COLLECTION.DOMAIN_ERRORS}${domainAccountID}`,
  	value: {
  	adminErrors: {
  	[accountID]: {
  	errors: getMicroSecondOnyxErrorWithTranslationKey('domain.admins.addAdminError'),
  	},
  	},
  	},
  	},
  	{
  	onyxMethod: Onyx.METHOD.MERGE,
  	key: `${ONYXKEYS.COLLECTION.DOMAIN_PENDING_ACTIONS}${domainAccountID}`,
  	value: {
  	admin: {
  	[accountID]: null,
  	},
  	},
  	},
  	];
  	const params: AddAdminToDomainParams = {
  	domainName,
  	targetEmail,
  	};
  	API.write(WRITE_COMMANDS.ADD_DOMAIN_ADMIN, params, {optimisticData, successData, failureData});
  	}

function addAdminToDomain(domainAccountID: number, accountID: number, targetEmail: string, domainName: string) {
    const PERMISSION_KEY = `${CONST.DOMAIN.EXPENSIFY_ADMIN_ACCESS_PREFIX}${accountID}`;
    const shouldCreateOptimisticPersonalDetail = !getLoginByAccountID(accountID);

    const optimisticData: OnyxUpdate[] = [
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.DOMAIN}${domainAccountID}`,
            value: {
                [PERMISSION_KEY]: accountID,
            } as PrefixedRecord<typeof CONST.DOMAIN.EXPENSIFY_ADMIN_ACCESS_PREFIX, number>,
        },
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.DOMAIN_PENDING_ACTIONS}${domainAccountID}`,
            value: {
                admin: {
                    [accountID]: {
                        pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
                    },
                },
            },
        },
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.DOMAIN_ERRORS}${domainAccountID}`,
            value: {
                adminErrors: {
                    [accountID]: {
                        errors: null,
                    },
                },
            },
        },
    ];

    if (shouldCreateOptimisticPersonalDetail) {
        optimisticData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: ONYXKEYS.PERSONAL_DETAILS_LIST,
            value: {
                [accountID]: {
                    accountID,
                    login: targetEmail,
                    displayName: targetEmail,
                    avatar: getDefaultAvatarURL({accountID, accountEmail: targetEmail}),
                    isOptimisticPersonalDetail: true,
                },
            },
        });
    }

    const successData: OnyxUpdate[] = [
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.DOMAIN}${domainAccountID}`,
            value: {
                [PERMISSION_KEY]: null,
            },
        },
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.DOMAIN_ERRORS}${domainAccountID}`,
            value: {
                adminErrors: {
                    [accountID]: {
                        errors: null,
                    },
                },
            },
        },
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.DOMAIN_PENDING_ACTIONS}${domainAccountID}`,
            value: {
                admin: {
                    [accountID]: null,
                },
            },
        },
    ];

    if (shouldCreateOptimisticPersonalDetail) {
        successData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: ONYXKEYS.PERSONAL_DETAILS_LIST,
            value: {
                [accountID]: null,
            },
        });
    }

    const failureData: OnyxUpdate[] = [
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.DOMAIN_ERRORS}${domainAccountID}`,
            value: {
                adminErrors: {
                    [accountID]: {
                        errors: getMicroSecondOnyxErrorWithTranslationKey('domain.admins.addAdminError'),
                    },
                },
            },
        },
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.DOMAIN_PENDING_ACTIONS}${domainAccountID}`,
            value: {
                admin: {
                    [accountID]: null,
                },
            },
        },
    ];

    if (shouldCreateOptimisticPersonalDetail) {
        failureData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: ONYXKEYS.PERSONAL_DETAILS_LIST,
            value: {
                [accountID]: null,
            },
        });
    }

    const params: AddAdminToDomainParams = {
        domainName,
        targetEmail,
    };

    API.write(WRITE_COMMANDS.ADD_DOMAIN_ADMIN, params, {optimisticData, successData, failureData});
}

What alternative solutions did you explore? (Optional)

We already have isOptimisticAccount flag in currentlySelectedUser so we can reuse that.

App/src/pages/domain/Admins/DomainAddAdminPage.tsx

Line 76 in f251b86

addAdminToDomain(domainAccountID, currentlySelectedUser.accountID, currentlySelectedUser.login, domainName);

addAdminToDomain(domainAccountID, currentlySelectedUser.accountID, currentlySelectedUser.login, domainName, currentlySelectedUser.isOptimisticAccount);

    if (isOptimisticAccount) {
        optimisticData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: ONYXKEYS.PERSONAL_DETAILS_LIST,
            value: {
                [accountID]: {
                    accountID,
                    login: targetEmail,
                    displayName: targetEmail,
                    isOptimisticPersonalDetail: true,
                },
            },
        });
    }

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hidden is shown instead while offline

What is the root cause of that problem?

When the admin is the user that the current user doesn't have personal detail data, we don't add the optimistic personal detail in offline

App/src/libs/actions/Domain.ts

Lines 530 to 563 in c9e36d3

	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.DOMAIN}${domainAccountID}`,
	value: {
	[PERMISSION_KEY]: accountID,
	} as PrefixedRecord<typeof CONST.DOMAIN.EXPENSIFY_ADMIN_ACCESS_PREFIX, number>,
	},
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.DOMAIN_PENDING_ACTIONS}${domainAccountID}`,
	value: {
	admin: {
	[accountID]: {
	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	},
	},
	},
	},
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.DOMAIN_ERRORS}${domainAccountID}`,
	value: {
	adminErrors: {
	[accountID]: {
	errors: null,
	},
	},
	},
	},
	];
	const successData: OnyxUpdate[] = [
	{
	onyxMethod: Onyx.METHOD.MERGE,

Then it's displayed as Hidden because details is undefined.

App/src/pages/domain/BaseDomainMembersPage.tsx

Lines 85 to 96 in c9e36d3

	const data: MemberOption[] = accountIDs.map((accountID) => {
	const details = personalDetails?.[accountID];
	const login = details?.login ?? '';
	const customProps = getCustomRowProps?.(accountID);
	const isPendingActionDelete = customProps?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE;
	return {
	keyForList: String(accountID),
	accountID,
	login,
	text: formatPhoneNumber(getDisplayNameOrDefault(details)),
	alternateText: formatPhoneNumber(login),

What changes do you think we should make in order to solve the problem?

Add the optimistic personal detail in optimistic data if we don't have the personal detail of the new admin. Clear the optimistic personal detail in success data and failure data since the backend will return the current personal detail of the new admin

To check if the admin is an optimistic account or not, we need to pass personalDetails to addAdminToDomain function. Another note is that we shouldn't add the avatar to the optimistic personal detail because we want to show the default avatar for unknow user

function addAdminToDomain(domainAccountID: number, accountID: number, targetEmail: string, domainName: string, personalDetails: OnyxEntry<PersonalDetailsList>) {
...
if (!personalDetails?.[accountID]) {

        optimisticData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: ONYXKEYS.PERSONAL_DETAILS_LIST,
            value: {
                [accountID]: {
                    accountID,
                    login: targetEmail,
                    displayName: targetEmail,
                    isOptimisticPersonalDetail: true,
                },
            },
        });

        successData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: ONYXKEYS.PERSONAL_DETAILS_LIST,
            value: {
                [accountID]: null,
            },
        });

        failureData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: ONYXKEYS.PERSONAL_DETAILS_LIST,
            value: {
                [accountID]: null,
            },
        });
    }

App/src/libs/actions/Domain.ts

Lines 530 to 563 in c9e36d3

	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.DOMAIN}${domainAccountID}`,
	value: {
	[PERMISSION_KEY]: accountID,
	} as PrefixedRecord<typeof CONST.DOMAIN.EXPENSIFY_ADMIN_ACCESS_PREFIX, number>,
	},
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.DOMAIN_PENDING_ACTIONS}${domainAccountID}`,
	value: {
	admin: {
	[accountID]: {
	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	},
	},
	},
	},
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.DOMAIN_ERRORS}${domainAccountID}`,
	value: {
	adminErrors: {
	[accountID]: {
	errors: null,
	},
	},
	},
	},
	];
	const successData: OnyxUpdate[] = [
	{
	onyxMethod: Onyx.METHOD.MERGE,

const personalDetails = usePersonalDetails();
addAdminToDomain(domainAccountID, currentlySelectedUser.accountID, currentlySelectedUser.login, domainName, personalDetails);

App/src/pages/domain/Admins/DomainAddAdminPage.tsx

Line 76 in c9e36d3

addAdminToDomain(domainAccountID, currentlySelectedUser.accountID, currentlySelectedUser.login, domainName);

What alternative solutions did you explore? (Optional)

N/A

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022014682372867206141

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[situchan]

cc: @sumo-slonik @war-in

@mountiny should we handle this as part of project or let contributors fix?

[war-in]

I'd pass it to contributors and @daledah's solution looks pretty solid