[Time Tracking][Create] Fix bug with time expenses

[grgia]

#78137 (comment)

Clear the cache to reset transaction draft
Go to workspace chat
Create time expense but in the confirmation page clicking the outside modal to close
Create time expense again

Screen.Recording.2026-01-13.at.12.09.17.mov

After a quick check, I found that resetIOUTypeIfChanged is called in IOURequestStartPage.tsx after the count is set, which resets the transaction data

Screen.Recording.2026-01-13.at.18.30.10.mov

[mhawryluk]

can't reproduce, but I think what's most likely is that the bug appears when the onyx update in removeDraftTransactions (invoked indirectly by startMoneyRequest) executes after the draft is created by resetIOUTypeIfChanged in useFocusEffect

[DylanDylann]

I will sleep on it to find the RCA in the end of week

[DylanDylann]

@grgia @mhawryluk The RCA: isLoadingTransaction is true so resetIOUTypeIfChanged isn't triggered. It's so weird when isLoadingTransaction isn't updated to false after the transaction is loaded.

App/src/pages/iou/request/IOURequestStartPage.tsx

Lines 207 to 220 in 6de0da7

	useFocusEffect(
	useCallback(() => {
	// The test transaction can change the reportID of the transaction on the flow so we should prevent the reportID from being reverted again.
	if (
	transaction?.reportID === reportID ||
	isLoadingTransaction ||
	isLoadingSelectedTab ||
	!transactionRequestType ||
	prevTransactionReportID !== transaction?.reportID ||
	!personalPolicy?.id
	) {
	return;
	}
	resetIOUTypeIfChanged(transactionRequestType);

But the bug is gone after I reset the node module, I think this bug appear because I used an outdated react-native-onyx version.

I think we can close this one.

[mhawryluk]

awesome, thanks for investigating!

[trjExpensify]

@grgia if you agree, let's close.