[PAY][$250] Multi scan - After replacing receipt, other receipt disappears, or confirm page becomes broken

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.99-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #69326
Email or phone of affected tester (no customers): sdjkdsnsndoisjoidsjdoi@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Click + > Create expense > Scan.
4. Upload two receipts.
5. On confirm page, click on the receipt.
6. Click 3-dot menu > Replace.
7. Replace the receipt.
   BUG 1: The second receipt disappears after replacing the first receipt.
8. Close the RHP.
9. Click + > Create expense > Scan.
10. Upload two receipts.
11. On confirm page, click next arrow on the top right to navigate to the second receipt.
12. Click on the receipt.
13. Click 3-dot menu > Replace.
14. Replace the receipt.
    BUG 2: To field disappears. Amount field changes to 0.00.

Expected Result:

BUG 1: After replacing the first receipt, the second receipt should remain unaffected.
BUG 2: After replacing the second receipt, To field will not disappear. Amount field will not show up because this is a scan expense.

Actual Result:

BUG 1: The second receipt disappears after replacing the first receipt.
BUG 2: After replacing the second receipt, To field disappears, Amount field changes to 0.00.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7045963_1768150536081.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022010878582663122873
• Upwork Job ID: 2010878582663122873
• Last Price Increase: 2026-01-13

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

When we edit the receipt, if the multi scan is not enabled, then it will clear all the previous drafts before setting a new one.

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Lines 652 to 669 in 4c05547

	if (!isMultiScanEnabled) {
	removeDraftTransactions(true);
	}
	for (const [index, file] of files.entries()) {
	const source = URL.createObjectURL(file as Blob);
	const transaction = shouldReuseInitialTransaction(initialTransaction, shouldAcceptMultipleFiles, index, isMultiScanEnabled, transactions)
	? (initialTransaction as Partial<Transaction>)
	: buildOptimisticTransactionAndCreateDraft({
	initialTransaction: initialTransaction as Partial<Transaction>,
	currentUserPersonalDetails,
	reportID,
	});
	const transactionID = transaction.transactionID ?? initialTransactionID;
	newReceiptFiles.push({file, source, transactionID});
	setMoneyRequestReceipt(transactionID, source, file.name ?? '', true, file.type);
	}

On the start page, we pass the props based on the transaction drafts length.

App/src/pages/iou/request/IOURequestStartPage.tsx

Lines 279 to 286 in 4c05547

	<IOURequestStepScan
	route={route}
	navigation={navigation}
	onLayout={(setTestReceiptAndNavigate) => {
	setTestReceiptAndNavigateRef.current = setTestReceiptAndNavigate;
	}}
	isMultiScanEnabled={isMultiScanEnabled}
	setIsMultiScanEnabled={setIsMultiScanEnabled}

App/src/pages/iou/request/IOURequestStartPage.tsx

Lines 78 to 82 in 4c05547

	const [optimisticTransactions] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION_DRAFT, {
	selector: transactionDraftValuesSelector,
	canBeMissing: true,
	});
	const [isMultiScanEnabled, setIsMultiScanEnabled] = useState((optimisticTransactions ?? []).length > 1);

But when editing, the scan page is in its own screen, so no props are passed, thus isMultiScanEnabled is false. We probably hold the state in the start page component because we need to clear the state when the tab changes.

App/src/pages/iou/request/IOURequestStartPage.tsx

Lines 142 to 148 in 4c05547

	const resetIOUTypeIfChanged = useCallback(
	(newIOUType: IOURequestType) => {
	Keyboard.dismiss();
	if (transaction?.iouRequestType === newIOUType) {
	return;
	}
	setIsMultiScanEnabled(false);

What changes do you think we should make in order to solve the problem?

We need to check if isStartingScan is true here too which indicates that this is from the start page.

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Lines 652 to 654 in d335917

	if (!isMultiScanEnabled) {
	removeDraftTransactions(true);
	}

What alternative solutions did you explore? (Optional)

We need to move the state down to the scan page, both index and index.native files, so we won't need to pass down the props anymore.

Then we can remove setIsMultiScanEnabled call here,

App/src/pages/iou/request/IOURequestStartPage.tsx

Lines 142 to 149 in 4c05547

	const resetIOUTypeIfChanged = useCallback(
	(newIOUType: IOURequestType) => {
	Keyboard.dismiss();
	if (transaction?.iouRequestType === newIOUType) {
	return;
	}
	setIsMultiScanEnabled(false);
	initMoneyRequest({

And to disable the multi scan when switching tabs, we can forward a ref and expose the set state function.

scanPageRef.current.setIsMultiScanEnabled(false);

[RachCHopkins]

Can repro perfectly on Safari - great repro steps thank you @mitarachim !!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022010878582663122873

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @truph01 (External)

[yatin-italy]

Proposal

Restate the problem this issue is trying to solve.
Replacing a receipt from the scan screen clears sibling drafts and rebuilds the draft for the replaced receipt, wiping To/Amount. This happens because the scan screen defaults to single-scan when opened alone.

What is the root cause of that problem?
isMultiScanEnabled is lost when the scan page mounts standalone. It defaults to false, which triggers removeDraftTransactions(true) and rebuilds a new optimistic transaction instead of using the existing draft.

What changes do you think we should make in order to solve the problem?

• Add a local state to hydrate isMultiScanEnabled from existing drafts:

const [isMultiScanEnabledLocal, setIsMultiScanEnabledLocal] = useState(isMultiScanEnabled);

• Update local state if multiple transactions exist:

useEffect(() => {
    if (!isMultiScanEnabledLocal && (transactions?.length ?? 0) > 1) {
        setIsMultiScanEnabledLocal(true);
    }
}, [transactions, isMultiScanEnabledLocal]);

• Only clear drafts if truly in single-scan mode:

if (!isMultiScanEnabledLocal) {
    removeDraftTransactions(true);
}

• When replacing files, reuse existing drafts to preserve To/Amount:

const existingDraft = transactions?.[index];
const transaction = shouldReuseInitialTransaction(
    initialTransaction,
    shouldAcceptMultipleFiles,
    index,
    isMultiScanEnabledLocal,
    transactions
)
    ? (existingDraft ?? initialTransaction ?? {})
    : buildOptimisticTransactionAndCreateDraft({
          initialTransaction: initialTransaction as Partial<Transaction>,
          currentUserPersonalDetails,
          reportID,
      });

What alternative solutions did you explore? (Optional)
None

[annaweber830]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When creating an expense via multi-scan (upload 2 receipts) and then using Receipt → 3-dot → Replace on the confirmation flow:

• Replacing one receipt can cause the other receipt draft to disappear.
• Replacing the second receipt (after navigating with the next arrow) can leave the confirmation page in a broken state (e.g., “To” disappears and amount becomes 0.00).

What is the root cause of that problem?

The scan step (IOURequestStepScan) is opened standalone when initiated from the receipt modal/confirmation flow (it is passed a backTo route). In this context, it behaves like single-scan and runs logic that clears draft transactions (removeDraftTransactions(true)), which wipes sibling multi-scan drafts and can reset/invalidly rebuild the confirmation state.

What changes do you think we should make in order to solve the problem?

• Treat “Replace receipt” launched from the confirmation/receipt modal as a distinct flow (detectable via backTo).
• In that flow:
  • Do not clear draft transactions.
  • Only update the targeted transaction’s draft receipt in Onyx (setMoneyRequestReceipt for that transactionID).
  • Navigate back to the backTo route.
• Keep the existing “edit existing transaction” behavior (action === EDIT) unchanged (still uses the API replace action).
  Apply the same behavior on both web and native implementations of IOURequestStepScan.
  

  App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

  Lines 652 to 654 in 8f123f4

  	if (!isMultiScanEnabled) {
  	removeDraftTransactions(true);
  	}

if (backTo) {
            const file = files.at(0);
            if (!file) {
                return;
            }

            const source = URL.createObjectURL(file as Blob);
            setMoneyRequestReceipt(initialTransactionID, source, file.name ?? '', true, file.type);
            navigateBack();
            return;
        }

        if (!isMultiScanEnabled) {
            removeDraftTransactions(true);
        }

App/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

Lines 634 to 636 in 8f123f4

	if (!isMultiScanEnabled) {
	removeDraftTransactions(true);
	}

if (backTo) {
            const file = files.at(0);
            if (!file) {
                return;
            }
            setMoneyRequestReceipt(initialTransactionID, file.uri ?? '', file.name ?? '', true, file.type);
            Navigation.goBack(backTo);
            return;
        }

        if (!isMultiScanEnabled) {
            removeDraftTransactions(true);
        }

What alternative solutions did you explore? (Optional)