[Due for payment 2026-04-14] [$250] 79110-PR78268-Workspace-Incorrect count of categories added

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.96-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #78268
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation (hyperlinked to channel name):

Action Performed:

Preconditions: Log in as the workspace admin, and download the categories CSV.
Edit the downloaded file by adding a few new categories.

1. Navigate to https://staging.new.expensify.com/
2. Go to any workspace settings > Categories > More > Import spreadsheet
3. Select the modified file > Import

Expected Result:

The message should display the correct count of categories added, as occurs when members are added via a CSV file.

Actual Result:

The message displays "21 categories have been added" instead of "2 categories have been added".
The modified CSV has only two new categories.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7044570_1767970519576.Categories_message.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022014471458730225821
• Upwork Job ID: 2014471458730225821
• Last Price Increase: 2026-01-29
• Automatic offers:
• abzokhattab | Reviewer | 110279456

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace-Incorrect count of categories added

What is the root cause of that problem?

We dont have any filter here to filter already exist categories:

App/src/libs/actions/Policy/Category.ts

Lines 649 to 656 in c99a23e

	const uniqueCategories = categories.reduce<Record<string, PolicyCategory>>((acc, category) => {
	if (!category.name) {
	return acc;
	}
	acc[category.name] = category;
	return acc;
	}, {});
	const categoriesLength = Object.keys(uniqueCategories).length;

So we always display all categories length

What changes do you think we should make in order to solve the problem?

We should update this logic to track removed and added categories, for that we can update funcation like that:

function importPolicyCategories(policyID: string, categories: PolicyCategory[], policyCategories?: Record<string, PolicyCategory>) {
    const importedMap = categories.reduce<Record<string, true>>((acc, category) => {
        if (!category.name) {
            return acc;
        }
        acc[category.name] = true;
        return acc;
    }, {});

    const existingMap = Object.keys(policyCategories ?? {}).reduce<Record<string, true>>((acc, name) => {
        acc[name] = true;
        return acc;
    }, {});

    const added = Object.keys(importedMap).filter((name) => !existingMap[name]).length;
    const removed = Object.keys(existingMap).filter((name) => !importedMap[name]).length;

    const diff: SpreadCategoriesParams = {added, removed};

    const onyxData = updateImportSpreadsheetData(diff);

    const parameters = {
        policyID,
        // eslint-disable-next-line @typescript-eslint/naming-convention
        categories: JSON.stringify([...categories.map((category) => ({name: category.name, enabled: category.enabled, 'GL Code': String(category['GL Code'])}))]),
    };

    API.write(WRITE_COMMANDS.IMPORT_CATEGORIES_SPREADSHEET, parameters, onyxData);
}

Update this function:

App/src/libs/actions/Policy/Category.ts

Lines 265 to 282 in c99a23e

	function updateImportSpreadsheetData(categoriesLength: number) {
	const onyxData: OnyxData = {
	successData: [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: ONYXKEYS.IMPORTED_SPREADSHEET,
	value: {
	shouldFinalModalBeOpened: true,
	importFinalModal: {
	titleKey: 'spreadsheet.importSuccessfulTitle',
	promptKey: 'spreadsheet.importCategoriesSuccessfulDescription',
	promptKeyParams: {
	categories: categoriesLength,
	},
	},
	},
	},
	],

function updateImportSpreadsheetData({added, removed}: SpreadCategoriesParams) {
    const onyxData: OnyxData = {
        successData: [
            {
                onyxMethod: Onyx.METHOD.MERGE,
                key: ONYXKEYS.IMPORTED_SPREADSHEET,
                value: {
                    shouldFinalModalBeOpened: true,
                    importFinalModal: {
                        titleKey: 'spreadsheet.importSuccessfulTitle',
                        promptKey: 'spreadsheet.importCategoriesSuccessfulDescription',
                        promptKeyParams: {
                            added,
                            removed,
                        },
                    },
                },
            },
        ],

And update translations:

App/src/languages/en.ts

Line 986 in 30a48e2

importCategoriesSuccessfulDescription: ({categories}: SpreadCategoriesParams) => (categories > 1 ? `${categories} categories have been added.` : '1 category has been added.'),

        importCategoriesSuccessfulDescription: ({added, removed}: SpreadCategoriesParams) => {
            if (added > 0 && removed > 0) {
                return added === 1 && removed === 1
                    ? '1 category has been added and 1 category has been removed.'
                    : `${added} categories have been added and ${removed} categories have been removed.`;
            }

            if (added > 0) {
                return added === 1 ? '1 category has been added.' : `${added} categories have been added.`;
            }

            if (removed > 0) {
                return removed === 1 ? '1 category has been removed.' : `${removed} categories have been removed.`;
            }

            return 'Categories were not updated.';
        },

(We can improve this function, just mocked function for proposal)

We should also update types and make changes for every language. We should also check how GL Code works, Since it may not work with this logic, we will need to check it and correct it if necessary.

PS: We need to aWe also need changes on the backend so that users can download fewer categories than are currently available. If this is not necessary, my proposal can be simplified by tracking only added items, without deleted ones.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Workspace-Incorrect count of categories added

What is the root cause of that problem?

• When importing categories from a file, the app does not check whether a category already exists. As a result, it treats every category in the file as new, regardless of whether it matches an existing one.
• The logic responsible for calculating the number of added categories is located in:

  • App/src/pages/workspace/categories/ImportedCategoriesPage.tsx

    Line 114 in 3bf7f14

    if (categories) {

  • App/src/libs/actions/Policy/Category.ts

    Line 648 in 3bf7f14

    function importPolicyCategories(policyID: string, categories: PolicyCategory[]) {

What changes do you think we should make in order to solve the problem?

• We should only consider a category as new if it differs from an existing one based on the name, enabled status, or GL Code. (Because we only send these three props to BE here)
• The filtering logic can be updated at

  App/src/pages/workspace/categories/ImportedCategoriesPage.tsx

  Lines 114 to 117 in 3bf7f14

  	if (categories) {
  	setIsImportingCategories(true);
  	importPolicyCategories(policyID, categories);
  	}

  as follows:

const newCategories = categories.filter((category) => {
    const existing = policyCategories?.[category.name];

    if (!existing) {
        return true;
    }

    return (
        existing.enabled !== category.enabled ||
        (existing['GL Code'] ?? '') !== (category['GL Code'] ?? '')
    );
});

if (newCategories.length > 0) {
    setIsImportingCategories(true);
    importPolicyCategories(policyID, newCategories);
}

• In addition, at

  App/src/libs/actions/Policy/Category.ts

  Line 658 in 3bf7f14
  , we can add an early return to skip unnecessary processing when there are no new categories:

if (categoriesLength === 0) {
    Onyx.update([...onyxData.successData]);
    return;
}

• Finally, we should update the translation string at

  App/src/languages/en.ts

  Line 989 in 3bf7f14

  importCategoriesSuccessfulDescription: ({categories}: SpreadCategoriesParams) => (categories > 1 ? `${categories} categories have been added.` : '1 category has been added.'),

  to handle the zero case:

importCategoriesSuccessfulDescription: ({categories}: SpreadCategoriesParams) => {
    if (categories === 0) {
        return 'No categories have been added.';
    }
    return categories > 1 ? `${categories} categories have been added.` : '1 category has been added.';
},

What alternative solutions did you explore? (Optional)

[melvin-bot]

@stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@stephanieelliott 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@stephanieelliott 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022014471458730225821

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abzokhattab (External)