Reports - Reimbursable total and Non-reimbursable total are wrong

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.82-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #77812
Email or phone of affected tester (no customers): odjsodijsdoinjsdoi@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Mac 26.1 / Chrome
App Component: Search

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create an expense of amount 50 and make it reimbursable.
4. Create another expense of amount 25 and make it non-reimbursable.
5. Go to Reports > Reports.
6. Click Columns.
7. Select Reimbursable total and Non-reimbursable total.
8. Click Save.

Expected Result:

Reimbursable total should be 50.00.
Non-reimbursable total should be 25.00.

Actual Result:

Reimbursable total is 100.00.
Non-reimbursable total is -25.00.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7033166_1766087265983.10.1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reports - Reimbursable total and Non-reimbursable total are wrong
When viewing expense reports with custom columns for "Reimbursable total" and "Non-reimbursable total", the displayed amounts are incorrect. A report with a $50 reimbursable expense and a $25 non-reimbursable expense shows Reimbursable total as $100 and Non-reimbursable total as -$25 instead of the expected $50 and $25.

What is the root cause of that problem?

In ExpenseReportListItemRow.tsx, the total value is multiplied by -1 for EXPENSE reports to convert it to a positive display value. However, the nonReimbursableTotal from the report data is not receiving the same sign treatment.

App/src/components/SelectionListWithSections/Search/ExpenseReportListItemRow.tsx

Lines 83 to 84 in 24fac31

	const nonReimbursableTotal = item.nonReimbursableTotal ?? 0;
	const reimbursableTotal = total - nonReimbursableTotal;

When calculating reimbursableTotal = total - nonReimbursableTotal, both values should have the same sign convention applied. Currently:

• total is converted to positive (e.g., -75 becomes 75)
• nonReimbursableTotal remains negative (e.g., -25 stays -25)
• Result: 75 - (-25) = 100 (incorrect, should be 50)

What changes do you think we should make in order to solve the problem?

Update ExpenseReportListItemRow.tsx to apply the same sign conversion to nonReimbursableTotal:

const nonReimbursableTotal = item.type === CONST.REPORT.TYPE.EXPENSE || item.type === CONST.REPORT.TYPE.INVOICE 
    ? -(item.nonReimbursableTotal ?? 0)
    : item.type === CONST.REPORT.TYPE.IOU 
    ? Math.abs(item.nonReimbursableTotal ?? 0)
    : (item.nonReimbursableTotal ?? 0);
const reimbursableTotal = total - nonReimbursableTotal;

here

App/src/components/SelectionListWithSections/Search/ExpenseReportListItemRow.tsx

Lines 83 to 84 in 24fac31

	const nonReimbursableTotal = item.nonReimbursableTotal ?? 0;
	const reimbursableTotal = total - nonReimbursableTotal;

This ensures both total and nonReimbursableTotal use the same sign convention before the subtraction.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.