[Due for payment 2026-01-07] Applied filters are in empty state after resetting filters and closing RHP without saving it

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.81-5
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #77673
Email or phone of affected tester (no customers): sjdnisnjosjoisnjsiod@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Mac 26.1 / Chrome
App Component: Search

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Reports > Expenses.
3. Click Filters.
4. Click From.
5. Select any user > Save.
6. Click View results.
7. Click Filters.
8. Click Reset filters.
9. Close the RHP without saving it.
10. Click Reset filters.

Expected Result:

From filter should remain applied and Reset filters button will appear because user did not click View results after resetting filters.

Actual Result:

From filter is empty and Reset filters button does not appear when user did not click View results after resetting filters.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Applied filters are in empty state after resetting filters and closing RHP without saving it

What is the root cause of that problem?

When the user clicks "Reset filters", it directly clears ONYXKEYS.FORMS.SEARCH_ADVANCED_FILTERS_FORM using `clearAdvancedFilters

App/src/libs/actions/Search.ts

Lines 961 to 979 in c43ba15

	function clearAdvancedFilters() {
	const values: Partial<Nullable<SearchAdvancedFiltersForm>> = {};
	for (const key of Object.values(FILTER_KEYS)) {
	switch (key) {
	case FILTER_KEYS.GROUP_BY:
	continue;
	case FILTER_KEYS.COLUMNS:
	continue;
	case FILTER_KEYS.TYPE:
	values[key] = CONST.SEARCH.DATA_TYPES.EXPENSE;
	continue;
	case FILTER_KEYS.STATUS:
	values[key] = CONST.SEARCH.STATUS.EXPENSE.ALL;
	continue;
	default:
	values[key] = null;
	}
	}
	Onyx.merge(ONYXKEYS.FORMS.SEARCH_ADVANCED_FILTERS_FORM, values);

The filter form is synced with the current query in SearchPage, but this useEffect only runs when formValues changes, which is derived from queryJSON

App/src/pages/Search/SearchPage.tsx

Lines 197 to 204 in c43ba15

	const formValues = queryJSON
	? buildFilterFormValuesFromQuery(queryJSON, policyCategories, policyTagsLists, currencyList, personalDetails, allCards, allReports, taxRates)
	: getEmptyObject<Partial<SearchAdvancedFiltersForm>>();
	// Sync the advanced filters form with the current query when it changes
	useEffect(() => {
	updateAdvancedFilters(formValues, true);
	}, [formValues]);

When the user closes the filters RHP without saving, the queryJSON hasn't changed (it's still the applied query), so the useEffect doesn't re-run to restore the filter form values. The form remains in the cleared state from when "Reset filters" was clicked

What changes do you think we should make in order to solve the problem?

We could restore the filter form values from the current query when the advanced filters page mounts with a useEffect that sync the form with the current URL query params

    const [policyCategories] = useOnyx(ONYXKEYS.COLLECTION.POLICY_CATEGORIES, {canBeMissing: true});
    const [policyTagsLists] = useOnyx(ONYXKEYS.COLLECTION.POLICY_TAGS, {canBeMissing: true});
    const [currencyList] = useOnyx(ONYXKEYS.CURRENCY_LIST, {canBeMissing: true});
    const personalDetails = usePersonalDetails();
    const [userCardList] = useOnyx(ONYXKEYS.CARD_LIST, {canBeMissing: false});
    const [workspaceCardFeeds] = useOnyx(ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST, {canBeMissing: false});
    const allCards = useMemo(() => mergeCardListWithWorkspaceFeeds(workspaceCardFeeds ?? CONST.EMPTY_OBJECT, userCardList, true), [userCardList, workspaceCardFeeds]);
    const [allReports] = useOnyx(ONYXKEYS.COLLECTION.REPORT, {canBeMissing: true});
    const [policies] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {canBeMissing: true});
    const taxRates = useMemo(() => getAllTaxRates(policies), [policies]);

    useEffect(() => {
        const queryJSON = getCurrentSearchQueryJSON();
        if (!queryJSON) {
            return;
        }

        const formValues = buildFilterFormValuesFromQuery(queryJSON, policyCategories, policyTagsLists, currencyList, personalDetails, allCards, allReports, taxRates);
        updateAdvancedFilters(formValues, true);
        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
    }, []);

App/src/pages/Search/SearchAdvancedFiltersPage.tsx

Line 20 in c43ba15

What alternative solutions did you explore? (Optional)

None