Columns - From and To columns are not shown in Reports/ Expenses

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.81-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: KI retest #77859
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: MacBook Air 15.6.1 Chrome
App Component: Search

Action Performed:

1. Sign in to ND with a new user
2. Create a workspace
3. Create a manual expense in the workspace chat
4. Navigate to Reports
5. Click Expenses on RHP, observe columns - From and To columns are missing
6. Click Columns menu and verify that From and To are checked
7. Uncheck From, check it back - now both columns are shown
8. Navigate to Reports and back to Expenses - From and To are missing again

Expected Result:

The columns are shown in the table, if they are enabled in the Columns menu

Actual Result:

From and To columns are not shown in the Reports/ Expenses

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Columns - From and To columns are not shown in Reports/ Expenses

What is the root cause of that problem?

When user hadn't customized columns, visibleColumns would contain the default columns. This cause the function to unnecessarily rebuild the column visibility, which worked correctly for explicitly selected columns but didn't check for the fact that these were actually the defaults here.

What changes do you think we should make in order to solve the problem?

We should update getColumnsToShow to check if there are no visible columns or if the visible columns match the default columns, use the default column visibility

if (!visibleColumns.length || arraysEqual(Object.values(CONST.SEARCH.DEFAULT_COLUMNS.EXPENSE_REPORT), visibleColumns)) {
    return reportColumns;
}

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.