IOU - "Previously 0" system message is not displayed when change expense amount from 0

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.73-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: #75542
Issue reported by: Applause - Internal Team

Action Performed:

1. Sign in to ND with Expensifail account
2. Create non-zero manual, scan and manual distance expenses in the workspace chat
3. Change the amount for all three expenses to 0
4. Change the amounts for all expenses to non-zero, observe the system messages

Expected Result:

System messages are shown as:
For distance expense: "changed the distance to 130.00 mi @ $0.70 / mi (previously 0.00 mi @ $0.70 / mi), which updated the amount to $91.00 (previously $0.00)
For manual and scan expenses: "changed the amount to $XX.00 (previously $0.00)"

Actual Result:

System messages are shown as:
For distance expense: "changed the distance to 130.00 mi @ $0.70 / mi (previously 0.00 mi @ $0.70 / mi), which updated the amount to $91.00 (previously )"
For manual and scan expenses: "set the amount to $XX.00"

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug7021964_1764964828423.Previously_0.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU - "Previously 0" system message is not displayed when change expense amount from 0

What is the root cause of that problem?

the code uses a truthy check to determine whether to display the old amount, When oldAmount is 0, the check oldAmountValue ? evaluates to false, causing oldAmount to be set to an empty string instead of "$0.00". This empty string triggers the "set" message path in buildMessageFragmentForValue instead of the "changed" message path, resulting in system messages saying "set the amount to $XX.00" rather than "changed the amount to $XX.00 (previously $0.00)".

here

App/src/libs/ModifiedExpenseMessage.ts

Lines 243 to 247 in 433df87

	if (hasModifiedAmount) {
	const oldCurrency = reportActionOriginalMessage?.oldCurrency;
	const oldAmountValue = reportActionOriginalMessage?.oldAmount ?? 0;
	const oldAmount = oldAmountValue ? convertToDisplayString(reportActionOriginalMessage?.oldAmount ?? 0, oldCurrency) : '';

What changes do you think we should make in order to solve the problem?

We should replace the truthy check with an explicit null/undefined check

const oldAmountValue = reportActionOriginalMessage?.oldAmount;
const oldAmount = oldAmountValue !== undefined && oldAmountValue !== null ? convertToDisplayString(oldAmountValue, oldCurrency) : '';

here

App/src/libs/ModifiedExpenseMessage.ts

Lines 243 to 247 in 433df87

	if (hasModifiedAmount) {
	const oldCurrency = reportActionOriginalMessage?.oldCurrency;
	const oldAmountValue = reportActionOriginalMessage?.oldAmount ?? 0;
	const oldAmount = oldAmountValue ? convertToDisplayString(reportActionOriginalMessage?.oldAmount ?? 0, oldCurrency) : '';

and here

App/src/libs/ModifiedExpenseMessage.ts

Lines 534 to 535 in 433df87

	const oldAmountValue = reportActionOriginalMessage?.oldAmount ?? 0;
	const oldAmount = oldAmountValue ? convertToDisplayString(reportActionOriginalMessage?.oldAmount ?? 0, oldCurrency) : '';

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Result

ModifiedExpenseMessage.mp4

[AndrewGable]

Asked in Slack if we are planning on reverting