[Due for payment 2026-02-04] [$250] Expense - Incorrect split amount is allowed to save

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.72-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2266/folder/13176791/41237172/1054918436?sort=%2Bidentifier
Email or phone of affected tester (no customers): dreamnitethedragon+yydyd373@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app
2. Open workspace chat
3. Create an expense for -₹8
4. Open the expense - more - split the expense
5. Open the split expense
6. Tap amount
7. Remove minus sign from both expenses
8. Tap save
9. Note no error is shown and user is allowed to save
10. Note unexpected error is shown in preview and amount revert to previous one

Expected Result:

When the user removes the minus sign from split amounts and taps Save,
the app must not allow to save

Actual Result:

When the user removes the minus sign from split amounts and taps Save,
the app allows to save

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

+++ Add any screenshot/video evidence

+++

Bug7020718_1764862173248.Screenrecorder-2025-12-04-20-49-55-589.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021996901507741256722
• Upwork Job ID: 1996901507741256722
• Last Price Increase: 2025-12-05

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Burhan-Rashid]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Incorrect split amount is allowed to save

What is the root cause of that problem?

Root cause is that in SplitExpensePage component we are getting the transaction details using this function getTransactionDetails but we are not passing the param allowNegativeAmount, which by default is false, which cause the final amount returned from the getAmount as absolute value:

App/src/pages/iou/SplitExpensePage.tsx

Line 87 in 0983893

const transactionDetails = useMemo<Partial<TransactionDetails>>(() => getTransactionDetails(transaction) ?? {}, [transaction]);

App/src/libs/ReportUtils.ts

Lines 4470 to 4477 in c232c25

	function getTransactionDetails(
	transaction: OnyxInputOrEntry<Transaction> | TransactionWithOptionalSearchFields,
	createdDateFormat: string = CONST.DATE.FNS_FORMAT_STRING,
	policy: OnyxEntry<Policy> = undefined,
	allowNegativeAmount = false,
	disableOppositeConversion = false,
	currentUserDetails = currentUserPersonalDetails,
	): TransactionDetails | undefined {

App/src/libs/ReportUtils.ts

Line 4488 in c232c25

amount: getTransactionAmount(transaction, isFromExpenseReport, transaction?.reportID === CONST.REPORT.UNREPORTED_REPORT_ID, allowNegativeAmount, disableOppositeConversion),

App/src/libs/TransactionUtils/index.ts

Lines 740 to 752 in 488d7bc

	function getAmount(transaction: OnyxInputOrEntry<Transaction>, isFromExpenseReport = false, isFromTrackedExpense = false, allowNegative = false, disableOppositeConversion = false): number {
	// IOU requests cannot have negative values, but they can be stored as negative values, let's return absolute value
	if (!isFromExpenseReport && !isFromTrackedExpense && !allowNegative) {
	const amount = transaction?.modifiedAmount ?? 0;
	if (amount) {
	return Math.abs(amount);
	}
	return Math.abs(transaction?.amount ?? 0);
	}
	if (disableOppositeConversion) {
	return transaction?.amount ?? 0;
	}

Since our transaction amount is absolute value, our validation calculation fails here and we don't return here:

App/src/pages/iou/SplitExpensePage.tsx

Lines 155 to 160 in 0983893

	if (sumOfSplitExpenses > transactionDetailsAmount) {
	const difference = sumOfSplitExpenses - transactionDetailsAmount;
	setErrorMessage(translate('iou.totalAmountGreaterThanOriginal', {amount: convertToDisplayString(difference, transactionDetails?.currency)}));
	return;
	}
	if (sumOfSplitExpenses < transactionDetailsAmount && (isPerDiem || isCard)) {

What changes do you think we should make in order to solve the problem?

we need to pass the param allowNegativeAmount as true here:

App/src/pages/iou/SplitExpensePage.tsx

Line 87 in 0983893

const transactionDetails = useMemo<Partial<TransactionDetails>>(() => getTransactionDetails(transaction) ?? {}, [transaction]);

    const transactionDetails = useMemo<Partial<TransactionDetails>>(() => getTransactionDetails(transaction, undefined, undefined, true) ?? {}, [transaction]);

Note: We can fix the TS related errors during PR phase if any.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When the user removes the minus sign from split amounts and taps Save,
the app allows to save

What is the root cause of that problem?

The bug doesn't occur when creating the split expense; it only occurs when editing the split. In the create split flow, the transaction's reportID is the reportID of the expense report, so isFromExpenseReport is true and the current amount value is returned.

App/src/pages/iou/SplitExpensePage.tsx

Line 87 in ae2850b

const transactionDetails = useMemo<Partial<TransactionDetails>>(() => getTransactionDetails(transaction) ?? {}, [transaction]);

App/src/libs/ReportUtils.ts

Line 4484 in ae2850b

const isFromExpenseReport = !isEmptyObject(report) && isExpenseReport(report);

App/src/libs/TransactionUtils/index.ts

Lines 740 to 750 in ae2850b

	function getAmount(transaction: OnyxInputOrEntry<Transaction>, isFromExpenseReport = false, isFromTrackedExpense = false, allowNegative = false, disableOppositeConversion = false): number {
	// IOU requests cannot have negative values, but they can be stored as negative values, let's return absolute value
	if (!isFromExpenseReport && !isFromTrackedExpense && !allowNegative) {
	const amount = transaction?.modifiedAmount ?? 0;
	if (amount) {
	return Math.abs(amount);
	}
	return Math.abs(transaction?.amount ?? 0);
	}
	if (disableOppositeConversion) {

After creating the split expense, the reportID is -2 and isFromExpenseReport is false, then the absolute amount is returned. So this check is passed.

App/src/pages/iou/SplitExpensePage.tsx

Lines 155 to 160 in 0983893

	if (sumOfSplitExpenses > transactionDetailsAmount) {
	const difference = sumOfSplitExpenses - transactionDetailsAmount;
	setErrorMessage(translate('iou.totalAmountGreaterThanOriginal', {amount: convertToDisplayString(difference, transactionDetails?.currency)}));
	return;
	}
	if (sumOfSplitExpenses < transactionDetailsAmount && (isPerDiem || isCard)) {

What changes do you think we should make in order to solve the problem?

Passing allowNegativeAmount as true can fix this issue, but it doesn't attach the current RCA, since the bug doesn't occur when we take the step during split expense creation.

For the original split transaction, isFromExpenseReport here isn't correct. So we can also check if the policy is paid group policy or not. And pass the policy param here

const isFromExpenseReport = (!isEmptyObject(report) && isExpenseReport(report)) || isPaidGroupPolicyPolicyUtils(policy);

App/src/libs/ReportUtils.ts

Line 4484 in ae2850b

const isFromExpenseReport = !isEmptyObject(report) && isExpenseReport(report);

What alternative solutions did you explore? (Optional)

We can define isFromExpenseReportParam for getTransactionDetails function and pass it as true here

const isFromExpenseReport = isFromExpenseReportParam ?? (!isEmptyObject(report) && isExpenseReport(report));

App/src/libs/ReportUtils.ts

Line 4484 in ae2850b

const isFromExpenseReport = !isEmptyObject(report) && isExpenseReport(report);

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021996901507741256722

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[jjcoffee]

we can also check if the policy is paid group policy or not.

@nkdengineer Could you explain a bit more why this would work?

[nkdengineer]

@jjcoffee The current problem here is 'isFỉomExpenseReport' false for the original split transaction. So we can pass the current policy to getTransactionDetails function and update 'isFromExpenseReport' check to check the related policy is group or not. When 'isFromExpenseReport' is true getAmount function will return the correct amount for this split transaction.