Wallet - Add BA - Country search scrolls to incorrect line

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.67-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176692/test-cases/41236749
Email or phone of affected tester (no customers): applausetester+120125dr01@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: MacOS 15.7.1 / Safari, Chrome, iPhone 16 Pro / 26.1. Google Pixel 5 / Android 14
App Component: User Settings

Action Performed:

1. Login to NewDot with a new Expensifail account
2. Go to Settings > Wallet
3. Click Add bank account
4. Verify your country is selected by default (eg. United States)
5. In the search bar, enter the first letter of another country. For example - A, B, C, D etc.

Expected Result:

Country search scrolls to the correct country starting with selected letters

Actual Result:

Country search scrolls to countries whose names begin with a letter different from the selected one

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7018232_1764654697446.Wallet-BA-Search-Scrolling-Incorrect-Country.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @JS00001 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wallet - Add BA - Country search scrolls to incorrect line

What is the root cause of that problem?

We use substring(2, trimmedSearchValue.length + 2) which extracts the wrong portion of the string for comparison.

When we search for "A", countries like "Albania" should be prioritized but the current code extracts substring(2, 3) which gets the 3rd character only.

It then checks if that single character equals "a", which fails for "Albania" (where the 3rd char is "a" in "alalbania").

This causes incorrect sorting, and since scrolling is based on the first matching item, it scrolls to the wrong country

App/src/libs/searchOptions.ts

Lines 32 to 39 in 4294b92

	const optionASubstring = a.searchValue.toLowerCase().substring(2, trimmedSearchValue.length + 2);
	const optionBSubstring = b.searchValue.toLowerCase().substring(2, trimmedSearchValue.length + 2);
	if (optionASubstring === trimmedSearchValue.toLowerCase()) {
	return -1;
	}
	if (optionBSubstring === trimmedSearchValue.toLowerCase()) {
	return 1;
	}

What changes do you think we should make in order to solve the problem?

We need to check if the country name begins with the search term. The searchValue contains the country code followed by the country name.

const countryCodeLength = 2;
const optionACountryName = a.searchValue.toLowerCase().substring(countryCodeLength);
const optionBCountryName = b.searchValue.toLowerCase().substring(countryCodeLength);
if (optionACountryName.startsWith(trimmedSearchValue.toLowerCase())) {
    return -1;
}
if (optionBCountryName.startsWith(trimmedSearchValue.toLowerCase())) {
    return 1;
}

App/src/libs/searchOptions.ts

Lines 32 to 39 in 4294b92

	const optionASubstring = a.searchValue.toLowerCase().substring(2, trimmedSearchValue.length + 2);
	const optionBSubstring = b.searchValue.toLowerCase().substring(2, trimmedSearchValue.length + 2);
	if (optionASubstring === trimmedSearchValue.toLowerCase()) {
	return -1;
	}
	if (optionBSubstring === trimmedSearchValue.toLowerCase()) {
	return 1;
	}

This ensures that when user type "P", countries like "Pakistan", "Panama" are correctly prioritized at the top of the list, and the scroll position goes to the correct country.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.