[$250] Scan - Dismissed photo appears on the final review when uploading receipt after taking photo

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.64-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2174/folder/13176933/41237698/1039337990?sort=%2Bidentifier
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Device used: iPhone 13 iOS 18.6.2 Hybrid
App Component: Money Requests

Action Performed:

1. Open the app
2. Navigate to the workspace chat
3. Click on the + button in compose box
4. Select Submit expense
5. Select "Scan" tab
6. Take a picture of a receipt
7. Tap the back button
8. Select the option to upload a receipt
9. Upload a receipt file

Expected Result:

Only the uploaded receipt file is displayed in the final review page

Actual Result:

Dismissed photo appears on the confirmation page when uploading a receipt file after taking a picture

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7013753_1764132490256.ScreenRecording_11-25-2025_23-41-54_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021998581188056764453
• Upwork Job ID: 1998581188056764453
• Last Price Increase: 2025-12-10
• Automatic offers:
• abzokhattab | Reviewer | 109821910
• samranahm | Contributor | 109821915

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-12-13 05:51:39 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Scan - Dismissed photo appears on the final review when uploading receipt after taking photo

What is the root cause of that problem?

When a user takes a photo in the Scan tab, a transaction is created with that photo as the receipt. If the user then navigates back to the Scan tab and uploads a file, the system treat this as an additional receipt (creating a new transaction) rather than replacing the existing one, because the existing transaction already had a receipt source. This happen because the logic for handling file uploads setReceiptFilesAndNavigate did not account for the "Single Scan" mode where a new upload should replace the current receipt if only one transaction exists.

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Lines 634 to 636 in e5b83fc

	const transaction =
	!shouldAcceptMultipleFiles || (index === 0 && transactions.length === 1 && (!initialTransaction?.receipt?.source || initialTransaction?.receipt?.isTestReceipt))
	? (initialTransaction as Partial<Transaction>)

What changes do you think we should make in order to solve the problem?

We should update the condition in setReceiptFilesAndNavigate in both index.tsx and index.native.tsx to add !isMultiScanEnabled to ensure that if the user is not in multi-scan mode, the uploaded file replaces the receipt of the existing transaction instead of creating a new one.

If we previously add multiple receipts combine and then navigate back and decide to create just single scan expense we should remove the previous draft transections before for block here

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Line 632 in 8cd91dc

for (const [index, file] of files.entries()) {

if (!isMultiScanEnabled) {
    removeDraftTransactions(true);
}

and update the transaction logic

const transaction =
    initialTransaction &&
    (!shouldAcceptMultipleFiles ||
        (index === 0 && (!isMultiScanEnabled || (transactions.length === 1 && (!initialTransaction.receipt?.source || initialTransaction.receipt?.isTestReceipt)))))

here

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Lines 634 to 636 in e5b83fc

	const transaction =
	!shouldAcceptMultipleFiles || (index === 0 && transactions.length === 1 && (!initialTransaction?.receipt?.source || initialTransaction?.receipt?.isTestReceipt))
	? (initialTransaction as Partial<Transaction>)

• Same implementation for native.tsx

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Result

receipt.upload.mp4

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dismissed photo appears on the confirmation page when uploading a receipt file after taking a picture

What is the root cause of that problem?

When a user takes a photo, it's stored in Onyx (the data persistence layer) via setMoneyRequestReceipt()
When the user navigates back, the receipt data remains in Onyx attached to the initialTransaction

What changes do you think we should make in order to solve the problem?

Add below here, clear receiptFiles when returning to the scan page to prevent dismissed photos from appearing when uploading a new file after navigating back

            if (!isMultiScanEnabled) {
                setReceiptFiles([]);
                removeTransactionReceipt(initialTransactionID);
            }

App/src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

Line 237 in d0a86f2

setDidCapturePhoto(false);

We also want to clear the receipt files here

    useEffect(() => {
        if (isTabActive && !isMultiScanEnabled) {
            setReceiptFiles([]);
            // Also remove the receipt from the initial transaction to prevent creating duplicate transactions
            removeTransactionReceipt(initialTransactionID);
        }
    }, [isTabActive, isMultiScanEnabled, initialTransactionID]);

App/src/pages/iou/request/step/IOURequestStepScan/index.tsx

Line 331 in d0a86f2

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[mallenexpensify]

Will get to in a bit, edge case so not high priority.

[melvin-bot]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

App froze when I tried to test :ragefists:
https://expensify.slack.com/archives/C05LX9D6E07/p1765316015792969

[mallenexpensify]

@samranahm , if you're able to reproduce, please post a vid. Thx