Expense - Per Diem option is not shown after clear cache

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.63-8
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #75716
Email or phone of affected tester (no customers): applausetester+ds@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: Money Requests

Action Performed:

Prerequisite:
Have two workspace with one of them being default and the non default workspace having per diem rates

Steps

1. Navigate to https://staging.new.expensify.com/ > Login
   2, Go to troubleshoot and clear cache & restart
2. Press global create button > Create expense

Expected Result:

Per Diem option option is shown

Actual Result:

Per Diem option is not shown when the per diem rate is in the no default workspace. It is shown after going to inbox.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7013625_1764115660602.Screen_Recording_2025-11-26_at_2.53.12_at_night.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[paulnjs]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• The Per Diem option is not displayed when the per diem rate belongs to a non-default workspace. It only appears after navigating to the Inbox, which triggers a refresh.

What is the root cause of that problem?

• The Per Diem option is only shown if at least one workspace has the Per Diem feature enabled and non-empty rates, as implemented here:

  • App/src/pages/iou/request/IOURequestStartPage.tsx

    Lines 100 to 103 in 29e1abf

    	const policiesWithPerDiemEnabledAndHasRates = useMemo(
    	() => getActivePoliciesWithExpenseChatAndPerDiemEnabledAndHasRates(allPolicies, currentUserPersonalDetails.login),
    	[allPolicies, currentUserPersonalDetails.login],
    	);

  • App/src/libs/PolicyUtils.ts

    Lines 98 to 103 in 29e1abf

    	function getActivePoliciesWithExpenseChatAndPerDiemEnabledAndHasRates(policies: OnyxCollection<Policy> | null, currentUserLogin: string | undefined): Policy[] {
    	return getActivePoliciesWithExpenseChat(policies, currentUserLogin).filter((policy) => {
    	const perDiemCustomUnit = getPerDiemCustomUnit(policy);
    	return policy?.arePerDiemRatesEnabled && !isEmptyObject(perDiemCustomUnit?.rates);
    	});
    	}

• However, the rates data may not be available immediately after clearing the cache. This results in the Per Diem option not being shown initially, even though it should be.

What changes do you think we should make in order to solve the problem?

• We should replace the use of getActivePoliciesWithExpenseChatAndPerDiemEnabledAndHasRates with getActivePoliciesWithExpenseChatAndPerDiemEnabled in the following location:

  • App/src/pages/iou/request/IOURequestStartPage.tsx

    Lines 100 to 103 in 29e1abf

    	const policiesWithPerDiemEnabledAndHasRates = useMemo(
    	() => getActivePoliciesWithExpenseChatAndPerDiemEnabledAndHasRates(allPolicies, currentUserPersonalDetails.login),
    	[allPolicies, currentUserPersonalDetails.login],
    	);

• This will ensure the Per Diem option is displayed as long as the feature is enabled on a workspace, regardless of whether rate data has been fetched yet.

What alternative solutions did you explore? (Optional)

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Per Diem option is not shown when the per diem rate is in the no default workspace. It is shown after going to inbox.

What is the root cause of that problem?

When the app starts after clearing cache, the OpenApp API call returns policy data including arePerDiemRatesEnabled: true, but it doesn't include the full customUnits.rates data immediately

Thus, the Per Diem rate option is hidden

What changes do you think we should make in order to solve the problem?

We should proactively fetches per diem rates for all policies that have per diem enabled when the page is opened from global create like what we did here in IOURequestStepDestination

   useEffect(() => {
        if (!isFromGlobalCreate || isOffline) {
            return;
        }

        const policiesWithPerDiemEnabled = getActivePoliciesWithExpenseChatAndPerDiemEnabled(allPolicies, currentUserPersonalDetails.login);
        policiesWithPerDiemEnabled.forEach((perDiemPolicy) => {
            const perDiemCustomUnit = getPerDiemCustomUnit(perDiemPolicy);
            // Only fetch if rates are not already loaded
            if (isEmptyObject(perDiemCustomUnit?.rates)) {
                fetchPerDiemRates(perDiemPolicy.id);
            }
        });
        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
    }, [isFromGlobalCreate, isOffline]);

App/src/pages/iou/request/IOURequestStartPage.tsx

Line 139 in 1bb0106

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[trjExpensify]

It's intentional to only show workspaces that have per diem rates, not just when enabled: #75807

CC: @mukhrr @aimane-chnaif this is from your PR.

[mukhrr]

It's intentional to only show workspaces that have per diem rates, not just when enabled: #75807

CC: @mukhrr @aimane-chnaif this is from your PR.

@trjExpensify yes, pls, can you assign me here?! Thanks

[aimane-chnaif]

Please assign me here too