[$250] Scan-While scan is in progress, more menu displays submit option

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.2.62-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176933/test-cases/41237708
Email or phone of affected tester (no customers): Dreamnitethedragon sjs@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Money Requests

Action Performed:

1. Launch app
2. Open workspace chat
3. Tap plus icon - scan
4. Upload a photo using camera
5. Tap create expense
6. Open the expense immediately
7. Tap more - submit

Expected Result:

While scan is in progress, more menu must not display submit option.

Actual Result:

While scan is in progress, more menu displays submit option. Tapping submit shows unexpected error.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7010311_1763743364479.Screenrecorder-2025-11-21-22-07-29-914.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021993335684464943742
• Upwork Job ID: 1993335684464943742
• Last Price Increase: 2025-12-02
• Automatic offers:
• QichenZhu | Reviewer | 109689267

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ryntgh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Scan-While scan is in progress, more menu displays submit option

What is the root cause of that problem?

isSubmitAction doesn't check if any transactions have receipts that are currently being scanned

App/src/libs/ReportSecondaryActionUtils.ts

Lines 131 to 148 in 73b42b2

	function isSubmitAction(
	report: Report,
	reportTransactions: Transaction[],
	policy?: Policy,
	reportNameValuePairs?: ReportNameValuePairs,
	reportActions?: ReportAction[],
	isChatReportArchived = false,
	primaryAction?: ValueOf<typeof CONST.REPORT.PRIMARY_ACTIONS> | '',
	): boolean {
	if (isArchivedReport(reportNameValuePairs) || isChatReportArchived) {
	return false;
	}
	const transactionAreComplete = reportTransactions.every((transaction) => transaction.amount !== 0 || transaction.modifiedAmount !== 0);
	if (!transactionAreComplete) {
	return false;
	}

Meanwhile, isApproveAction function has isAnyReceiptBeingScanned check for scanned receipt

App/src/libs/ReportSecondaryActionUtils.ts

Lines 203 to 208 in 73b42b2

	function isApproveAction(currentUserLogin: string, report: Report, reportTransactions: Transaction[], violations: OnyxCollection<TransactionViolation[]>, policy?: Policy): boolean {
	const isAnyReceiptBeingScanned = reportTransactions?.some((transaction) => isReceiptBeingScanned(transaction));
	if (isAnyReceiptBeingScanned) {
	return false;
	}

What changes do you think we should make in order to solve the problem?

We need to add a check in isSubmitAction to prevent showing the submit option when any receipt is being scanned, similar to how isApproveAction handles it

    const isAnyReceiptBeingScanned = reportTransactions?.some((transaction) => isReceiptBeingScanned(transaction));
    if (isAnyReceiptBeingScanned) {
        return false;
    }

App/src/libs/ReportSecondaryActionUtils.ts

Line 143 in 73b42b2

We could also use isScanning instead of isReceiptBeingScanned

What alternative solutions did you explore? (Optional)

We can filter out SUBMIT action if scanning in applicableSecondaryActions

    const isAnyReceiptBeingScanned = transactions.some((transaction) => isScanning(transaction));
    const applicableSecondaryActions = secondaryActions
        .map((action) => secondaryActionsImplementation[action])
        .filter((action) => {
            if (action?.value === CONST.REPORT.SECONDARY_ACTIONS.SUBMIT && isAnyReceiptBeingScanned) {
                return false;
            }
            return action?.shouldShow !== false && action?.value !== primaryAction;
        });

App/src/components/MoneyReportHeader.tsx

Lines 1269 to 1271 in 73b42b2

	const applicableSecondaryActions = secondaryActions
	.map((action) => secondaryActionsImplementation[action])
	.filter((action) => action?.shouldShow !== false && action?.value !== primaryAction);

Or we can add shouldShow: !isAnyReceiptBeingScanned here

App/src/components/MoneyReportHeader.tsx

Lines 986 to 1000 in 73b42b2

	[CONST.REPORT.SECONDARY_ACTIONS.SUBMIT]: {
	value: CONST.REPORT.SECONDARY_ACTIONS.SUBMIT,
	text: translate('common.submit'),
	icon: expensifyIcons.Send,
	onSelected: () => {
	if (!moneyRequestReport) {
	return;
	}
	if (hasDynamicExternalWorkflow(policy)) {
	showDWEModal();
	return;
	}
	submitReport(moneyRequestReport, policy, accountID, email ?? '', hasViolations, isASAPSubmitBetaEnabled);
	},
	},

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-11-26 06:21:04 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

While scan is in progress, more menu displays submit option. Tapping submit shows unexpected error.

What is the root cause of that problem?

We already returned early here if all transactions are not complete. But when the expense is created, the modifiedAmount is undefined, which causes this check to be wrong.

App/src/libs/ReportSecondaryActionUtils.ts

Lines 144 to 148 in 70a5eac

	const transactionAreComplete = reportTransactions.every((transaction) => transaction.amount !== 0 || transaction.modifiedAmount !== 0);
	if (!transactionAreComplete) {
	return false;
	}

What changes do you think we should make in order to solve the problem?

We should use getAmount function to get to correct amount here

const transactionAreComplete = reportTransactions.every((transaction) => getAmount(transaction) !== 0);

App/src/libs/ReportSecondaryActionUtils.ts

Lines 144 to 148 in 70a5eac

	const transactionAreComplete = reportTransactions.every((transaction) => transaction.amount !== 0 || transaction.modifiedAmount !== 0);
	if (!transactionAreComplete) {
	return false;
	}

Or when building the optimistic transaction, we should update the amount to 0 instead of -0

Optional: We can also update the isScanning check here. Even if we update this logic here, we still need to correct transactionAreComplete check. Then, when the scan fails, the submit button will not appear.

if (reportTransactions.length > 0 && reportTransactions.every((transaction) => isPending(transaction) || isScanning(transaction))) { 

App/src/libs/ReportSecondaryActionUtils.ts

Line 154 in 70a5eac

if (reportTransactions.length > 0 && reportTransactions.every((transaction) => isPending(transaction))) {

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021993335684464943742

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @QichenZhu (External)

[QichenZhu]

@nkdengineer thanks for the proposal! The issue is not -0 since -0 === 0 in JavaScript. The actual cause is null !== 0 or '' !== 0. Also, since 0 will become a valid amount soon, the other proposal works better long term.