When we previously brought over approvals into NewDot, we decided to descope a less used feature that adds approvers to the approval chain when a report exceeds a certain amount (e.g. overLimitFowardsTo). Now we're coming back to add that same feature in product. The main considerations are:
Approval workflow creation
We'll add a new step in the creation flow, which comes after the employee and approver selections. This will be an optional step, with Skip and Next options.
If a user clicks Next without entering either the report total or the additional approver, we'll error like so.
If a user clicks Next without entering both a report total and an additional approver, we'll error like so.
A final type of error occurs when an approver is configured as an additional approver tied to a report limit, but they have already approved earlier in the workflow. For that case, the following error will appear.
For clarity, this is a GIF of the full end-to-end creation flow.
Approval workflow summary
The main note for the approval summary is that, if an approval limit is set for an approver, we'll show Reports above [amount] forward to [member].
Editing approval workflows
There are no strict changes to this flow, though I've shared a recording below so we can verify everything works as expected when we to the PR and unit tests.
I think that's it, though a note that I'm adding the internal label because this issue is not open for proposals. It will be worked on internally, in conjunction with C+
Issue Owner
Current Issue Owner: @JmillsExpensify
When we previously brought over approvals into NewDot, we decided to descope a less used feature that adds approvers to the approval chain when a report exceeds a certain amount (e.g.
overLimitFowardsTo). Now we're coming back to add that same feature in product. The main considerations are:Approval workflow creation
We'll add a new step in the creation flow, which comes after the employee and approver selections. This will be an optional step, with
SkipandNextoptions.If a user clicks
Nextwithout entering either the report total or the additional approver, we'll error like so.If a user clicks
Nextwithout entering both a report total and an additional approver, we'll error like so.A final type of error occurs when an approver is configured as an additional approver tied to a report limit, but they have already approved earlier in the workflow. For that case, the following error will appear.
For clarity, this is a GIF of the full end-to-end creation flow.
Approval workflow summary
The main note for the approval summary is that, if an approval limit is set for an approver, we'll show
Reports above [amount] forward to [member].Editing approval workflows
There are no strict changes to this flow, though I've shared a recording below so we can verify everything works as expected when we to the PR and unit tests.
I think that's it, though a note that I'm adding the internal label because this issue is not open for proposals. It will be worked on internally, in conjunction with C+
Issue Owner
Current Issue Owner: @JmillsExpensify