[Due for payment 2025-12-16] Add Group by to the Filters RHP of Reports > Expenses

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.60-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: @puneetlath

Action Performed:

1. Go to Reports > Expenses
2. Click Filters
3. Observe no "Group by" filter

Expected Result:

• We should show the "Group by" option in the Filters RHP on Reports > Expenses.

Actual Result:

We didn't add it here, only the Accounting suggested searches.

Workaround:

N/A

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

In-line above.

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We didn't add it here, only the Accounting suggested searches.

What is the root cause of that problem?

"Group by" only appears when already set. It should always be available

App/src/hooks/useAdvancedSearchFilters.ts

Lines 263 to 264 in 9d3daec

	const shouldDisplayGroupByFilter = !!groupBy;
	const shouldDisplayGroupCurrencyFilter = shouldDisplayGroupByFilter;

What changes do you think we should make in order to solve the problem?

We should set the value as this

    const shouldDisplayGroupByFilter = true;
    const shouldDisplayGroupCurrencyFilter = !!groupBy;

App/src/hooks/useAdvancedSearchFilters.ts

Lines 263 to 264 in 9d3daec

	const shouldDisplayGroupByFilter = !!groupBy;
	const shouldDisplayGroupCurrencyFilter = shouldDisplayGroupByFilter;

Or we can remove this condition

App/src/hooks/useAdvancedSearchFilters.ts

Lines 296 to 298 in 9d3daec

	if (key === CONST.SEARCH.SYNTAX_ROOT_KEYS.GROUP_BY && !shouldDisplayGroupByFilter) {
	return;
	}

Note: we can check other fields as well if we want to show it

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[lorretheboy]

🚨 Edited by proposal-police: This proposal was edited at 2025-11-24 07:12:14 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

We didn't add it here, only the Accounting suggested searches.

What is the root cause of that problem?

We only display when it contains value

App/src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

Lines 487 to 488 in d7cf897

	const shouldDisplayGroupByFilter = !!groupBy?.value;
	const shouldDisplayGroupCurrencyFilter = shouldDisplayGroupByFilter && hasMultipleOutputCurrency;

What changes do you think we should make in order to solve the problem?

We should update to always show it out if it is supported

        const shouldDisplayGroupByFilter = isFilterSupported(FILTER_KEYS.GROUP_BY, type?.value ?? CONST.SEARCH.DATA_TYPES.EXPENSE);
        const shouldDisplayGroupCurrencyFilter = shouldDisplayGroupByFilter && !!groupBy?.value && hasMultipleOutputCurrency; // Or check by groupBy if we need to always show it

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[trjExpensify]

@ahmedGaber93 can you please review these proposals today? Thanks!